-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ecr: ISO-friendly tagging #22535
ecr: ISO-friendly tagging #22535
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccECRRepository_\|TestAccECRRepositoryDataSource_' PKG=ecr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20 -run=TestAccECRRepository_\|TestAccECRRepositoryDataSource_ -timeout 180m
=== RUN TestAccECRRepositoryDataSource_basic
=== PAUSE TestAccECRRepositoryDataSource_basic
=== RUN TestAccECRRepositoryDataSource_encryption
=== PAUSE TestAccECRRepositoryDataSource_encryption
=== RUN TestAccECRRepositoryDataSource_nonExistent
=== PAUSE TestAccECRRepositoryDataSource_nonExistent
=== RUN TestAccECRRepository_basic
=== PAUSE TestAccECRRepository_basic
=== RUN TestAccECRRepository_tags
=== PAUSE TestAccECRRepository_tags
=== RUN TestAccECRRepository_immutability
=== PAUSE TestAccECRRepository_immutability
=== RUN TestAccECRRepository_Image_scanning
=== PAUSE TestAccECRRepository_Image_scanning
=== RUN TestAccECRRepository_Encryption_kms
=== PAUSE TestAccECRRepository_Encryption_kms
=== RUN TestAccECRRepository_Encryption_aes256
=== PAUSE TestAccECRRepository_Encryption_aes256
=== CONT TestAccECRRepositoryDataSource_basic
=== CONT TestAccECRRepositoryDataSource_encryption
=== CONT TestAccECRRepository_tags
=== CONT TestAccECRRepository_immutability
=== CONT TestAccECRRepositoryDataSource_nonExistent
=== CONT TestAccECRRepository_basic
=== CONT TestAccECRRepository_Encryption_kms
=== CONT TestAccECRRepository_Encryption_aes256
=== CONT TestAccECRRepository_Image_scanning
--- PASS: TestAccECRRepositoryDataSource_nonExistent (4.67s)
--- PASS: TestAccECRRepositoryDataSource_basic (21.22s)
--- PASS: TestAccECRRepository_immutability (24.92s)
--- PASS: TestAccECRRepository_basic (24.92s)
--- PASS: TestAccECRRepositoryDataSource_encryption (28.63s)
--- PASS: TestAccECRRepository_tags (34.95s)
--- PASS: TestAccECRRepository_Encryption_aes256 (42.32s)
--- PASS: TestAccECRRepository_Encryption_kms (45.81s)
--- PASS: TestAccECRRepository_Image_scanning (51.07s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecr 54.840s
This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #18133
Relates #18593
Relates #22532
Output from acceptance testing (
us-west-2
):Output from acceptance testing (GovCloud):