-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eventbridge: ISO-friendly tagging #22550
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEventsRule_\|TestAccEventsBus_' PKG=events
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 20 -run=TestAccEventsRule_\|TestAccEventsBus_ -timeout 180m
=== RUN TestAccEventsBus_basic
=== PAUSE TestAccEventsBus_basic
=== RUN TestAccEventsBus_tags
=== PAUSE TestAccEventsBus_tags
=== RUN TestAccEventsBus_default
=== PAUSE TestAccEventsBus_default
=== RUN TestAccEventsBus_disappears
=== PAUSE TestAccEventsBus_disappears
=== RUN TestAccEventsBus_partnerEventSource
bus_test.go:170: Environment variable EVENT_BRIDGE_PARTNER_EVENT_SOURCE_NAME is not set
--- SKIP: TestAccEventsBus_partnerEventSource (0.00s)
=== RUN TestAccEventsRule_basic
=== PAUSE TestAccEventsRule_basic
=== RUN TestAccEventsRule_eventBusName
=== PAUSE TestAccEventsRule_eventBusName
=== RUN TestAccEventsRule_role
=== PAUSE TestAccEventsRule_role
=== RUN TestAccEventsRule_description
=== PAUSE TestAccEventsRule_description
=== RUN TestAccEventsRule_pattern
=== PAUSE TestAccEventsRule_pattern
=== RUN TestAccEventsRule_scheduleAndPattern
=== PAUSE TestAccEventsRule_scheduleAndPattern
=== RUN TestAccEventsRule_namePrefix
=== PAUSE TestAccEventsRule_namePrefix
=== RUN TestAccEventsRule_Name_generated
=== PAUSE TestAccEventsRule_Name_generated
=== RUN TestAccEventsRule_tags
=== PAUSE TestAccEventsRule_tags
=== RUN TestAccEventsRule_isEnabled
=== PAUSE TestAccEventsRule_isEnabled
=== RUN TestAccEventsRule_partnerEventBus
rule_test.go:440: Environment variable EVENT_BRIDGE_PARTNER_EVENT_BUS_NAME is not set
--- SKIP: TestAccEventsRule_partnerEventBus (0.00s)
=== RUN TestAccEventsRule_eventBusARN
=== PAUSE TestAccEventsRule_eventBusARN
=== CONT TestAccEventsBus_basic
=== CONT TestAccEventsRule_pattern
=== CONT TestAccEventsRule_eventBusName
=== CONT TestAccEventsBus_tags
=== CONT TestAccEventsRule_basic
=== CONT TestAccEventsRule_description
=== CONT TestAccEventsRule_role
=== CONT TestAccEventsBus_default
=== CONT TestAccEventsRule_eventBusARN
=== CONT TestAccEventsRule_isEnabled
=== CONT TestAccEventsRule_tags
=== CONT TestAccEventsRule_Name_generated
=== CONT TestAccEventsRule_namePrefix
=== CONT TestAccEventsBus_disappears
=== CONT TestAccEventsRule_scheduleAndPattern
--- PASS: TestAccEventsBus_default (5.14s)
--- PASS: TestAccEventsBus_disappears (38.06s)
--- PASS: TestAccEventsRule_namePrefix (54.78s)
--- PASS: TestAccEventsRule_scheduleAndPattern (55.33s)
--- PASS: TestAccEventsRule_eventBusARN (56.48s)
--- PASS: TestAccEventsRule_Name_generated (56.49s)
--- PASS: TestAccEventsRule_role (65.01s)
--- PASS: TestAccEventsRule_pattern (78.91s)
--- PASS: TestAccEventsRule_description (79.16s)
--- PASS: TestAccEventsBus_basic (95.91s)
--- PASS: TestAccEventsRule_isEnabled (96.90s)
--- PASS: TestAccEventsRule_basic (96.99s)
--- PASS: TestAccEventsRule_eventBusName (101.22s)
--- PASS: TestAccEventsBus_tags (111.00s)
--- PASS: TestAccEventsRule_tags (111.10s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/events 119.159s
This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #18593
Relates #22532
Output from acceptance testing (
us-west-2
):Output from acceptance testing (GovCloud):