Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data/aws_vpc_ipam_preview_next_cidr #22643

Merged
merged 5 commits into from
Jan 20, 2022
Merged

data/aws_vpc_ipam_preview_next_cidr #22643

merged 5 commits into from
Jan 20, 2022

Conversation

drewmullen
Copy link
Collaborator

@drewmullen drewmullen commented Jan 18, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #22637

Output from acceptance testing:

$ make testacc TESTS=TestAccDataSourceVPCIpamPreviewNextCidr PKG=ec2 ACCTEST_PARALLELISM=1 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 1 -run='TestAccDataSourceVPCIpamPreviewNextCidr'  -timeout 180m
=== RUN   TestAccDataSourceVPCIpamPreviewNextCidr_ipv4Basic
=== PAUSE TestAccDataSourceVPCIpamPreviewNextCidr_ipv4Basic
=== RUN   TestAccDataSourceVPCIpamPreviewNextCidr_ipv4Allocated
=== PAUSE TestAccDataSourceVPCIpamPreviewNextCidr_ipv4Allocated
=== RUN   TestAccDataSourceVPCIpamPreviewNextCidr_ipv4DisallowedCidr
=== PAUSE TestAccDataSourceVPCIpamPreviewNextCidr_ipv4DisallowedCidr
=== CONT  TestAccDataSourceVPCIpamPreviewNextCidr_ipv4Basic
--- PASS: TestAccDataSourceVPCIpamPreviewNextCidr_ipv4Basic (76.36s)
=== CONT  TestAccDataSourceVPCIpamPreviewNextCidr_ipv4DisallowedCidr
--- PASS: TestAccDataSourceVPCIpamPreviewNextCidr_ipv4DisallowedCidr (60.63s)
=== CONT  TestAccDataSourceVPCIpamPreviewNextCidr_ipv4Allocated
--- PASS: TestAccDataSourceVPCIpamPreviewNextCidr_ipv4Allocated (100.30s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        241.008s
...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 18, 2022
@drewmullen drewmullen requested a review from ewbankkit as a code owner January 19, 2022 14:18
@github-actions github-actions bot added service/appmesh Issues and PRs that pertain to the appmesh service. service/chime Issues and PRs that pertain to the chime service. service/cloud9 Issues and PRs that pertain to the cloud9 service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/codebuild Issues and PRs that pertain to the codebuild service. service/devicefarm Issues and PRs that pertain to the devicefarm service. service/ecr Issues and PRs that pertain to the ecr service. service/fsx Issues and PRs that pertain to the fsx service. service/glue Issues and PRs that pertain to the glue service. service/kafka Issues and PRs that pertain to the kafka service. service/kms Issues and PRs that pertain to the kms service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/s3control Issues and PRs that pertain to the s3control service. labels Jan 19, 2022
@drewmullen
Copy link
Collaborator Author

The last commit is a result of make website-lint-fix fixing docs from prior PRs. It can be dropped if unnecessary

@drewmullen
Copy link
Collaborator Author

drewmullen commented Jan 19, 2022 •
edited
Loading

Its not clear to me what is failing here. I have run the following commands locally:

$ make lint
==> Checking source code with golangci-lint...
==> Checking source code with providerlint...
==> Checking source code with importlint...

$ make semgrep
==> Running Semgrep static analysis...
METRICS: Using configs from the Registry (like --config=p/ci) reports pseudonymous rule metrics to semgrep.dev.
To disable Registry rule metrics, use "--metrics=off".
Using configs only from local files (like --config=xyz.yml) does not enable metrics.

More information: https://semgrep.dev/docs/metrics

Running 29 rules...
ran 29 rules on 2101 files: 0 findings

A new version of Semgrep is available. See https://semgrep.dev/docs/upgrading

$ make website-lint-fix
==> Applying automatic website linter fixes...

There are several errors for deadlinks but they all work fine for me:
image

example: https://www.terraform.io/docs/configuration/outputs.html

@github-actions github-actions bot removed service/codebuild Issues and PRs that pertain to the codebuild service. service/devicefarm Issues and PRs that pertain to the devicefarm service. labels Jan 20, 2022
@github-actions github-actions bot added service/ecr Issues and PRs that pertain to the ecr service. service/fsx Issues and PRs that pertain to the fsx service. service/glue Issues and PRs that pertain to the glue service. service/kafka Issues and PRs that pertain to the kafka service. service/kms Issues and PRs that pertain to the kms service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/s3control Issues and PRs that pertain to the s3control service. labels Jan 20, 2022
@ewbankkit ewbankkit removed service/codebuild Issues and PRs that pertain to the codebuild service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/glue Issues and PRs that pertain to the glue service. service/kms Issues and PRs that pertain to the kms service. service/ecr Issues and PRs that pertain to the ecr service. service/cloud9 Issues and PRs that pertain to the cloud9 service. service/devicefarm Issues and PRs that pertain to the devicefarm service. service/chime Issues and PRs that pertain to the chime service. service/s3control Issues and PRs that pertain to the s3control service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/appmesh Issues and PRs that pertain to the appmesh service. service/fsx Issues and PRs that pertain to the fsx service. service/kafka Issues and PRs that pertain to the kafka service. needs-triage Waiting for first response or review from a maintainer. labels Jan 20, 2022
ewbankkit
ewbankkit approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccDataSourceVPCIpamPreviewNextCidr_ PKG=ec2 ACCTEST_PARALLELISM=1 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 1 -run='TestAccDataSourceVPCIpamPreviewNextCidr_'  -timeout 180m
=== RUN   TestAccDataSourceVPCIpamPreviewNextCidr_ipv4Basic
=== PAUSE TestAccDataSourceVPCIpamPreviewNextCidr_ipv4Basic
=== RUN   TestAccDataSourceVPCIpamPreviewNextCidr_ipv4Allocated
=== PAUSE TestAccDataSourceVPCIpamPreviewNextCidr_ipv4Allocated
=== RUN   TestAccDataSourceVPCIpamPreviewNextCidr_ipv4DisallowedCidr
=== PAUSE TestAccDataSourceVPCIpamPreviewNextCidr_ipv4DisallowedCidr
=== CONT  TestAccDataSourceVPCIpamPreviewNextCidr_ipv4Basic
--- PASS: TestAccDataSourceVPCIpamPreviewNextCidr_ipv4Basic (77.26s)
=== CONT  TestAccDataSourceVPCIpamPreviewNextCidr_ipv4DisallowedCidr
--- PASS: TestAccDataSourceVPCIpamPreviewNextCidr_ipv4DisallowedCidr (59.17s)
=== CONT  TestAccDataSourceVPCIpamPreviewNextCidr_ipv4Allocated
--- PASS: TestAccDataSourceVPCIpamPreviewNextCidr_ipv4Allocated (69.27s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	209.010s

@ewbankkit ewbankkit merged commit 5ed654d into hashicorp:main Jan 20, 2022
@github-actions github-actions bot added this to the v3.73.0 milestone Jan 20, 2022
@drewmullen drewmullen mentioned this pull request Jan 20, 2022
Merged
1 task
@github-actions
Copy link

This functionality has been released in v3.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.73.0
Development

Successfully merging this pull request may close these issues.

data/aws_vpc_ipam_preview_next_cidr
3 participants
@drewmullen @ewbankkit @justinretzolk