Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SES account level suppression list support #22655

Closed
idavidmcdonald opened this issue Jan 19, 2022 · 4 comments · Fixed by #39325
Closed

Add SES account level suppression list support #22655

idavidmcdonald opened this issue Jan 19, 2022 · 4 comments · Fixed by #39325
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/sesv2 Issues and PRs that pertain to the sesv2 service.
Milestone

Comments

@idavidmcdonald
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

SES has three suppression lists

  • global suppression list
  • account level suppression list
  • configuration set level suppression list

There is currently no way to configure the account level suppression list using Terraform so this is a feature request to add it.

There is already an open issue for being able to configure a configuration set level suppression list - #14320 but there is not one for configuring for the account level suppression list.

New or Affected Resource(s)

  • aws_ses_account_level_suppression_list

Potential Terraform Configuration

resource "aws_ses_account_level_suppression_list" "only_suppress_complaint" {
    suppressed_reasons = ["COMPLAINT"]
}

There could maybe be some remit for also including the ability to put email addresses on to the suppression list in this resource (using https://docs.aws.amazon.com/ses/latest/APIReference-V2/API_PutSuppressedDestination.html) but I'm not as sure on that and my suggested code above is more a starting example than a strong steer on what the resource should look like.

References

@idavidmcdonald idavidmcdonald added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 19, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/ses Issues and PRs that pertain to the ses service. labels Jan 19, 2022
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 20, 2022
@chris-denning
Copy link

The description is slightly wrong. AWS makes it clear that there are only 2 suppression lists, not 3: global and account-level.
Yes, you can configure how the account-level suppression list is used at an account level and/or a configuration set level, but any configuration-set level configuration still uses the account suppression list
https://docs.aws.amazon.com/ses/latest/dg/sending-email-suppression-list-config-level.html

@pspot2 pspot2 mentioned this issue Mar 14, 2024
@ewbankkit ewbankkit added service/sesv2 Issues and PRs that pertain to the sesv2 service. and removed service/ses Issues and PRs that pertain to the ses service. labels Sep 11, 2024
@ewbankkit ewbankkit self-assigned this Sep 11, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 11, 2024
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.68.0 milestone Sep 16, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 20, 2024
Copy link

This functionality has been released in v5.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/sesv2 Issues and PRs that pertain to the sesv2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants