-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable code signing in lambda for ap-southeast-3 #22693
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @jinhong- 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
…gProfile' to prevent 'function_test.go:3457: skipping acceptance testing: Signing Platform (AWSLambda-SHA384-ECDSA) not found'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TESTARGS='-run=TestAccLambdaFunction_basic\|TestAccLambdaFunction_codeSigning' PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run=TestAccLambdaFunction_basic\|TestAccLambdaFunction_codeSigning -timeout 180m
=== RUN TestAccLambdaFunction_basic
=== PAUSE TestAccLambdaFunction_basic
=== RUN TestAccLambdaFunction_codeSigning
=== PAUSE TestAccLambdaFunction_codeSigning
=== CONT TestAccLambdaFunction_basic
=== CONT TestAccLambdaFunction_codeSigning
--- PASS: TestAccLambdaFunction_codeSigning (73.21s)
--- PASS: TestAccLambdaFunction_basic (110.13s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/lambda 117.943s
% AWS_DEFAULT_REGION=ap-southeast-3 make testacc TESTARGS='-run=TestAccLambdaFunction_basic\|TestAccLambdaFunction_codeSigning' PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run=TestAccLambdaFunction_basic\|TestAccLambdaFunction_codeSigning -timeout 180m
=== RUN TestAccLambdaFunction_basic
=== PAUSE TestAccLambdaFunction_basic
=== RUN TestAccLambdaFunction_codeSigning
function_test.go:169: Lambda code signing config is not supported in ap-southeast-3 region
--- SKIP: TestAccLambdaFunction_codeSigning (0.00s)
=== CONT TestAccLambdaFunction_basic
function_test.go:46: Step 1/2 error: Check failed: Check 8/9 error: aws_lambda_function.test: Attribute 'architectures.0' not found
--- FAIL: TestAccLambdaFunction_basic (66.80s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/lambda 70.200s
FAIL
make: *** [testacc] Error 1
GovCloud
% make testacc TESTARGS='-run=TestAccLambdaFunction_basic\|TestAccLambdaFunction_codeSigning' PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run=TestAccLambdaFunction_basic\|TestAccLambdaFunction_codeSigning -timeout 180m
=== RUN TestAccLambdaFunction_basic
=== PAUSE TestAccLambdaFunction_basic
=== RUN TestAccLambdaFunction_codeSigning
function_test.go:162: Lambda code signing config is not supported in aws-us-gov partition
--- SKIP: TestAccLambdaFunction_codeSigning (0.00s)
=== CONT TestAccLambdaFunction_basic
function_test.go:46: Step 1/2 error: Check failed: Check 8/9 error: aws_lambda_function.test: Attribute 'architectures.0' not found
--- FAIL: TestAccLambdaFunction_basic (25.65s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/lambda 29.113s
FAIL
make: *** [testacc] Error 1
Failures are unrelated to this change.
@jinhong- Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #22692
Output from acceptance testing: