-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d/api_gateway_export and api_gateway_sdk - new datasources #22731
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TESTARGS='-run=TestAccAPIGatewayExportDataSource_\|TestAccAPIGatewaySdkDataSource_' PKG=apigateway
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigateway/... -v -count 1 -parallel 20 -run=TestAccAPIGatewayExportDataSource_\|TestAccAPIGatewaySdkDataSource_ -timeout 180m
=== RUN TestAccAPIGatewayExportDataSource_basic
=== PAUSE TestAccAPIGatewayExportDataSource_basic
=== RUN TestAccAPIGatewaySdkDataSource_basic
=== PAUSE TestAccAPIGatewaySdkDataSource_basic
=== CONT TestAccAPIGatewayExportDataSource_basic
=== CONT TestAccAPIGatewaySdkDataSource_basic
--- PASS: TestAccAPIGatewayExportDataSource_basic (33.36s)
--- PASS: TestAccAPIGatewaySdkDataSource_basic (85.22s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/apigateway 96.051s
GovCloud
% make testacc TESTARGS='-run=TestAccAPIGatewayExportDataSource_\|TestAccAPIGatewaySdkDataSource_' PKG=apigateway
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigateway/... -v -count 1 -parallel 20 -run=TestAccAPIGatewayExportDataSource_\|TestAccAPIGatewaySdkDataSource_ -timeout 180m
=== RUN TestAccAPIGatewayExportDataSource_basic
=== PAUSE TestAccAPIGatewayExportDataSource_basic
=== RUN TestAccAPIGatewaySdkDataSource_basic
=== PAUSE TestAccAPIGatewaySdkDataSource_basic
=== CONT TestAccAPIGatewayExportDataSource_basic
=== CONT TestAccAPIGatewaySdkDataSource_basic
acctest.go:1008: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
Error: Error creating API Gateway: BadRequestException: Endpoint Configuration type EDGE is not supported in this region: us-gov-west-1
with aws_api_gateway_rest_api.test,
on terraform_plugin_test.tf line 2, in resource "aws_api_gateway_rest_api" "test":
2: resource "aws_api_gateway_rest_api" "test" {
=== CONT TestAccAPIGatewayExportDataSource_basic
acctest.go:1008: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
Error: Error creating API Gateway: BadRequestException: Endpoint Configuration type EDGE is not supported in this region: us-gov-west-1
with aws_api_gateway_rest_api.test,
on terraform_plugin_test.tf line 2, in resource "aws_api_gateway_rest_api" "test":
2: resource "aws_api_gateway_rest_api" "test" {
--- SKIP: TestAccAPIGatewayExportDataSource_basic (13.05s)
--- SKIP: TestAccAPIGatewaySdkDataSource_basic (13.09s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/apigateway 21.051s
This functionality has been released in v3.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #12943
Output from acceptance testing: