Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/api_gateway_export and api_gateway_sdk - new datasources #22731

Merged
merged 12 commits into from
Jan 24, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jan 22, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12943

Output from acceptance testing:

$ make testacc TESTS=TestAccAPIGatewayExportDataSource_basic PKG=apigateway
--- PASS: TestAccAPIGatewayExportDataSource_basic (62.88s)
$ make testacc TESTS=TestAccAPIGatewaySdkDataSource_basic PKG=apigateway
--- PASS: TestAccAPIGatewaySdkDataSource_basic (57.35s)

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/apigateway Issues and PRs that pertain to the apigateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 22, 2022
@DrFaust92 DrFaust92 added the new-data-source Introduces a new data source. label Jan 22, 2022
@DrFaust92 DrFaust92 changed the title d/api_gateway_export - new datasource d/api_gateway_export and api_gateway_sdk - new datasources Jan 22, 2022
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Jan 22, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAPIGatewayExportDataSource_\|TestAccAPIGatewaySdkDataSource_' PKG=apigateway 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigateway/... -v -count 1 -parallel 20  -run=TestAccAPIGatewayExportDataSource_\|TestAccAPIGatewaySdkDataSource_ -timeout 180m
=== RUN   TestAccAPIGatewayExportDataSource_basic
=== PAUSE TestAccAPIGatewayExportDataSource_basic
=== RUN   TestAccAPIGatewaySdkDataSource_basic
=== PAUSE TestAccAPIGatewaySdkDataSource_basic
=== CONT  TestAccAPIGatewayExportDataSource_basic
=== CONT  TestAccAPIGatewaySdkDataSource_basic
--- PASS: TestAccAPIGatewayExportDataSource_basic (33.36s)
--- PASS: TestAccAPIGatewaySdkDataSource_basic (85.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigateway	96.051s
GovCloud
% make testacc TESTARGS='-run=TestAccAPIGatewayExportDataSource_\|TestAccAPIGatewaySdkDataSource_' PKG=apigateway
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigateway/... -v -count 1 -parallel 20  -run=TestAccAPIGatewayExportDataSource_\|TestAccAPIGatewaySdkDataSource_ -timeout 180m
=== RUN   TestAccAPIGatewayExportDataSource_basic
=== PAUSE TestAccAPIGatewayExportDataSource_basic
=== RUN   TestAccAPIGatewaySdkDataSource_basic
=== PAUSE TestAccAPIGatewaySdkDataSource_basic
=== CONT  TestAccAPIGatewayExportDataSource_basic
=== CONT  TestAccAPIGatewaySdkDataSource_basic
    acctest.go:1008: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: Error creating API Gateway: BadRequestException: Endpoint Configuration type EDGE is not supported in this region: us-gov-west-1
        
          with aws_api_gateway_rest_api.test,
          on terraform_plugin_test.tf line 2, in resource "aws_api_gateway_rest_api" "test":
           2: resource "aws_api_gateway_rest_api" "test" {
        
=== CONT  TestAccAPIGatewayExportDataSource_basic
    acctest.go:1008: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: Error creating API Gateway: BadRequestException: Endpoint Configuration type EDGE is not supported in this region: us-gov-west-1
        
          with aws_api_gateway_rest_api.test,
          on terraform_plugin_test.tf line 2, in resource "aws_api_gateway_rest_api" "test":
           2: resource "aws_api_gateway_rest_api" "test" {
        
--- SKIP: TestAccAPIGatewayExportDataSource_basic (13.05s)
--- SKIP: TestAccAPIGatewaySdkDataSource_basic (13.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigateway	21.051s

@ewbankkit ewbankkit merged commit c108562 into hashicorp:main Jan 24, 2022
@github-actions github-actions bot added this to the v3.74.0 milestone Jan 24, 2022
@github-actions
Copy link

This functionality has been released in v3.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@DrFaust92 DrFaust92 deleted the apige_export branch February 12, 2022 12:46
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/apigateway Issues and PRs that pertain to the apigateway service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporting API Gateway REST APIs as OpenAPI 3.0/Swagger
2 participants