-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_imagebuilder_distribution_configuration - add container_distribution_configuration attribute #22758
r/aws_imagebuilder_distribution_configuration - add container_distribution_configuration attribute #22758
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TESTARGS='-run=TestAccImageBuilderDistributionConfiguration_' PKG=imagebuilder
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/imagebuilder/... -v -count 1 -parallel 20 -run=TestAccImageBuilderDistributionConfiguration_ -timeout 180m
=== RUN TestAccImageBuilderDistributionConfiguration_basic
=== PAUSE TestAccImageBuilderDistributionConfiguration_basic
=== RUN TestAccImageBuilderDistributionConfiguration_disappears
=== PAUSE TestAccImageBuilderDistributionConfiguration_disappears
=== RUN TestAccImageBuilderDistributionConfiguration_description
=== PAUSE TestAccImageBuilderDistributionConfiguration_description
=== RUN TestAccImageBuilderDistributionConfiguration_distribution
=== PAUSE TestAccImageBuilderDistributionConfiguration_distribution
=== RUN TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_amiTags
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_amiTags
=== RUN TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_description
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_description
=== RUN TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_kmsKeyID
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_kmsKeyID
=== RUN TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userGroups
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userGroups
=== RUN TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userIDs
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userIDs
=== RUN TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_name
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_name
=== RUN TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_targetAccountIDs
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_targetAccountIDs
=== RUN TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_containerTags
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_containerTags
=== RUN TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_description
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_description
=== RUN TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_targetRepository
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_targetRepository
=== RUN TestAccImageBuilderDistributionConfiguration_Distribution_licenseARNs
=== PAUSE TestAccImageBuilderDistributionConfiguration_Distribution_licenseARNs
=== RUN TestAccImageBuilderDistributionConfiguration_tags
=== PAUSE TestAccImageBuilderDistributionConfiguration_tags
=== CONT TestAccImageBuilderDistributionConfiguration_basic
=== CONT TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userIDs
=== CONT TestAccImageBuilderDistributionConfiguration_tags
=== CONT TestAccImageBuilderDistributionConfiguration_Distribution_licenseARNs
=== CONT TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_targetRepository
=== CONT TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_description
=== CONT TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_containerTags
=== CONT TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_targetAccountIDs
=== CONT TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_name
=== CONT TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_amiTags
=== CONT TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userGroups
=== CONT TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_kmsKeyID
=== CONT TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_description
=== CONT TestAccImageBuilderDistributionConfiguration_description
=== CONT TestAccImageBuilderDistributionConfiguration_distribution
=== CONT TestAccImageBuilderDistributionConfiguration_disappears
=== CONT TestAccImageBuilderDistributionConfiguration_Distribution_licenseARNs
distribution_configuration_test.go:523: Step 1/3 error: Error running apply: exit status 1
Error: Error creating License Manager license configuration: ResourceLimitExceededException: You have reached the maximum allowed number of license configurations created in one day.
with aws_licensemanager_license_configuration.test,
on terraform_plugin_test.tf line 4, in resource "aws_licensemanager_license_configuration" "test":
4: resource "aws_licensemanager_license_configuration" "test" {
--- FAIL: TestAccImageBuilderDistributionConfiguration_Distribution_licenseARNs (25.16s)
--- PASS: TestAccImageBuilderDistributionConfiguration_disappears (58.09s)
--- PASS: TestAccImageBuilderDistributionConfiguration_basic (76.40s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userGroups (76.95s)
--- PASS: TestAccImageBuilderDistributionConfiguration_distribution (88.57s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_description (111.67s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_containerTags (118.12s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userIDs (118.27s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_targetAccountIDs (118.29s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_description (118.30s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_name (118.60s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_amiTags (118.76s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_targetRepository (118.94s)
--- PASS: TestAccImageBuilderDistributionConfiguration_description (119.52s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_kmsKeyID (120.57s)
--- PASS: TestAccImageBuilderDistributionConfiguration_tags (130.72s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder 138.779s
FAIL
make: *** [testacc] Error 1
GovCloud
% make testacc TESTARGS='-run=TestAccImageBuilderDistributionConfiguration_' PKG=imagebuilder
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/imagebuilder/... -v -count 1 -parallel 20 -run=TestAccImageBuilderDistributionConfiguration_ -timeout 180m
=== RUN TestAccImageBuilderDistributionConfiguration_basic
=== PAUSE TestAccImageBuilderDistributionConfiguration_basic
=== RUN TestAccImageBuilderDistributionConfiguration_disappears
=== PAUSE TestAccImageBuilderDistributionConfiguration_disappears
=== RUN TestAccImageBuilderDistributionConfiguration_description
=== PAUSE TestAccImageBuilderDistributionConfiguration_description
=== RUN TestAccImageBuilderDistributionConfiguration_distribution
=== PAUSE TestAccImageBuilderDistributionConfiguration_distribution
=== RUN TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_amiTags
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_amiTags
=== RUN TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_description
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_description
=== RUN TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_kmsKeyID
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_kmsKeyID
=== RUN TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userGroups
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userGroups
=== RUN TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userIDs
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userIDs
=== RUN TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_name
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_name
=== RUN TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_targetAccountIDs
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_targetAccountIDs
=== RUN TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_containerTags
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_containerTags
=== RUN TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_description
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_description
=== RUN TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_targetRepository
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_targetRepository
=== RUN TestAccImageBuilderDistributionConfiguration_Distribution_licenseARNs
=== PAUSE TestAccImageBuilderDistributionConfiguration_Distribution_licenseARNs
=== RUN TestAccImageBuilderDistributionConfiguration_tags
=== PAUSE TestAccImageBuilderDistributionConfiguration_tags
=== CONT TestAccImageBuilderDistributionConfiguration_basic
=== CONT TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userIDs
=== CONT TestAccImageBuilderDistributionConfiguration_tags
=== CONT TestAccImageBuilderDistributionConfiguration_disappears
=== CONT TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_description
=== CONT TestAccImageBuilderDistributionConfiguration_Distribution_licenseARNs
=== CONT TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_targetRepository
=== CONT TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_targetAccountIDs
=== CONT TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_containerTags
=== CONT TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_amiTags
=== CONT TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userGroups
=== CONT TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_kmsKeyID
=== CONT TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_name
=== CONT TestAccImageBuilderDistributionConfiguration_description
=== CONT TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_description
=== CONT TestAccImageBuilderDistributionConfiguration_distribution
=== CONT TestAccImageBuilderDistributionConfiguration_Distribution_licenseARNs
distribution_configuration_test.go:523: Step 1/3 error: Error running apply: exit status 1
Error: Error creating License Manager license configuration: ResourceLimitExceededException: You have reached the maximum allowed number of license configurations created in one day.
with aws_licensemanager_license_configuration.test,
on terraform_plugin_test.tf line 4, in resource "aws_licensemanager_license_configuration" "test":
4: resource "aws_licensemanager_license_configuration" "test" {
--- FAIL: TestAccImageBuilderDistributionConfiguration_Distribution_licenseARNs (38.34s)
--- PASS: TestAccImageBuilderDistributionConfiguration_disappears (72.37s)
--- PASS: TestAccImageBuilderDistributionConfiguration_basic (87.05s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userGroups (89.28s)
--- PASS: TestAccImageBuilderDistributionConfiguration_distribution (107.42s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_name (132.51s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_targetRepository (138.52s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_containerTags (138.86s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_description (139.25s)
--- PASS: TestAccImageBuilderDistributionConfiguration_description (139.33s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_amiTags (139.60s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_targetAccountIDs (139.64s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_description (140.02s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userIDs (140.50s)
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_kmsKeyID (142.19s)
--- PASS: TestAccImageBuilderDistributionConfiguration_tags (155.73s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder 167.625s
FAIL
make: *** [testacc] Error 1
Failures are unrelated to this change.
This functionality has been released in v3.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #16839.
Output from acceptance testing: