aws_cloudformation_stack: use retry logic on IAM role error

[thatderek]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22834

Output from acceptance testing:

➜  terraform-provider-aws git:(master) ✗ make testacc TESTS=TestAccCloudFormationStack_withIAM PKG=cloudformation
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudformation/... -v -count 1 -parallel 20 -run='TestAccCloudFormationStack_withIAM'  -timeout 180m
=== RUN   TestAccCloudFormationStack_withIAM
=== PAUSE TestAccCloudFormationStack_withIAM
=== CONT  TestAccCloudFormationStack_withIAM
--- PASS: TestAccCloudFormationStack_withIAM (67.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation	67.927s
➜  terraform-provider-aws git:(master) ✗

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCloudFormationStack_basic\|TestAccCloudFormationStack_allAttributes' PKG=cloudformation 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudformation/... -v -count 1 -parallel 20  -run=TestAccCloudFormationStack_basic\|TestAccCloudFormationStack_allAttributes -timeout 180m
=== RUN   TestAccCloudFormationStack_basic
=== PAUSE TestAccCloudFormationStack_basic
=== RUN   TestAccCloudFormationStack_allAttributes
=== PAUSE TestAccCloudFormationStack_allAttributes
=== CONT  TestAccCloudFormationStack_basic
=== CONT  TestAccCloudFormationStack_allAttributes
--- PASS: TestAccCloudFormationStack_basic (72.39s)
--- PASS: TestAccCloudFormationStack_allAttributes (87.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation	91.188s

[ewbankkit]

@thatderek Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.