r/aws_ec2_client_vpn_endpoint: Change dns_servers argument from TypeSet to TypeList

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20690.

Output from acceptance testing:

% make testacc TESTARGS='-run=TestAccEC2ClientVPNEndpoint_serial/Endpoint -short' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2ClientVPNEndpoint_serial/Endpoint -short -timeout 180m
=== RUN   TestAccEC2ClientVPNEndpoint_serial
=== PAUSE TestAccEC2ClientVPNEndpoint_serial
=== CONT  TestAccEC2ClientVPNEndpoint_serial
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_withClientConnect
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_withClientConnect
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_msADAuthAndMutualAuth
    client_vpn_endpoint_test.go:250: skipping long-running test in short mode
2022/02/01 16:56:02 [WARN] Notifying semaphore without Wait
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuth
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuth
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuthWithSelfService
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuthWithSelfService
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_selfServicePortal
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_selfServicePortal
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_msADAuth
    client_vpn_endpoint_test.go:214: skipping long-running test in short mode
2022/02/01 16:56:03 [WARN] Notifying semaphore without Wait
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_withClientLoginBanner
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_withClientLoginBanner
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_tags
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_tags
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_basicDataSource
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_basicDataSource
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_basic
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_basic
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_withDNSServers
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_withDNSServers
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_simpleAttributesUpdate
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_simpleAttributesUpdate
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_disappears
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_disappears
=== RUN   TestAccEC2ClientVPNEndpoint_serial/Endpoint_withLogGroup
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/Endpoint_withLogGroup
=== RUN   TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_withClientConnect
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_withClientLoginBanner
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_simpleAttributesUpdate
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_tags
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_basic
=== CONT  TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_withLogGroup
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_disappears
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_withDNSServers
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuthWithSelfService
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_selfServicePortal
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuth
=== CONT  TestAccEC2ClientVPNEndpoint_serial/Endpoint_basicDataSource
--- PASS: TestAccEC2ClientVPNEndpoint_serial (3.72s)
    --- SKIP: TestAccEC2ClientVPNEndpoint_serial/Endpoint_msADAuthAndMutualAuth (0.00s)
    --- SKIP: TestAccEC2ClientVPNEndpoint_serial/Endpoint_msADAuth (0.00s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_basic (29.73s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_simpleAttributesUpdate (37.05s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_tags (50.90s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_withClientLoginBanner (52.45s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_disappears (66.68s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint (84.39s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_withLogGroup (84.78s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_withDNSServers (99.33s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_selfServicePortal (100.79s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuthWithSelfService (104.11s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_basicDataSource (104.54s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_withClientConnect (113.54s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuth (116.79s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        124.032s

[YakDriver]

Order matters. Looks great! 🎉

Output:

% make testacc TESTARGS='-run=TestAccEC2ClientVPNEndpoint_serial/Endpoint -short' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2ClientVPNEndpoint_serial/Endpoint -short -timeout 180m
--- PASS: TestAccEC2ClientVPNEndpoint_serial (4.87s)
    --- SKIP: TestAccEC2ClientVPNEndpoint_serial/Endpoint_msADAuth (0.00s)
    --- SKIP: TestAccEC2ClientVPNEndpoint_serial/Endpoint_msADAuthAndMutualAuth (0.00s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_disappears (19.89s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_basic (22.04s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_basicDataSource (23.46s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint (55.74s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_tags (68.88s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_withClientLoginBanner (71.68s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_withLogGroup (78.56s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuthWithSelfService (99.72s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_selfServicePortal (104.58s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_withDNSServers (105.93s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_simpleAttributesUpdate (109.37s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_withClientConnect (118.74s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/Endpoint_federatedAuth (120.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	126.626s

[github-actions]

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.