Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rd/ami - add boot_mode and outpost_arn #22939

Merged
merged 4 commits into from
Feb 4, 2022
Merged

rd/ami - add boot_mode and outpost_arn #22939

merged 4 commits into from
Feb 4, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Feb 4, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22930

Output from acceptance testing:

$ make testacc TESTS=TestAccEC2AMI_ PKG=ec2

--- PASS: TestAccEC2AMI_disappears (74.03s)
--- PASS: TestAccEC2AMI_basic (79.42s)
--- PASS: TestAccEC2AMI_ephemeralBlockDevices (79.51s)
--- PASS: TestAccEC2AMI_boot (79.51s)
--- PASS: TestAccEC2AMI_gp3BlockDevice (79.98s)
--- PASS: TestAccEC2AMI_description (115.29s)
--- PASS: TestAccEC2AMI_tags (149.96s)

$ make testacc TESTS=TestAccEC2AMIDataSource_ PKG=ec2

--- PASS: TestAccEC2AMIDataSource_instanceStore (34.30s)
--- PASS: TestAccEC2AMIDataSource_natInstance (35.24s)
--- PASS: TestAccEC2AMIDataSource_windowsInstance (38.25s)
--- PASS: TestAccEC2AMIDataSource_localNameFilter (45.97s)
--- PASS: TestAccEC2AMIDataSource_gp3BlockDevice (81.71s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Feb 4, 2022
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 4, 2022
ewbankkit
ewbankkit approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccEC2AMI_\|TestAccEC2AMIDataSource_' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2AMI_\|TestAccEC2AMIDataSource_ -timeout 180m
=== RUN   TestAccEC2AMIDataSource_natInstance
=== PAUSE TestAccEC2AMIDataSource_natInstance
=== RUN   TestAccEC2AMIDataSource_windowsInstance
=== PAUSE TestAccEC2AMIDataSource_windowsInstance
=== RUN   TestAccEC2AMIDataSource_instanceStore
=== PAUSE TestAccEC2AMIDataSource_instanceStore
=== RUN   TestAccEC2AMIDataSource_localNameFilter
=== PAUSE TestAccEC2AMIDataSource_localNameFilter
=== RUN   TestAccEC2AMIDataSource_gp3BlockDevice
=== PAUSE TestAccEC2AMIDataSource_gp3BlockDevice
=== RUN   TestAccEC2AMI_basic
=== PAUSE TestAccEC2AMI_basic
=== RUN   TestAccEC2AMI_description
=== PAUSE TestAccEC2AMI_description
=== RUN   TestAccEC2AMI_disappears
=== PAUSE TestAccEC2AMI_disappears
=== RUN   TestAccEC2AMI_ephemeralBlockDevices
=== PAUSE TestAccEC2AMI_ephemeralBlockDevices
=== RUN   TestAccEC2AMI_gp3BlockDevice
=== PAUSE TestAccEC2AMI_gp3BlockDevice
=== RUN   TestAccEC2AMI_tags
=== PAUSE TestAccEC2AMI_tags
=== RUN   TestAccEC2AMI_outpost
=== PAUSE TestAccEC2AMI_outpost
=== RUN   TestAccEC2AMI_boot
=== PAUSE TestAccEC2AMI_boot
=== CONT  TestAccEC2AMIDataSource_natInstance
=== CONT  TestAccEC2AMI_disappears
=== CONT  TestAccEC2AMI_outpost
=== CONT  TestAccEC2AMIDataSource_instanceStore
=== CONT  TestAccEC2AMI_tags
=== CONT  TestAccEC2AMI_boot
=== CONT  TestAccEC2AMIDataSource_gp3BlockDevice
=== CONT  TestAccEC2AMI_description
=== CONT  TestAccEC2AMI_gp3BlockDevice
=== CONT  TestAccEC2AMI_basic
=== CONT  TestAccEC2AMI_ephemeralBlockDevices
=== CONT  TestAccEC2AMIDataSource_localNameFilter
=== CONT  TestAccEC2AMIDataSource_windowsInstance
=== CONT  TestAccEC2AMI_outpost
    acctest.go:1264: skipping since no Outposts found
--- SKIP: TestAccEC2AMI_outpost (2.06s)
--- PASS: TestAccEC2AMIDataSource_instanceStore (49.69s)
--- PASS: TestAccEC2AMIDataSource_natInstance (50.22s)
--- PASS: TestAccEC2AMIDataSource_windowsInstance (50.67s)
--- PASS: TestAccEC2AMIDataSource_localNameFilter (51.74s)
--- PASS: TestAccEC2AMI_disappears (78.90s)
--- PASS: TestAccEC2AMIDataSource_gp3BlockDevice (80.99s)
--- PASS: TestAccEC2AMI_gp3BlockDevice (84.27s)
--- PASS: TestAccEC2AMI_boot (85.10s)
--- PASS: TestAccEC2AMI_basic (85.27s)
--- PASS: TestAccEC2AMI_ephemeralBlockDevices (85.53s)
--- PASS: TestAccEC2AMI_description (105.17s)
--- PASS: TestAccEC2AMI_tags (130.60s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	139.032s
GovCloud
% make testacc TESTARGS='-run=TestAccEC2AMI_\|TestAccEC2AMIDataSource_' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2AMI_\|TestAccEC2AMIDataSource_ -timeout 180m
=== RUN   TestAccEC2AMIDataSource_natInstance
=== PAUSE TestAccEC2AMIDataSource_natInstance
=== RUN   TestAccEC2AMIDataSource_windowsInstance
=== PAUSE TestAccEC2AMIDataSource_windowsInstance
=== RUN   TestAccEC2AMIDataSource_instanceStore
=== PAUSE TestAccEC2AMIDataSource_instanceStore
=== RUN   TestAccEC2AMIDataSource_localNameFilter
=== PAUSE TestAccEC2AMIDataSource_localNameFilter
=== RUN   TestAccEC2AMIDataSource_gp3BlockDevice
=== PAUSE TestAccEC2AMIDataSource_gp3BlockDevice
=== RUN   TestAccEC2AMI_basic
=== PAUSE TestAccEC2AMI_basic
=== RUN   TestAccEC2AMI_description
=== PAUSE TestAccEC2AMI_description
=== RUN   TestAccEC2AMI_disappears
=== PAUSE TestAccEC2AMI_disappears
=== RUN   TestAccEC2AMI_ephemeralBlockDevices
=== PAUSE TestAccEC2AMI_ephemeralBlockDevices
=== RUN   TestAccEC2AMI_gp3BlockDevice
=== PAUSE TestAccEC2AMI_gp3BlockDevice
=== RUN   TestAccEC2AMI_tags
=== PAUSE TestAccEC2AMI_tags
=== RUN   TestAccEC2AMI_outpost
=== PAUSE TestAccEC2AMI_outpost
=== RUN   TestAccEC2AMI_boot
=== PAUSE TestAccEC2AMI_boot
=== CONT  TestAccEC2AMIDataSource_natInstance
=== CONT  TestAccEC2AMI_disappears
=== CONT  TestAccEC2AMIDataSource_gp3BlockDevice
=== CONT  TestAccEC2AMI_description
=== CONT  TestAccEC2AMIDataSource_windowsInstance
=== CONT  TestAccEC2AMI_boot
=== CONT  TestAccEC2AMI_outpost
=== CONT  TestAccEC2AMI_tags
=== CONT  TestAccEC2AMI_gp3BlockDevice
=== CONT  TestAccEC2AMI_ephemeralBlockDevices
=== CONT  TestAccEC2AMI_basic
=== CONT  TestAccEC2AMIDataSource_instanceStore
=== CONT  TestAccEC2AMIDataSource_localNameFilter
=== CONT  TestAccEC2AMI_outpost
    acctest.go:1264: skipping since no Outposts found
--- SKIP: TestAccEC2AMI_outpost (2.40s)
--- PASS: TestAccEC2AMIDataSource_instanceStore (30.06s)
--- PASS: TestAccEC2AMIDataSource_natInstance (30.13s)
--- PASS: TestAccEC2AMIDataSource_windowsInstance (30.75s)
--- PASS: TestAccEC2AMIDataSource_localNameFilter (32.39s)
--- PASS: TestAccEC2AMIDataSource_gp3BlockDevice (59.64s)
--- PASS: TestAccEC2AMI_ephemeralBlockDevices (61.94s)
--- PASS: TestAccEC2AMI_disappears (75.09s)
--- PASS: TestAccEC2AMI_gp3BlockDevice (81.93s)
--- PASS: TestAccEC2AMI_boot (82.63s)
--- PASS: TestAccEC2AMI_basic (82.78s)
--- PASS: TestAccEC2AMI_description (104.53s)
--- PASS: TestAccEC2AMI_tags (109.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	115.571s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 1cac125 into hashicorp:main Feb 4, 2022
@github-actions github-actions bot added this to the v4.0.0 milestone Feb 4, 2022
This was referenced Feb 6, 2022
Closed
Merged
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@DrFaust92 DrFaust92 deleted the ami_boot branch February 12, 2022 12:46
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

resource aws_ami should support uefi boot mode setting
2 participants
@DrFaust92 @ewbankkit