Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elbv2: Don't allow invalid configurations #22996

Merged
merged 6 commits into from
Feb 7, 2022
Merged

elbv2: Don't allow invalid configurations #22996

merged 6 commits into from
Feb 7, 2022

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Feb 7, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15612

Output from acceptance testing (us-west-2):

% make testacc TESTS=TestAccELBV2TargetGroup_ PKG=elbv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2TargetGroup_'  -timeout 180m
--- PASS: TestAccELBV2TargetGroup_HealthCheck_without (31.79s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_lambda (35.27s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_missingPortProtocolVPC (36.26s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_basic (40.73s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_generatedName (40.77s)
--- PASS: TestAccELBV2TargetGroup_backwardsCompatibility (40.81s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_namePrefix (43.18s)
--- PASS: TestAccELBV2TargetGroup_Geneve_basic (47.38s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changeVPCForceNew (61.20s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateHealthCheck (62.69s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_lambdaMultiValueHeadersEnabled (65.91s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changePortForceNew (66.59s)
--- PASS: TestAccELBV2TargetGroup_HealthCheck_update (69.48s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changeProtocolForceNew (69.98s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_defaultALB (29.25s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changeNameForceNew (73.93s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingAlgorithmType (88.48s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_updateEnabled (93.10s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_invalidNLB (59.02s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateStickinessEnabled (95.77s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_validALB (60.50s)
--- PASS: TestAccELBV2TargetGroup_tags (95.78s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_updateAppEnabled (97.24s)
--- PASS: TestAccELBV2TargetGroup_Name_generated (40.57s)
--- PASS: TestAccELBV2TargetGroup_Geneve_notSticky (68.40s)
--- PASS: TestAccELBV2TargetGroup_Name_prefix (41.76s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_invalidALB (71.56s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_setAndUpdateSlowStart (65.24s)
--- PASS: TestAccELBV2TargetGroup_HealthCheck_enable (56.96s)
--- PASS: TestAccELBV2TargetGroup_preserveClientIPValid (74.37s)
--- PASS: TestAccELBV2TargetGroup_NetworkLB_targetGroupWithProxy (77.70s)
--- PASS: TestAccELBV2TargetGroup_ForceNew_protocol (82.75s)
--- PASS: TestAccELBV2TargetGroup_networkLB_TargetGroupWithConnectionTermination (77.81s)
--- PASS: TestAccELBV2TargetGroup_udp (52.17s)
--- PASS: TestAccELBV2TargetGroup_basic (52.47s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_defaultNLB (107.78s)
--- PASS: TestAccELBV2TargetGroup_Defaults_network (61.73s)
--- PASS: TestAccELBV2TargetGroup_tls (46.73s)
--- PASS: TestAccELBV2TargetGroup_Defaults_application (48.66s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_validNLB (140.08s)
--- PASS: TestAccELBV2TargetGroup_ProtocolVersion_basic (44.07s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_tags (82.32s)
--- PASS: TestAccELBV2TargetGroup_ForceNew_vpc (81.87s)
--- PASS: TestAccELBV2TargetGroup_HealthCheck_tcpHTTPS (85.61s)
--- PASS: TestAccELBV2TargetGroup_attrsOnCreate (84.94s)
--- PASS: TestAccELBV2TargetGroup_ProtocolVersion_grpcHealthCheck (39.32s)
--- PASS: TestAccELBV2TargetGroup_ForceNew_port (79.02s)
--- PASS: TestAccELBV2TargetGroup_NetworkLB_targetGroup (121.83s)
--- PASS: TestAccELBV2TargetGroup_ProtocolVersion_grpcUpdate (83.24s)
--- PASS: TestAccELBV2TargetGroup_ForceNew_name (82.41s)
--- PASS: TestAccELBV2TargetGroup_HealthCheck_tcp (67.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	205.872s

Output from acceptance testing (GovCloud):

% make testacc TESTS=TestAccELBV2TargetGroup_ PKG=elbv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2TargetGroup_'  -timeout 180m
--- PASS: TestAccELBV2TargetGroup_HealthCheck_without (43.20s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_lambda (49.38s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_namePrefix (58.95s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_missingPortProtocolVPC (60.63s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_generatedName (62.74s)
--- PASS: TestAccELBV2TargetGroup_backwardsCompatibility (62.99s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_basic (63.11s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateHealthCheck (89.20s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changePortForceNew (89.35s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changeNameForceNew (91.12s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changeVPCForceNew (92.70s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_tags (94.44s)
--- PASS: TestAccELBV2TargetGroup_HealthCheck_update (94.92s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_setAndUpdateSlowStart (95.22s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changeProtocolForceNew (99.61s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_lambdaMultiValueHeadersEnabled (104.49s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_updateEnabled (115.83s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingAlgorithmType (117.71s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateStickinessEnabled (117.97s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_defaultNLB (119.77s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_defaultALB (31.77s)
--- PASS: TestAccELBV2TargetGroup_ForceNew_vpc (62.30s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_validALB (66.79s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_invalidNLB (65.03s)
--- PASS: TestAccELBV2TargetGroup_Name_prefix (29.82s)
--- PASS: TestAccELBV2TargetGroup_Geneve_basic (39.97s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_invalidALB (72.90s)
--- PASS: TestAccELBV2TargetGroup_Name_generated (32.58s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_updateAppEnabled (98.42s)
--- PASS: TestAccELBV2TargetGroup_tags (94.93s)
--- PASS: TestAccELBV2TargetGroup_Defaults_application (31.56s)
--- PASS: TestAccELBV2TargetGroup_Geneve_notSticky (61.53s)
--- PASS: TestAccELBV2TargetGroup_preserveClientIPValid (61.81s)
--- PASS: TestAccELBV2TargetGroup_networkLB_TargetGroupWithConnectionTermination (59.81s)
--- PASS: TestAccELBV2TargetGroup_NetworkLB_targetGroupWithProxy (60.40s)
--- PASS: TestAccELBV2TargetGroup_Defaults_network (40.14s)
--- PASS: TestAccELBV2TargetGroup_HealthCheck_enable (42.10s)
--- PASS: TestAccELBV2TargetGroup_udp (30.45s)
--- PASS: TestAccELBV2TargetGroup_basic (31.51s)
--- PASS: TestAccELBV2TargetGroup_tls (28.73s)
--- PASS: TestAccELBV2TargetGroup_ProtocolVersion_grpcHealthCheck (28.13s)
--- PASS: TestAccELBV2TargetGroup_attrsOnCreate (54.02s)
--- PASS: TestAccELBV2TargetGroup_ProtocolVersion_basic (27.32s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_validNLB (118.59s)
--- PASS: TestAccELBV2TargetGroup_ForceNew_port (52.18s)
--- PASS: TestAccELBV2TargetGroup_ForceNew_protocol (58.98s)
--- PASS: TestAccELBV2TargetGroup_HealthCheck_tcp (52.18s)
--- PASS: TestAccELBV2TargetGroup_NetworkLB_targetGroup (88.07s)
--- PASS: TestAccELBV2TargetGroup_ForceNew_name (56.26s)
--- PASS: TestAccELBV2TargetGroup_HealthCheck_tcpHTTPS (49.61s)
--- PASS: TestAccELBV2TargetGroup_ProtocolVersion_grpcUpdate (52.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	198.872s

@github-actions github-actions bot added service/elbv2 Issues and PRs that pertain to the elbv2 service. size/M Managed by automation to categorize the size of a PR. labels Feb 7, 2022
@YakDriver YakDriver added this to the v4.0.0 milestone Feb 7, 2022
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Feb 7, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Feb 7, 2022
ewbankkit
ewbankkit approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccELBV2TargetGroup_ PKG=elbv2 ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 5 -run='TestAccELBV2TargetGroup_'  -timeout 180m
=== RUN   TestAccELBV2TargetGroup_backwardsCompatibility
=== PAUSE TestAccELBV2TargetGroup_backwardsCompatibility
=== RUN   TestAccELBV2TargetGroup_ProtocolVersion_basic
=== PAUSE TestAccELBV2TargetGroup_ProtocolVersion_basic
=== RUN   TestAccELBV2TargetGroup_ProtocolVersion_grpcHealthCheck
=== PAUSE TestAccELBV2TargetGroup_ProtocolVersion_grpcHealthCheck
=== RUN   TestAccELBV2TargetGroup_ProtocolVersion_grpcUpdate
=== PAUSE TestAccELBV2TargetGroup_ProtocolVersion_grpcUpdate
=== RUN   TestAccELBV2TargetGroup_HealthCheck_tcp
=== PAUSE TestAccELBV2TargetGroup_HealthCheck_tcp
=== RUN   TestAccELBV2TargetGroup_tls
=== PAUSE TestAccELBV2TargetGroup_tls
=== RUN   TestAccELBV2TargetGroup_HealthCheck_tcpHTTPS
=== PAUSE TestAccELBV2TargetGroup_HealthCheck_tcpHTTPS
=== RUN   TestAccELBV2TargetGroup_attrsOnCreate
=== PAUSE TestAccELBV2TargetGroup_attrsOnCreate
=== RUN   TestAccELBV2TargetGroup_basic
=== PAUSE TestAccELBV2TargetGroup_basic
=== RUN   TestAccELBV2TargetGroup_udp
=== PAUSE TestAccELBV2TargetGroup_udp
=== RUN   TestAccELBV2TargetGroup_ForceNew_name
=== PAUSE TestAccELBV2TargetGroup_ForceNew_name
=== RUN   TestAccELBV2TargetGroup_ForceNew_port
=== PAUSE TestAccELBV2TargetGroup_ForceNew_port
=== RUN   TestAccELBV2TargetGroup_ForceNew_protocol
=== PAUSE TestAccELBV2TargetGroup_ForceNew_protocol
=== RUN   TestAccELBV2TargetGroup_ForceNew_vpc
=== PAUSE TestAccELBV2TargetGroup_ForceNew_vpc
=== RUN   TestAccELBV2TargetGroup_Defaults_application
=== PAUSE TestAccELBV2TargetGroup_Defaults_application
=== RUN   TestAccELBV2TargetGroup_Defaults_network
=== PAUSE TestAccELBV2TargetGroup_Defaults_network
=== RUN   TestAccELBV2TargetGroup_HealthCheck_enable
=== PAUSE TestAccELBV2TargetGroup_HealthCheck_enable
=== RUN   TestAccELBV2TargetGroup_Name_generated
=== PAUSE TestAccELBV2TargetGroup_Name_generated
=== RUN   TestAccELBV2TargetGroup_Name_prefix
=== PAUSE TestAccELBV2TargetGroup_Name_prefix
=== RUN   TestAccELBV2TargetGroup_NetworkLB_targetGroup
=== PAUSE TestAccELBV2TargetGroup_NetworkLB_targetGroup
=== RUN   TestAccELBV2TargetGroup_networkLB_TargetGroupWithConnectionTermination
=== PAUSE TestAccELBV2TargetGroup_networkLB_TargetGroupWithConnectionTermination
=== RUN   TestAccELBV2TargetGroup_NetworkLB_targetGroupWithProxy
=== PAUSE TestAccELBV2TargetGroup_NetworkLB_targetGroupWithProxy
=== RUN   TestAccELBV2TargetGroup_preserveClientIPValid
=== PAUSE TestAccELBV2TargetGroup_preserveClientIPValid
=== RUN   TestAccELBV2TargetGroup_Geneve_basic
=== PAUSE TestAccELBV2TargetGroup_Geneve_basic
=== RUN   TestAccELBV2TargetGroup_Geneve_notSticky
=== PAUSE TestAccELBV2TargetGroup_Geneve_notSticky
=== RUN   TestAccELBV2TargetGroup_Stickiness_defaultALB
=== PAUSE TestAccELBV2TargetGroup_Stickiness_defaultALB
=== RUN   TestAccELBV2TargetGroup_Stickiness_defaultNLB
=== PAUSE TestAccELBV2TargetGroup_Stickiness_defaultNLB
=== RUN   TestAccELBV2TargetGroup_Stickiness_invalidALB
=== PAUSE TestAccELBV2TargetGroup_Stickiness_invalidALB
=== RUN   TestAccELBV2TargetGroup_Stickiness_invalidNLB
=== PAUSE TestAccELBV2TargetGroup_Stickiness_invalidNLB
=== RUN   TestAccELBV2TargetGroup_Stickiness_validALB
=== PAUSE TestAccELBV2TargetGroup_Stickiness_validALB
=== RUN   TestAccELBV2TargetGroup_Stickiness_validNLB
=== PAUSE TestAccELBV2TargetGroup_Stickiness_validNLB
=== RUN   TestAccELBV2TargetGroup_tags
=== PAUSE TestAccELBV2TargetGroup_tags
=== RUN   TestAccELBV2TargetGroup_Stickiness_updateAppEnabled
=== PAUSE TestAccELBV2TargetGroup_Stickiness_updateAppEnabled
=== RUN   TestAccELBV2TargetGroup_HealthCheck_update
=== PAUSE TestAccELBV2TargetGroup_HealthCheck_update
=== RUN   TestAccELBV2TargetGroup_Stickiness_updateEnabled
=== PAUSE TestAccELBV2TargetGroup_Stickiness_updateEnabled
=== RUN   TestAccELBV2TargetGroup_HealthCheck_without
=== PAUSE TestAccELBV2TargetGroup_HealthCheck_without
=== RUN   TestAccELBV2TargetGroup_ALBAlias_basic
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_basic
=== RUN   TestAccELBV2TargetGroup_ALBAlias_changeNameForceNew
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_changeNameForceNew
=== RUN   TestAccELBV2TargetGroup_ALBAlias_changePortForceNew
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_changePortForceNew
=== RUN   TestAccELBV2TargetGroup_ALBAlias_changeProtocolForceNew
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_changeProtocolForceNew
=== RUN   TestAccELBV2TargetGroup_ALBAlias_changeVPCForceNew
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_changeVPCForceNew
=== RUN   TestAccELBV2TargetGroup_ALBAlias_generatedName
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_generatedName
=== RUN   TestAccELBV2TargetGroup_ALBAlias_lambda
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_lambda
=== RUN   TestAccELBV2TargetGroup_ALBAlias_lambdaMultiValueHeadersEnabled
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_lambdaMultiValueHeadersEnabled
=== RUN   TestAccELBV2TargetGroup_ALBAlias_missingPortProtocolVPC
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_missingPortProtocolVPC
=== RUN   TestAccELBV2TargetGroup_ALBAlias_namePrefix
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_namePrefix
=== RUN   TestAccELBV2TargetGroup_ALBAlias_setAndUpdateSlowStart
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_setAndUpdateSlowStart
=== RUN   TestAccELBV2TargetGroup_ALBAlias_tags
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_tags
=== RUN   TestAccELBV2TargetGroup_ALBAlias_updateHealthCheck
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_updateHealthCheck
=== RUN   TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingAlgorithmType
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingAlgorithmType
=== RUN   TestAccELBV2TargetGroup_ALBAlias_updateStickinessEnabled
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_updateStickinessEnabled
=== CONT  TestAccELBV2TargetGroup_ALBAlias_updateStickinessEnabled
=== CONT  TestAccELBV2TargetGroup_backwardsCompatibility
=== CONT  TestAccELBV2TargetGroup_Geneve_notSticky
=== CONT  TestAccELBV2TargetGroup_Geneve_basic
=== CONT  TestAccELBV2TargetGroup_preserveClientIPValid
--- PASS: TestAccELBV2TargetGroup_backwardsCompatibility (33.83s)
=== CONT  TestAccELBV2TargetGroup_NetworkLB_targetGroupWithProxy
--- PASS: TestAccELBV2TargetGroup_Geneve_basic (37.71s)
=== CONT  TestAccELBV2TargetGroup_networkLB_TargetGroupWithConnectionTermination
--- PASS: TestAccELBV2TargetGroup_preserveClientIPValid (58.13s)
=== CONT  TestAccELBV2TargetGroup_NetworkLB_targetGroup
--- PASS: TestAccELBV2TargetGroup_Geneve_notSticky (58.55s)
=== CONT  TestAccELBV2TargetGroup_Name_prefix
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateStickinessEnabled (85.52s)
=== CONT  TestAccELBV2TargetGroup_Name_generated
--- PASS: TestAccELBV2TargetGroup_NetworkLB_targetGroupWithProxy (57.94s)
=== CONT  TestAccELBV2TargetGroup_HealthCheck_enable
--- PASS: TestAccELBV2TargetGroup_Name_prefix (33.39s)
=== CONT  TestAccELBV2TargetGroup_Defaults_network
--- PASS: TestAccELBV2TargetGroup_networkLB_TargetGroupWithConnectionTermination (54.42s)
=== CONT  TestAccELBV2TargetGroup_Defaults_application
--- PASS: TestAccELBV2TargetGroup_Name_generated (28.89s)
=== CONT  TestAccELBV2TargetGroup_ForceNew_vpc
--- PASS: TestAccELBV2TargetGroup_Defaults_application (28.61s)
=== CONT  TestAccELBV2TargetGroup_ForceNew_protocol
--- PASS: TestAccELBV2TargetGroup_Defaults_network (35.64s)
=== CONT  TestAccELBV2TargetGroup_ForceNew_port
--- PASS: TestAccELBV2TargetGroup_HealthCheck_enable (36.79s)
=== CONT  TestAccELBV2TargetGroup_ForceNew_name
--- PASS: TestAccELBV2TargetGroup_NetworkLB_targetGroup (92.02s)
=== CONT  TestAccELBV2TargetGroup_udp
--- PASS: TestAccELBV2TargetGroup_ForceNew_vpc (49.75s)
=== CONT  TestAccELBV2TargetGroup_basic
--- PASS: TestAccELBV2TargetGroup_udp (27.53s)
=== CONT  TestAccELBV2TargetGroup_attrsOnCreate
--- PASS: TestAccELBV2TargetGroup_ForceNew_protocol (57.49s)
=== CONT  TestAccELBV2TargetGroup_HealthCheck_tcpHTTPS
--- PASS: TestAccELBV2TargetGroup_ForceNew_port (52.41s)
=== CONT  TestAccELBV2TargetGroup_tls
--- PASS: TestAccELBV2TargetGroup_ForceNew_name (58.46s)
=== CONT  TestAccELBV2TargetGroup_HealthCheck_tcp
--- PASS: TestAccELBV2TargetGroup_basic (29.67s)
=== CONT  TestAccELBV2TargetGroup_ProtocolVersion_grpcUpdate
--- PASS: TestAccELBV2TargetGroup_tls (29.29s)
=== CONT  TestAccELBV2TargetGroup_ProtocolVersion_grpcHealthCheck
--- PASS: TestAccELBV2TargetGroup_attrsOnCreate (53.79s)
=== CONT  TestAccELBV2TargetGroup_ProtocolVersion_basic
--- PASS: TestAccELBV2TargetGroup_HealthCheck_tcpHTTPS (53.27s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_changePortForceNew
--- PASS: TestAccELBV2TargetGroup_ProtocolVersion_grpcHealthCheck (28.20s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingAlgorithmType
--- PASS: TestAccELBV2TargetGroup_HealthCheck_tcp (52.84s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_updateHealthCheck
--- PASS: TestAccELBV2TargetGroup_ProtocolVersion_grpcUpdate (57.41s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_tags
--- PASS: TestAccELBV2TargetGroup_ProtocolVersion_basic (29.77s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_setAndUpdateSlowStart
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changePortForceNew (54.06s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_namePrefix
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateHealthCheck (52.82s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_missingPortProtocolVPC
--- PASS: TestAccELBV2TargetGroup_ALBAlias_tags (51.49s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_lambdaMultiValueHeadersEnabled
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingAlgorithmType (73.95s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_lambda
--- PASS: TestAccELBV2TargetGroup_ALBAlias_setAndUpdateSlowStart (55.44s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_generatedName
--- PASS: TestAccELBV2TargetGroup_ALBAlias_namePrefix (31.12s)
=== CONT  TestAccELBV2TargetGroup_Stickiness_defaultALB
--- PASS: TestAccELBV2TargetGroup_ALBAlias_missingPortProtocolVPC (31.13s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_changeNameForceNew
--- PASS: TestAccELBV2TargetGroup_ALBAlias_lambda (21.80s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_basic
--- PASS: TestAccELBV2TargetGroup_Stickiness_defaultALB (28.15s)
=== CONT  TestAccELBV2TargetGroup_HealthCheck_without
--- PASS: TestAccELBV2TargetGroup_ALBAlias_generatedName (28.31s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_changeVPCForceNew
--- PASS: TestAccELBV2TargetGroup_ALBAlias_basic (27.80s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_changeProtocolForceNew
--- PASS: TestAccELBV2TargetGroup_ALBAlias_lambdaMultiValueHeadersEnabled (58.34s)
=== CONT  TestAccELBV2TargetGroup_Stickiness_updateAppEnabled
--- PASS: TestAccELBV2TargetGroup_HealthCheck_without (18.65s)
=== CONT  TestAccELBV2TargetGroup_HealthCheck_update
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changeNameForceNew (57.62s)
=== CONT  TestAccELBV2TargetGroup_Stickiness_updateEnabled
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changeVPCForceNew (49.97s)
=== CONT  TestAccELBV2TargetGroup_Stickiness_invalidNLB
--- PASS: TestAccELBV2TargetGroup_HealthCheck_update (54.65s)
=== CONT  TestAccELBV2TargetGroup_Stickiness_invalidALB
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changeProtocolForceNew (59.74s)
=== CONT  TestAccELBV2TargetGroup_Stickiness_defaultNLB
--- PASS: TestAccELBV2TargetGroup_Stickiness_updateAppEnabled (80.14s)
=== CONT  TestAccELBV2TargetGroup_Stickiness_validALB
--- PASS: TestAccELBV2TargetGroup_Stickiness_invalidNLB (55.80s)
=== CONT  TestAccELBV2TargetGroup_Stickiness_validNLB
--- PASS: TestAccELBV2TargetGroup_Stickiness_updateEnabled (78.60s)
=== CONT  TestAccELBV2TargetGroup_tags
--- PASS: TestAccELBV2TargetGroup_Stickiness_invalidALB (63.28s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_validALB (59.04s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_defaultNLB (81.39s)
--- PASS: TestAccELBV2TargetGroup_tags (78.45s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_validNLB (107.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	561.610s

@YakDriver YakDriver merged commit a5e368a into main Feb 7, 2022
@YakDriver YakDriver deleted the td-lb-target-group-invalid branch February 7, 2022 19:38
github-actions bot pushed a commit that referenced this pull request Feb 7, 2022
Update CHANGELOG.md for #22996
200f1d3
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

r/lb_target_group: Don't allow invalid configurations
2 participants
@YakDriver @ewbankkit