Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecs: Fix ISO tagging #23030

Merged
merged 7 commits into from
Feb 8, 2022
Merged

ecs: Fix ISO tagging #23030

merged 7 commits into from
Feb 8, 2022

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Feb 8, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #22532

Output from acceptance testing:

% make testacc TESTS=TestAccECS PKG=ecs                      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECS'  -timeout 180m
--- PASS: TestAccECSAccountSettingDefault_containerInstanceLongARNFormat (26.42s)
--- PASS: TestAccECSTaskDefinition_arrays (26.95s)
--- PASS: TestAccECSTaskDefinition_inferenceAccelerator (27.08s)
--- PASS: TestAccECSTaskDefinition_Fargate_ephemeralStorage (27.66s)
--- PASS: TestAccECSTaskDefinition_constraint (28.16s)
--- PASS: TestAccECSTaskDefinition_networkMode (29.43s)
--- PASS: TestAccECSTaskDefinition_pidMode (30.25s)
--- PASS: TestAccECSTaskDefinition_ipcMode (30.36s)
--- PASS: TestAccECSTaskDefinition_executionRole (30.58s)
--- PASS: TestAccECSTaskDefinition_Fargate_basic (38.74s)
--- PASS: TestAccECSTaskDefinition_proxy (41.05s)
--- PASS: TestAccECSTaskDefinition_disappears (41.70s)
--- PASS: TestAccECSTaskDefinition_changeVolumesForcesNewResource (44.08s)
--- PASS: TestAccECSTaskDefinition_DockerVolume_taskScoped (24.34s)
--- PASS: TestAccECSTaskDefinition_taskRoleARN (25.78s)
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatformWithoutArch (22.73s)
--- PASS: TestAccECSTaskSet_disappears (58.47s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_transitEncryption (32.83s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_minimal (33.93s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_basic (34.49s)
--- PASS: TestAccECSTaskDefinition_EFSVolume_accessPoint (37.78s)
--- PASS: TestAccECSTaskDefinition_tags (70.52s)
--- PASS: TestAccECSTaskSet_withMultipleCapacityProviderStrategies (75.22s)
--- PASS: TestAccECSTaskSet_withExternalId (77.42s)
--- PASS: TestAccECSTaskSet_basic (87.83s)
--- PASS: TestAccECSService_iamRole (58.62s)
--- PASS: TestAccECSTaskSet_withScale (106.62s)
--- PASS: TestAccECSService_disappears (45.51s)
--- PASS: TestAccECSTaskDefinition_service (84.59s)
--- PASS: TestAccECSTaskDefinition_Fargate_runtimePlatform (17.78s)
--- PASS: TestAccECSTaskDefinition_runtimePlatform (17.15s)
--- PASS: TestAccECSTaskDefinition_DockerVolume_minimal (17.50s)
--- PASS: TestAccECSService_renamedCluster (90.00s)
--- PASS: TestAccECSService_familyAndRevision (90.05s)
--- PASS: TestAccECSCluster_configuration (58.97s)
--- PASS: TestAccECSService_PlacementStrategy_unnormalized (76.62s)
--- PASS: TestAccECSTaskSet_withCapacityProviderStrategy (140.01s)
--- PASS: TestAccECSService_basic (75.23s)
--- PASS: TestAccECSTaskDefinition_DockerVolume_basic (17.04s)
--- PASS: TestAccECSService_basicImport (81.01s)
--- PASS: TestAccECSTaskDefinition_scratchVolume (18.13s)
--- PASS: TestAccECSTaskDefinitionDataSource_ecsTaskDefinition (19.27s)
--- PASS: TestAccECSCluster_containerInsights (73.56s)
--- PASS: TestAccECSServiceDataSource_basic (92.44s)
--- PASS: TestAccECSCluster_disappears (25.09s)
--- PASS: TestAccECSService_CapacityProviderStrategy_multiple (113.54s)
--- PASS: TestAccECSContainerDefinitionDataSource_ecsContainerDefinition (91.73s)
--- PASS: TestAccECSCluster_capacityProviders (40.54s)
--- PASS: TestAccECSTaskDefinition_basic (33.13s)
--- PASS: TestAccECSCluster_capacityProvidersNoStrategy (55.06s)
--- PASS: TestAccECSService_CapacityProviderStrategy_forceNewDeployment (134.59s)
--- PASS: TestAccECSTag_disappears (28.50s)
--- PASS: TestAccECSTag_value (45.77s)
--- PASS: TestAccECSClusterDataSource_ecsClusterContainerInsights (27.84s)
--- PASS: TestAccECSTag_basic (31.48s)
--- PASS: TestAccECSCluster_tags (56.87s)
--- PASS: TestAccECSClusterDataSource_ecsCluster (28.35s)
--- PASS: TestAccECSCluster_basic (30.69s)
--- PASS: TestAccECSCluster_capacityProvidersUpdate (79.23s)
--- PASS: TestAccECSAccountSettingDefault_containerInsights (19.69s)
--- PASS: TestAccECSTag_ResourceARN_batchComputeEnvironment (53.29s)
--- PASS: TestAccECSCluster_singleCapacityProvider (94.20s)
--- PASS: TestAccECSClusterCapacityProviders_defaults (51.85s)
--- PASS: TestAccECSService_CapacityProviderStrategy_basic (192.13s)
--- PASS: TestAccECSCapacityProvider_basic (65.50s)
--- PASS: TestAccECSAccountSettingDefault_awsvpcTrunking (16.50s)
--- PASS: TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum (46.14s)
--- PASS: TestAccECSAccountSettingDefault_taskLongARNFormat (17.55s)
--- PASS: TestAccECSService_executeCommand (94.50s)
--- PASS: TestAccECSService_DaemonSchedulingStrategy_basic (44.05s)
--- PASS: TestAccECSAccountSettingDefault_serviceLongARNFormat (17.96s)
--- PASS: TestAccECSService_Tags_managed (92.58s)
--- PASS: TestAccECSService_Tags_basic (106.57s)
--- PASS: TestAccECSClusterCapacityProviders_Update_defaultStrategy (133.39s)
--- PASS: TestAccECSService_replicaSchedulingStrategy (91.40s)
--- PASS: TestAccECSClusterCapacityProviders_Update_capacityProviders (132.98s)
--- PASS: TestAccECSService_LaunchTypeFargate_waitForSteadyState (178.53s)
--- PASS: TestAccECSService_PlacementStrategy_missing (0.82s)
--- PASS: TestAccECSClusterCapacityProviders_disappears (37.26s)
--- PASS: TestAccECSService_LaunchTypeFargate_basic (772.93s)
--- PASS: TestAccECSService_LaunchTypeEC2_network (72.42s)
--- PASS: TestAccECSCapacityProvider_disappears (63.69s)
--- PASS: TestAccECSService_healthCheckGracePeriodSeconds (294.65s)
--- PASS: TestAccECSClusterCapacityProviders_basic (51.42s)
--- PASS: TestAccECSTaskSet_Tags (86.03s)
--- PASS: TestAccECSService_DeploymentControllerType_codeDeploy (263.38s)
--- PASS: TestAccECSService_CapacityProviderStrategy_update (317.99s)
--- PASS: TestAccECSTaskSet_withLaunchTypeFargateAndPlatformVersion (102.57s)
--- PASS: TestAccECSService_ServiceRegistries_basic (172.05s)
--- PASS: TestAccECSService_ServiceRegistries_container (187.42s)
--- PASS: TestAccECSService_PlacementConstraints_basic (77.39s)
--- PASS: TestAccECSCapacityProvider_managedScalingPartial (64.99s)
--- PASS: TestAccECSService_PlacementConstraints_emptyExpression (91.27s)
--- PASS: TestAccECSService_Tags_propagate (217.17s)
--- PASS: TestAccECSCapacityProvider_tags (102.85s)
--- PASS: TestAccECSClusterCapacityProviders_destroy (237.65s)
--- PASS: TestAccECSService_forceNewDeployment (73.18s)
--- PASS: TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod (423.03s)
--- PASS: TestAccECSCapacityProvider_managedScaling (136.36s)
--- PASS: TestAccECSService_DeploymentControllerType_external (62.52s)
--- PASS: TestAccECSService_deploymentCircuitBreaker (75.19s)
--- PASS: TestAccECSTaskSet_withLaunchTypeFargate (78.79s)
--- PASS: TestAccECSService_clusterName (90.63s)
--- PASS: TestAccECSService_loadBalancerChanges (130.64s)
--- PASS: TestAccECSService_DeploymentValues_minZeroMaxOneHundred (75.49s)
--- PASS: TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState (219.50s)
--- PASS: TestAccECSTaskSet_withServiceRegistries (150.90s)
--- PASS: TestAccECSService_DeploymentValues_basic (75.98s)
--- PASS: TestAccECSService_PlacementStrategy_basic (115.73s)
--- PASS: TestAccECSService_LaunchTypeFargate_platformVersion (187.99s)
--- PASS: TestAccECSService_ServiceRegistries_changes (325.93s)
--- PASS: TestAccECSService_multipleTargetGroups (229.45s)
--- PASS: TestAccECSTaskSet_withAlb (202.83s)
--- PASS: TestAccECSService_alb (244.27s)
--- PASS: TestAccECSTaskDefinition_fsxWinFileSystem (3476.01s)	
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	3504.934s

@github-actions github-actions bot added service/ecs Issues and PRs that pertain to the ecs service. size/XS Managed by automation to categorize the size of a PR. labels Feb 8, 2022
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Feb 8, 2022
@YakDriver YakDriver added partition/aws-iso Pertains to the aws-iso partition. partition/aws-iso-b Pertains to the aws-iso-b partition. labels Feb 8, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@YakDriver YakDriver merged commit 16398e6 into main Feb 8, 2022
@YakDriver YakDriver deleted the b-iso-tagging-ecs-eb branch February 8, 2022 20:20
@github-actions github-actions bot added this to the v4.0.0 milestone Feb 8, 2022
@YakDriver YakDriver mentioned this pull request Feb 8, 2022
27 tasks
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
partition/aws-iso Pertains to the aws-iso partition. partition/aws-iso-b Pertains to the aws-iso-b partition. service/ecs Issues and PRs that pertain to the ecs service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants