Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging support for AMP workspaces #23172

Closed
mhausenblas opened this issue Feb 14, 2022 · 5 comments · Fixed by #23202
Closed

Tagging support for AMP workspaces #23172

mhausenblas opened this issue Feb 14, 2022 · 5 comments · Fixed by #23202
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/amp Issues and PRs that pertain to the amp service.
Milestone

Comments

@mhausenblas
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Support tagging AMP workspaces.

New or Affected Resource(s)

  • aws_prometheus_workspace

Potential Terraform Configuration

resource "aws_prometheus_workspace" "tf-tag" {
  alias = "tf-tag"

  tags = {
    Environment = "prod"
    Owner = "mh9"
  }
}
@mhausenblas mhausenblas added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 14, 2022
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 14, 2022
@mhausenblas
Copy link
Contributor Author

FYI: I'm working on this ATM so feel free to assign to me.

@ewbankkit ewbankkit added the service/amp Issues and PRs that pertain to the amp service. label Feb 14, 2022
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Feb 14, 2022
@github-actions github-actions bot added this to the v4.1.0 milestone Feb 15, 2022
@mhausenblas
Copy link
Contributor Author

@ewbankkit thank you so much! Can you please advise when this feature will be available (IOW: when is the next release planned that includes the tagging support)?

@ewbankkit
Copy link
Contributor

@mhausenblas We are intending to release v4.1.0, including this enhancement, later today.

@github-actions
Copy link

This functionality has been released in v4.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/amp Issues and PRs that pertain to the amp service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants