Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/elasticache_replication_group: prevent empty strings in resource description #23254

Merged
merged 2 commits into from
Feb 18, 2022
Merged

r/elasticache_replication_group: prevent empty strings in resource description #23254

merged 2 commits into from
Feb 18, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Feb 17, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23220

Output from acceptance testing:

@github-actions github-actions bot added service/elasticache Issues and PRs that pertain to the elasticache service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Feb 17, 2022
@anGie44 anGie44 force-pushed the b-elasticache-replication-group-description branch 2 times, most recently from 23a26b8 to cbf15ae Compare February 17, 2022 21:10
@anGie44 anGie44 force-pushed the b-elasticache-replication-group-description branch from 2ae6b3a to f85b75f Compare February 17, 2022 21:18
@anGie44 anGie44 force-pushed the b-elasticache-replication-group-description branch from f85b75f to 4be507f Compare February 17, 2022 21:35
@anGie44 anGie44 force-pushed the b-elasticache-replication-group-description branch from 4be507f to 66b8deb Compare February 17, 2022 21:37
anGie44 added a commit that referenced this pull request Feb 17, 2022
@anGie44
Update CHANGELOG for #23254
120198b
@anGie44 anGie44 force-pushed the b-elasticache-replication-group-description branch from 66b8deb to 120198b Compare February 17, 2022 21:38
@anGie44 anGie44 force-pushed the b-elasticache-replication-group-description branch from 120198b to 274b923 Compare February 17, 2022 22:27
@anGie44 anGie44 marked this pull request as ready for review February 17, 2022 22:51
@anGie44 anGie44 force-pushed the b-elasticache-replication-group-description branch from 274b923 to d06c40e Compare February 17, 2022 22:56
@anGie44 anGie44 marked this pull request as draft February 17, 2022 22:57
@anGie44 anGie44 force-pushed the b-elasticache-replication-group-description branch from d06c40e to bc8b3b1 Compare February 17, 2022 23:04
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. size/S Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Feb 17, 2022
@anGie44 anGie44 force-pushed the b-elasticache-replication-group-description branch from bc8b3b1 to b2df803 Compare February 17, 2022 23:05
@anGie44 anGie44 force-pushed the b-elasticache-replication-group-description branch from b2df803 to 1f1781c Compare February 17, 2022 23:07
@github-actions github-actions bot removed the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Feb 17, 2022
@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Feb 17, 2022
anGie44 added a commit that referenced this pull request Feb 17, 2022
@anGie44
Update CHANGELOG for #23254
3a0b078
@anGie44 anGie44 force-pushed the b-elasticache-replication-group-description branch from 1f1781c to 3a0b078 Compare February 17, 2022 23:09
@anGie44 anGie44 marked this pull request as ready for review February 17, 2022 23:10
@anGie44 anGie44 added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 17, 2022
@anGie44 anGie44 requested a review from gdavison February 17, 2022 23:48
@anGie44
Copy link
Contributor Author

anGie44 commented Feb 17, 2022 •
edited
Loading

@gdavison in v4 , one of the descriptions is required but we don't enforce non-empty strings. i've done so here but am not sure if that is technically correct when the API technically accepts an empty string 🤔 what's your thought on the linked issue?

@anGie44 anGie44 changed the title r/elasticache_replication_group: update ReplicationGroupDescription handling when not configured r/elasticache_replication_group: prevent empty strings in resource description Feb 17, 2022
@YakDriver YakDriver self-assigned this Feb 18, 2022
YakDriver
YakDriver approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MPB! 🎉

but, whitespaces...

@anGie44 anGie44 force-pushed the b-elasticache-replication-group-description branch from 3a0b078 to b00d810 Compare February 18, 2022 19:12
@anGie44 anGie44 added this to the v4.2.0 milestone Feb 18, 2022
@anGie44 anGie44 merged commit 70bed14 into main Feb 18, 2022
@anGie44 anGie44 deleted the b-elasticache-replication-group-description branch February 18, 2022 22:44
github-actions bot pushed a commit that referenced this pull request Feb 18, 2022
Update CHANGELOG.md for #23254
681d40d
@github-actions
Copy link

This functionality has been released in v4.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

@gdavison gdavison Awaiting requested review from gdavison

Assignees

@YakDriver YakDriver

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.2.0
Development

Successfully merging this pull request may close these issues.

aws_elasticache_replication_group description and replication_group_description
2 participants
@anGie44 @YakDriver