Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/servicecatalog_provisioned_product: Add outputs attribute #23270

Merged
merged 2 commits into from
Feb 23, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Feb 18, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes Asana #64503

Output from acceptance testing:

--- PASS: TestAccServiceCatalogProvisionedProduct_basic (145.15s)
--- PASS: TestAccServiceCatalogProvisionedProduct_disappears (136.82s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags (244.40s)

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 18, 2022
@anGie44 anGie44 added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 18, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccServiceCatalogProvisionedProduct_ PKG=servicecatalog
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicecatalog/... -v -count 1 -parallel 20 -run='TestAccServiceCatalogProvisionedProduct_'  -timeout 180m
=== RUN   TestAccServiceCatalogProvisionedProduct_basic
=== PAUSE TestAccServiceCatalogProvisionedProduct_basic
=== RUN   TestAccServiceCatalogProvisionedProduct_disappears
=== PAUSE TestAccServiceCatalogProvisionedProduct_disappears
=== RUN   TestAccServiceCatalogProvisionedProduct_tags
=== PAUSE TestAccServiceCatalogProvisionedProduct_tags
=== CONT  TestAccServiceCatalogProvisionedProduct_basic
=== CONT  TestAccServiceCatalogProvisionedProduct_tags
=== CONT  TestAccServiceCatalogProvisionedProduct_disappears
--- PASS: TestAccServiceCatalogProvisionedProduct_disappears (138.18s)
--- PASS: TestAccServiceCatalogProvisionedProduct_basic (149.35s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags (247.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog	251.823s

@anGie44 anGie44 added this to the v4.3.0 milestone Feb 23, 2022
@anGie44 anGie44 merged commit 2c360a8 into main Feb 23, 2022
@anGie44 anGie44 deleted the f-service-catalog-pp-outputs branch February 23, 2022 20:13
github-actions bot pushed a commit that referenced this pull request Feb 23, 2022
@github-actions
Copy link

github-actions bot commented Mar 1, 2022

This functionality has been released in v4.3.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants