-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix when change ebs_volume type preserve iops #23280
fix when change ebs_volume type preserve iops #23280
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @leonardobiffi 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEC2EBSVolume_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccEC2EBSVolume_ -timeout 180m
=== RUN TestAccEC2EBSVolume_basic
=== PAUSE TestAccEC2EBSVolume_basic
=== RUN TestAccEC2EBSVolume_disappears
=== PAUSE TestAccEC2EBSVolume_disappears
=== RUN TestAccEC2EBSVolume_updateAttachedEBSVolume
=== PAUSE TestAccEC2EBSVolume_updateAttachedEBSVolume
=== RUN TestAccEC2EBSVolume_updateSize
=== PAUSE TestAccEC2EBSVolume_updateSize
=== RUN TestAccEC2EBSVolume_updateType
=== PAUSE TestAccEC2EBSVolume_updateType
=== RUN TestAccEC2EBSVolume_UpdateIops_io1
=== PAUSE TestAccEC2EBSVolume_UpdateIops_io1
=== RUN TestAccEC2EBSVolume_UpdateIops_io2
=== PAUSE TestAccEC2EBSVolume_UpdateIops_io2
=== RUN TestAccEC2EBSVolume_kmsKey
=== PAUSE TestAccEC2EBSVolume_kmsKey
=== RUN TestAccEC2EBSVolume_noIops
=== PAUSE TestAccEC2EBSVolume_noIops
=== RUN TestAccEC2EBSVolume_invalidIopsForType
=== PAUSE TestAccEC2EBSVolume_invalidIopsForType
=== RUN TestAccEC2EBSVolume_invalidThroughputForType
=== PAUSE TestAccEC2EBSVolume_invalidThroughputForType
=== RUN TestAccEC2EBSVolume_withTags
=== PAUSE TestAccEC2EBSVolume_withTags
=== RUN TestAccEC2EBSVolume_multiAttach_io1
=== PAUSE TestAccEC2EBSVolume_multiAttach_io1
=== RUN TestAccEC2EBSVolume_multiAttach_io2
=== PAUSE TestAccEC2EBSVolume_multiAttach_io2
=== RUN TestAccEC2EBSVolume_multiAttach_gp2
=== PAUSE TestAccEC2EBSVolume_multiAttach_gp2
=== RUN TestAccEC2EBSVolume_outpost
=== PAUSE TestAccEC2EBSVolume_outpost
=== RUN TestAccEC2EBSVolume_GP3_basic
=== PAUSE TestAccEC2EBSVolume_GP3_basic
=== RUN TestAccEC2EBSVolume_GP3_iops
=== PAUSE TestAccEC2EBSVolume_GP3_iops
=== RUN TestAccEC2EBSVolume_GP3_throughput
=== PAUSE TestAccEC2EBSVolume_GP3_throughput
=== RUN TestAccEC2EBSVolume_gp3ToGP2
=== PAUSE TestAccEC2EBSVolume_gp3ToGP2
=== RUN TestAccEC2EBSVolume_io1ToGP3
=== PAUSE TestAccEC2EBSVolume_io1ToGP3
=== RUN TestAccEC2EBSVolume_snapshotID
=== PAUSE TestAccEC2EBSVolume_snapshotID
=== RUN TestAccEC2EBSVolume_snapshotIDAndSize
=== PAUSE TestAccEC2EBSVolume_snapshotIDAndSize
=== CONT TestAccEC2EBSVolume_basic
=== CONT TestAccEC2EBSVolume_multiAttach_io1
--- PASS: TestAccEC2EBSVolume_basic (51.29s)
=== CONT TestAccEC2EBSVolume_UpdateIops_io2
--- PASS: TestAccEC2EBSVolume_multiAttach_io1 (51.85s)
=== CONT TestAccEC2EBSVolume_withTags
--- PASS: TestAccEC2EBSVolume_UpdateIops_io2 (77.48s)
=== CONT TestAccEC2EBSVolume_invalidThroughputForType
--- PASS: TestAccEC2EBSVolume_invalidThroughputForType (4.14s)
=== CONT TestAccEC2EBSVolume_invalidIopsForType
--- PASS: TestAccEC2EBSVolume_withTags (85.92s)
=== CONT TestAccEC2EBSVolume_noIops
--- PASS: TestAccEC2EBSVolume_invalidIopsForType (5.13s)
=== CONT TestAccEC2EBSVolume_kmsKey
--- PASS: TestAccEC2EBSVolume_noIops (49.90s)
=== CONT TestAccEC2EBSVolume_updateSize
--- PASS: TestAccEC2EBSVolume_kmsKey (53.47s)
=== CONT TestAccEC2EBSVolume_UpdateIops_io1
--- PASS: TestAccEC2EBSVolume_updateSize (92.36s)
=== CONT TestAccEC2EBSVolume_updateType
--- PASS: TestAccEC2EBSVolume_UpdateIops_io1 (94.18s)
=== CONT TestAccEC2EBSVolume_GP3_throughput
--- PASS: TestAccEC2EBSVolume_updateType (87.38s)
=== CONT TestAccEC2EBSVolume_snapshotIDAndSize
--- PASS: TestAccEC2EBSVolume_GP3_throughput (86.09s)
=== CONT TestAccEC2EBSVolume_snapshotID
--- PASS: TestAccEC2EBSVolume_snapshotIDAndSize (95.46s)
=== CONT TestAccEC2EBSVolume_io1ToGP3
--- PASS: TestAccEC2EBSVolume_snapshotID (94.64s)
=== CONT TestAccEC2EBSVolume_gp3ToGP2
--- PASS: TestAccEC2EBSVolume_io1ToGP3 (82.73s)
=== CONT TestAccEC2EBSVolume_multiAttach_gp2
--- PASS: TestAccEC2EBSVolume_multiAttach_gp2 (4.78s)
=== CONT TestAccEC2EBSVolume_updateAttachedEBSVolume
--- PASS: TestAccEC2EBSVolume_gp3ToGP2 (88.69s)
=== CONT TestAccEC2EBSVolume_GP3_iops
--- PASS: TestAccEC2EBSVolume_GP3_iops (86.75s)
=== CONT TestAccEC2EBSVolume_multiAttach_io2
--- PASS: TestAccEC2EBSVolume_multiAttach_io2 (49.52s)
=== CONT TestAccEC2EBSVolume_outpost
acctest.go:1308: skipping since no Outposts found
--- SKIP: TestAccEC2EBSVolume_outpost (0.59s)
=== CONT TestAccEC2EBSVolume_GP3_basic
--- PASS: TestAccEC2EBSVolume_GP3_basic (50.34s)
=== CONT TestAccEC2EBSVolume_disappears
--- PASS: TestAccEC2EBSVolume_updateAttachedEBSVolume (232.40s)
--- PASS: TestAccEC2EBSVolume_disappears (42.51s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 798.877s
@leonardobiffi Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.17.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #20536
Output from acceptance testing: