iam: Improve ISO tag handling

[YakDriver]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #22532
Closes #23286

Output from acceptance testing:

% make testacc TESTS=TestAccIAMInstanceProfile_ PKG=iam
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMInstanceProfile_'  -timeout 180m
--- PASS: TestAccIAMInstanceProfile_Disappears_role (22.21s)
--- PASS: TestAccIAMInstanceProfile_disappears (22.49s)
--- PASS: TestAccIAMInstanceProfile_withoutRole (24.29s)
--- PASS: TestAccIAMInstanceProfile_basic (24.89s)
--- PASS: TestAccIAMInstanceProfile_namePrefix (24.90s)
--- PASS: TestAccIAMInstanceProfile_tags (46.92s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	48.541s
% make testacc TESTS=TestAccIAMOpenIDConnectProvider_ PKG=iam
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMOpenIDConnectProvider_'  -timeout 180m
--- PASS: TestAccIAMOpenIDConnectProvider_disappears (12.61s)
--- PASS: TestAccIAMOpenIDConnectProvider_basic (27.61s)
--- PASS: TestAccIAMOpenIDConnectProvider_tags (37.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	39.338s
% make testacc TESTS=TestAccIAMPolicy_ PKG=iam
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMPolicy_'  -timeout 180m
--- PASS: TestAccIAMPolicy_disappears (14.01s)
--- PASS: TestAccIAMPolicy_namePrefix (18.04s)
--- PASS: TestAccIAMPolicy_basic (18.04s)
--- PASS: TestAccIAMPolicy_description (18.08s)
--- PASS: TestAccIAMPolicy_path (18.09s)
--- PASS: TestAccIAMPolicy_policy (27.58s)
--- PASS: TestAccIAMPolicy_tags (36.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	38.506s
% make testacc TESTS=TestAccIAMSAMLProvider PKG=iam
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMSAMLProvider'  -timeout 180m
--- PASS: TestAccIAMSAMLProvider_disappears (13.93s)
--- PASS: TestAccIAMSAMLProvider_basic (29.92s)
--- PASS: TestAccIAMSAMLProvider_tags (40.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	42.488s
% make testacc TESTS=TestAccIAMServerCertificate PKG=iam
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMServerCertificate'  -timeout 180m
--- PASS: TestAccIAMServerCertificateDataSource_matchNamePrefix (4.66s)
--- PASS: TestAccIAMServerCertificate_disappears (17.80s)
--- PASS: TestAccIAMServerCertificate_Name_prefix (20.35s)
--- PASS: TestAccIAMServerCertificateDataSource_basic (20.68s)
--- PASS: TestAccIAMServerCertificateDataSource_path (20.77s)
--- PASS: TestAccIAMServerCertificate_path (22.88s)
--- PASS: TestAccIAMServerCertificate_basic (22.93s)
--- PASS: TestAccIAMServerCertificate_file (32.95s)
--- PASS: TestAccIAMServerCertificate_tags (46.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	48.800s
% make testacc TESTS=TestAccIAMServiceLinkedRole PKG=iam     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMServiceLinkedRole'  -timeout 180m
--- PASS: TestAccIAMServiceLinkedRole_disappears (25.11s)
--- PASS: TestAccIAMServiceLinkedRole_basic (30.96s)
--- PASS: TestAccIAMServiceLinkedRole_CustomSuffix_diffSuppressFunc (30.98s)
--- PASS: TestAccIAMServiceLinkedRole_customSuffix (31.02s)
--- PASS: TestAccIAMServiceLinkedRole_description (43.59s)
--- PASS: TestAccIAMServiceLinkedRole_tags (53.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	55.516s
% make testacc TESTS=TestAccIAMVirtualMFADevice_ PKG=iam
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMVirtualMFADevice_'  -timeout 180m
--- PASS: TestAccIAMVirtualMFADevice_disappears (13.35s)
--- PASS: TestAccIAMVirtualMFADevice_basic (17.62s)
--- PASS: TestAccIAMVirtualMFADevice_tags (40.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	42.001s

[ewbankkit]

LGTM 🚀.

% make testacc TESTS=TestAccIAMInstanceProfile_ PKG=iam
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMInstanceProfile_'  -timeout 180m
=== RUN   TestAccIAMInstanceProfile_basic
=== PAUSE TestAccIAMInstanceProfile_basic
=== RUN   TestAccIAMInstanceProfile_withoutRole
=== PAUSE TestAccIAMInstanceProfile_withoutRole
=== RUN   TestAccIAMInstanceProfile_tags
=== PAUSE TestAccIAMInstanceProfile_tags
=== RUN   TestAccIAMInstanceProfile_namePrefix
=== PAUSE TestAccIAMInstanceProfile_namePrefix
=== RUN   TestAccIAMInstanceProfile_disappears
=== PAUSE TestAccIAMInstanceProfile_disappears
=== RUN   TestAccIAMInstanceProfile_Disappears_role
=== PAUSE TestAccIAMInstanceProfile_Disappears_role
=== CONT  TestAccIAMInstanceProfile_basic
=== CONT  TestAccIAMInstanceProfile_namePrefix
=== CONT  TestAccIAMInstanceProfile_Disappears_role
=== CONT  TestAccIAMInstanceProfile_disappears
=== CONT  TestAccIAMInstanceProfile_withoutRole
=== CONT  TestAccIAMInstanceProfile_tags
--- PASS: TestAccIAMInstanceProfile_disappears (30.48s)
--- PASS: TestAccIAMInstanceProfile_withoutRole (30.49s)
--- PASS: TestAccIAMInstanceProfile_Disappears_role (30.56s)
--- PASS: TestAccIAMInstanceProfile_namePrefix (34.03s)
--- PASS: TestAccIAMInstanceProfile_basic (34.16s)
--- PASS: TestAccIAMInstanceProfile_tags (61.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	69.006s

[gdavison]

I've found a number of spots where the warning message and error message don't correspond when adding tags after creation

[github-actions]

This functionality has been released in v4.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.