Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect documentation for lb_target_group #2343

Closed
jleclanche opened this issue Nov 17, 2017 · 6 comments
Closed

Incorrect documentation for lb_target_group #2343

jleclanche opened this issue Nov 17, 2017 · 6 comments
Labels
documentation Introduces or discusses updates to documentation.
Milestone

Comments

@jleclanche
Copy link

1.3.0 changelog claims aws_lb_target_group no longer has a default on matcher, but "200" is still documented:
https://www.terraform.io/docs/providers/aws/r/lb_target_group.html

Additionally, timeout default seems to be 10 now, not 5.

@radeksimko radeksimko added the documentation Introduces or discusses updates to documentation. label Nov 17, 2017
@radeksimko radeksimko added this to the v1.3.1 milestone Nov 17, 2017
@wjglerum
Copy link

wjglerum commented Nov 17, 2017

Like I mentioned here: #2251 path is also not default anymore for a health_check block.

@jurajseffer
Copy link
Contributor

I've also just noticed this change. The defaults have changed as follows:

health_check.0.healthy_threshold:   "5" => "3"
health_check.0.matcher:             "200" => ""
health_check.0.timeout:             "5" => "10"
health_check.0.unhealthy_threshold: "2" => "3"

@catsby
Copy link
Contributor

catsby commented Nov 17, 2017

Hey @jurajseffer could you possibly provide an example configuration that shows that diff, minus any secret info? I'd like to use it for a regression test to make sure our fix handles that. Thanks!

@catsby
Copy link
Contributor

catsby commented Nov 17, 2017

We're also going to track this in #2327 just so I can consolidate issues

@catsby catsby closed this as completed Nov 17, 2017
@jurajseffer
Copy link
Contributor

@catsby

resource "aws_alb_target_group" "target" {
...
    health_check {
        path = "${var.health_check_path}"
    }
...

The above config had no changes planned under aws provider <1.3. After upgrade the same config showed changes I posted earlier

@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation.
Projects
None yet
Development

No branches or pull requests

5 participants