Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_connect_security_profile #23524

Merged
merged 7 commits into from
May 12, 2022
Merged

d/aws_connect_security_profile #23524

merged 7 commits into from
May 12, 2022

Conversation

GlennChia
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23523

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccConnectSecurityProfileDataSource' PKG=connect ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 1  -run=TestAccConnectSecurityProfileDataSource -timeout 180m
=== RUN   TestAccConnectSecurityProfileDataSource_securityProfileID
--- PASS: TestAccConnectSecurityProfileDataSource_securityProfileID (93.15s)
=== RUN   TestAccConnectSecurityProfileDataSource_name
--- PASS: TestAccConnectSecurityProfileDataSource_name (92.08s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    185.279s

...

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 5, 2022
@GlennChia GlennChia mentioned this pull request Mar 5, 2022
Closed
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 7, 2022
@AdamTylerLynch AdamTylerLynch self-requested a review April 26, 2022 15:43
AdamTylerLynch
AdamTylerLynch approved these changes Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

ewbankkit
ewbankkit approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccConnectSecurityProfileDataSource_' PKG=connect ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 1  -run=TestAccConnectSecurityProfileDataSource_ -timeout 180m
=== RUN   TestAccConnectSecurityProfileDataSource_securityProfileID
--- PASS: TestAccConnectSecurityProfileDataSource_securityProfileID (77.10s)
=== RUN   TestAccConnectSecurityProfileDataSource_name
--- PASS: TestAccConnectSecurityProfileDataSource_name (85.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	166.537s

@ewbankkit
Copy link
Contributor

@GlennChia Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e4d80ea into hashicorp:main May 12, 2022
@github-actions github-actions bot added this to the v4.14.0 milestone May 12, 2022
@GlennChia GlennChia deleted the f-aws_connect_security_profile branch May 13, 2022 14:15
@github-actions
Copy link

This functionality has been released in v4.14.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AdamTylerLynch AdamTylerLynch AdamTylerLynch approved these changes

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.14.0
Development

Successfully merging this pull request may close these issues.

Add new data_source for aws_connect_security_profile
4 participants
@GlennChia @ewbankkit @AdamTylerLynch @justinretzolk