feat(mongodb): add secrets_manager_arn #23691

brunomiranda-hotmart · 2022-03-15T14:50:43Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

resource/aws_dms_endpoint: Add secrets_manager_arn to mongo configuration

Output from acceptance testing:

$ make testacc TESTS=TestAccDMSEndpoint PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSEndpoint'  -timeout 180m
=== RUN   TestAccDMSEndpoint_basic
=== PAUSE TestAccDMSEndpoint_basic
=== RUN   TestAccDMSEndpoint_S3_basic
=== PAUSE TestAccDMSEndpoint_S3_basic
=== RUN   TestAccDMSEndpoint_S3_extraConnectionAttributes
=== PAUSE TestAccDMSEndpoint_S3_extraConnectionAttributes
=== RUN   TestAccDMSEndpoint_dynamoDB
=== PAUSE TestAccDMSEndpoint_dynamoDB
=== RUN   TestAccDMSEndpoint_OpenSearch_basic
=== PAUSE TestAccDMSEndpoint_OpenSearch_basic
=== RUN   TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes
=== PAUSE TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes
=== RUN   TestAccDMSEndpoint_OpenSearch_errorRetryDuration
=== PAUSE TestAccDMSEndpoint_OpenSearch_errorRetryDuration
=== RUN   TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage
=== PAUSE TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage
=== RUN   TestAccDMSEndpoint_kafka
=== PAUSE TestAccDMSEndpoint_kafka
=== RUN   TestAccDMSEndpoint_kinesis
=== PAUSE TestAccDMSEndpoint_kinesis
=== RUN   TestAccDMSEndpoint_MongoDB_basic
=== PAUSE TestAccDMSEndpoint_MongoDB_basic
=== RUN   TestAccDMSEndpoint_MongoDB_update
=== PAUSE TestAccDMSEndpoint_MongoDB_update
=== RUN   TestAccDMSEndpoint_MongoDB_secretID
=== PAUSE TestAccDMSEndpoint_MongoDB_secretID
=== RUN   TestAccDMSEndpoint_Oracle_basic
=== PAUSE TestAccDMSEndpoint_Oracle_basic
=== RUN   TestAccDMSEndpoint_Oracle_secretID
=== PAUSE TestAccDMSEndpoint_Oracle_secretID
=== RUN   TestAccDMSEndpoint_Oracle_update
=== PAUSE TestAccDMSEndpoint_Oracle_update
=== RUN   TestAccDMSEndpoint_PostgreSQL_basic
=== PAUSE TestAccDMSEndpoint_PostgreSQL_basic
=== RUN   TestAccDMSEndpoint_PostgreSQL_secretID
=== PAUSE TestAccDMSEndpoint_PostgreSQL_secretID
=== RUN   TestAccDMSEndpoint_PostgreSQL_update
=== PAUSE TestAccDMSEndpoint_PostgreSQL_update
=== RUN   TestAccDMSEndpoint_PostgreSQL_kmsKey
=== PAUSE TestAccDMSEndpoint_PostgreSQL_kmsKey
=== RUN   TestAccDMSEndpoint_docDB
=== PAUSE TestAccDMSEndpoint_docDB
=== RUN   TestAccDMSEndpoint_db2
=== PAUSE TestAccDMSEndpoint_db2
=== CONT  TestAccDMSEndpoint_basic
=== CONT  TestAccDMSEndpoint_MongoDB_secretID
=== CONT  TestAccDMSEndpoint_PostgreSQL_basic
=== CONT  TestAccDMSEndpoint_docDB
=== CONT  TestAccDMSEndpoint_Oracle_basic
=== CONT  TestAccDMSEndpoint_PostgreSQL_kmsKey
=== CONT  TestAccDMSEndpoint_PostgreSQL_secretID
=== CONT  TestAccDMSEndpoint_PostgreSQL_update
=== CONT  TestAccDMSEndpoint_db2
=== CONT  TestAccDMSEndpoint_Oracle_update
=== CONT  TestAccDMSEndpoint_Oracle_secretID
=== CONT  TestAccDMSEndpoint_OpenSearch_errorRetryDuration
=== CONT  TestAccDMSEndpoint_MongoDB_basic
=== CONT  TestAccDMSEndpoint_kafka
=== CONT  TestAccDMSEndpoint_dynamoDB
=== CONT  TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage
=== CONT  TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes
=== CONT  TestAccDMSEndpoint_OpenSearch_basic
=== CONT  TestAccDMSEndpoint_kinesis
=== CONT  TestAccDMSEndpoint_MongoDB_update
--- PASS: TestAccDMSEndpoint_Oracle_basic (157.03s)
=== CONT  TestAccDMSEndpoint_S3_extraConnectionAttributes
--- PASS: TestAccDMSEndpoint_PostgreSQL_basic (157.89s)
=== CONT  TestAccDMSEndpoint_S3_basic
--- PASS: TestAccDMSEndpoint_PostgreSQL_kmsKey (158.78s)
--- PASS: TestAccDMSEndpoint_OpenSearch_basic (162.57s)
--- PASS: TestAccDMSEndpoint_MongoDB_basic (165.07s)
--- PASS: TestAccDMSEndpoint_Oracle_secretID (166.42s)
--- PASS: TestAccDMSEndpoint_PostgreSQL_secretID (166.42s)
--- PASS: TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes (171.12s)
--- PASS: TestAccDMSEndpoint_OpenSearch_errorRetryDuration (175.20s)
--- PASS: TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage (175.24s)
--- PASS: TestAccDMSEndpoint_basic (183.92s)
--- PASS: TestAccDMSEndpoint_Oracle_update (185.49s)
--- PASS: TestAccDMSEndpoint_PostgreSQL_update (186.27s)
--- PASS: TestAccDMSEndpoint_docDB (186.89s)
--- PASS: TestAccDMSEndpoint_kafka (187.62s)
--- PASS: TestAccDMSEndpoint_db2 (187.82s)
--- PASS: TestAccDMSEndpoint_MongoDB_secretID (193.35s)
--- PASS: TestAccDMSEndpoint_MongoDB_update (196.77s)
--- PASS: TestAccDMSEndpoint_dynamoDB (204.09s)
--- PASS: TestAccDMSEndpoint_kinesis (222.86s)
--- PASS: TestAccDMSEndpoint_S3_extraConnectionAttributes (150.24s)
--- PASS: TestAccDMSEndpoint_S3_basic (176.13s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        338.034s

github-actions

Welcome @brunomiranda-hotmart 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

brunomiranda-hotmart · 2022-05-27T13:43:47Z

Can anyone take a look at this PR?

This reverts commit 206de0a.

This reverts commit 51d2d35.

This reverts commit 2228ff1.

This reverts commit 366e53b.

…mongodb' engine. Acceptance test output: % make testacc TESTARGS='-run=TestAccDMSEndpoint_MongoDB_' PKG=dms ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 2 -run=TestAccDMSEndpoint_MongoDB_ -timeout 180m === RUN TestAccDMSEndpoint_MongoDB_basic === PAUSE TestAccDMSEndpoint_MongoDB_basic === RUN TestAccDMSEndpoint_MongoDB_secretID === PAUSE TestAccDMSEndpoint_MongoDB_secretID === RUN TestAccDMSEndpoint_MongoDB_update === PAUSE TestAccDMSEndpoint_MongoDB_update === CONT TestAccDMSEndpoint_MongoDB_basic === CONT TestAccDMSEndpoint_MongoDB_update --- PASS: TestAccDMSEndpoint_MongoDB_basic (26.39s) === CONT TestAccDMSEndpoint_MongoDB_secretID --- PASS: TestAccDMSEndpoint_MongoDB_secretID (22.29s) --- PASS: TestAccDMSEndpoint_MongoDB_update (50.33s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/dms 54.271s

…aurora-postgresql' engine. Acceptance test output: % make testacc TESTARGS='-run=TestAccDMSEndpoint_AuroraPostgreSQL_' PKG=dms ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 2 -run=TestAccDMSEndpoint_AuroraPostgreSQL_ -timeout 180m === RUN TestAccDMSEndpoint_AuroraPostgreSQL_basic === PAUSE TestAccDMSEndpoint_AuroraPostgreSQL_basic === RUN TestAccDMSEndpoint_AuroraPostgreSQL_secretID === PAUSE TestAccDMSEndpoint_AuroraPostgreSQL_secretID === RUN TestAccDMSEndpoint_AuroraPostgreSQL_update === PAUSE TestAccDMSEndpoint_AuroraPostgreSQL_update === CONT TestAccDMSEndpoint_AuroraPostgreSQL_basic === CONT TestAccDMSEndpoint_AuroraPostgreSQL_update --- PASS: TestAccDMSEndpoint_AuroraPostgreSQL_basic (34.30s) === CONT TestAccDMSEndpoint_AuroraPostgreSQL_secretID --- PASS: TestAccDMSEndpoint_AuroraPostgreSQL_update (39.57s) --- PASS: TestAccDMSEndpoint_AuroraPostgreSQL_secretID (27.26s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/dms 65.485s

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDMSEndpoint_' PKG=dms ACCTEST_PARALLELISM=3 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 3  -run=TestAccDMSEndpoint_ -timeout 180m
=== RUN   TestAccDMSEndpoint_basic
=== PAUSE TestAccDMSEndpoint_basic
=== RUN   TestAccDMSEndpoint_Aurora_basic
=== PAUSE TestAccDMSEndpoint_Aurora_basic
=== RUN   TestAccDMSEndpoint_Aurora_secretID
=== PAUSE TestAccDMSEndpoint_Aurora_secretID
=== RUN   TestAccDMSEndpoint_Aurora_update
=== PAUSE TestAccDMSEndpoint_Aurora_update
=== RUN   TestAccDMSEndpoint_AuroraPostgreSQL_basic
=== PAUSE TestAccDMSEndpoint_AuroraPostgreSQL_basic
=== RUN   TestAccDMSEndpoint_AuroraPostgreSQL_secretID
=== PAUSE TestAccDMSEndpoint_AuroraPostgreSQL_secretID
=== RUN   TestAccDMSEndpoint_AuroraPostgreSQL_update
=== PAUSE TestAccDMSEndpoint_AuroraPostgreSQL_update
=== RUN   TestAccDMSEndpoint_S3_basic
=== PAUSE TestAccDMSEndpoint_S3_basic
=== RUN   TestAccDMSEndpoint_S3_extraConnectionAttributes
=== PAUSE TestAccDMSEndpoint_S3_extraConnectionAttributes
=== RUN   TestAccDMSEndpoint_dynamoDB
=== PAUSE TestAccDMSEndpoint_dynamoDB
=== RUN   TestAccDMSEndpoint_OpenSearch_basic
=== PAUSE TestAccDMSEndpoint_OpenSearch_basic
=== RUN   TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes
=== PAUSE TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes
=== RUN   TestAccDMSEndpoint_OpenSearch_errorRetryDuration
=== PAUSE TestAccDMSEndpoint_OpenSearch_errorRetryDuration
=== RUN   TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage
=== PAUSE TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage
=== RUN   TestAccDMSEndpoint_kafka
=== PAUSE TestAccDMSEndpoint_kafka
=== RUN   TestAccDMSEndpoint_kinesis
=== PAUSE TestAccDMSEndpoint_kinesis
=== RUN   TestAccDMSEndpoint_MongoDB_basic
=== PAUSE TestAccDMSEndpoint_MongoDB_basic
=== RUN   TestAccDMSEndpoint_MongoDB_secretID
=== PAUSE TestAccDMSEndpoint_MongoDB_secretID
=== RUN   TestAccDMSEndpoint_MongoDB_update
=== PAUSE TestAccDMSEndpoint_MongoDB_update
=== RUN   TestAccDMSEndpoint_MariaDB_basic
=== PAUSE TestAccDMSEndpoint_MariaDB_basic
=== RUN   TestAccDMSEndpoint_MariaDB_secretID
=== PAUSE TestAccDMSEndpoint_MariaDB_secretID
=== RUN   TestAccDMSEndpoint_MariaDB_update
=== PAUSE TestAccDMSEndpoint_MariaDB_update
=== RUN   TestAccDMSEndpoint_MySQL_basic
=== PAUSE TestAccDMSEndpoint_MySQL_basic
=== RUN   TestAccDMSEndpoint_MySQL_secretID
=== PAUSE TestAccDMSEndpoint_MySQL_secretID
=== RUN   TestAccDMSEndpoint_MySQL_update
=== PAUSE TestAccDMSEndpoint_MySQL_update
=== RUN   TestAccDMSEndpoint_Oracle_basic
=== PAUSE TestAccDMSEndpoint_Oracle_basic
=== RUN   TestAccDMSEndpoint_Oracle_secretID
=== PAUSE TestAccDMSEndpoint_Oracle_secretID
=== RUN   TestAccDMSEndpoint_Oracle_update
=== PAUSE TestAccDMSEndpoint_Oracle_update
=== RUN   TestAccDMSEndpoint_PostgreSQL_basic
=== PAUSE TestAccDMSEndpoint_PostgreSQL_basic
=== RUN   TestAccDMSEndpoint_PostgreSQL_secretID
=== PAUSE TestAccDMSEndpoint_PostgreSQL_secretID
=== RUN   TestAccDMSEndpoint_PostgreSQL_update
=== PAUSE TestAccDMSEndpoint_PostgreSQL_update
=== RUN   TestAccDMSEndpoint_PostgreSQL_kmsKey
=== PAUSE TestAccDMSEndpoint_PostgreSQL_kmsKey
=== RUN   TestAccDMSEndpoint_SQLServer_basic
=== PAUSE TestAccDMSEndpoint_SQLServer_basic
=== RUN   TestAccDMSEndpoint_SQLServer_secretID
=== PAUSE TestAccDMSEndpoint_SQLServer_secretID
=== RUN   TestAccDMSEndpoint_SQLServer_update
=== PAUSE TestAccDMSEndpoint_SQLServer_update
=== RUN   TestAccDMSEndpoint_SQLServer_kmsKey
=== PAUSE TestAccDMSEndpoint_SQLServer_kmsKey
=== RUN   TestAccDMSEndpoint_docDB
=== PAUSE TestAccDMSEndpoint_docDB
=== RUN   TestAccDMSEndpoint_db2
=== PAUSE TestAccDMSEndpoint_db2
=== RUN   TestAccDMSEndpoint_Redshift_basic
=== PAUSE TestAccDMSEndpoint_Redshift_basic
=== RUN   TestAccDMSEndpoint_Redshift_secretID
=== PAUSE TestAccDMSEndpoint_Redshift_secretID
=== RUN   TestAccDMSEndpoint_Redshift_update
=== PAUSE TestAccDMSEndpoint_Redshift_update
=== CONT  TestAccDMSEndpoint_basic
=== CONT  TestAccDMSEndpoint_MariaDB_update
=== CONT  TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes
--- PASS: TestAccDMSEndpoint_MariaDB_update (37.46s)
=== CONT  TestAccDMSEndpoint_MariaDB_secretID
--- PASS: TestAccDMSEndpoint_basic (37.83s)
=== CONT  TestAccDMSEndpoint_MariaDB_basic
--- PASS: TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes (40.27s)
=== CONT  TestAccDMSEndpoint_MongoDB_update
--- PASS: TestAccDMSEndpoint_MariaDB_basic (20.93s)
=== CONT  TestAccDMSEndpoint_MongoDB_secretID
--- PASS: TestAccDMSEndpoint_MariaDB_secretID (35.18s)
=== CONT  TestAccDMSEndpoint_MongoDB_basic
--- PASS: TestAccDMSEndpoint_MongoDB_update (39.64s)
=== CONT  TestAccDMSEndpoint_kinesis
--- PASS: TestAccDMSEndpoint_MongoDB_secretID (33.93s)
=== CONT  TestAccDMSEndpoint_kafka
--- PASS: TestAccDMSEndpoint_MongoDB_basic (31.76s)
=== CONT  TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage
--- PASS: TestAccDMSEndpoint_kafka (42.44s)
=== CONT  TestAccDMSEndpoint_OpenSearch_errorRetryDuration
--- PASS: TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage (39.09s)
=== CONT  TestAccDMSEndpoint_AuroraPostgreSQL_update
--- PASS: TestAccDMSEndpoint_kinesis (76.58s)
=== CONT  TestAccDMSEndpoint_OpenSearch_basic
--- PASS: TestAccDMSEndpoint_OpenSearch_errorRetryDuration (42.08s)
=== CONT  TestAccDMSEndpoint_dynamoDB
--- PASS: TestAccDMSEndpoint_AuroraPostgreSQL_update (54.67s)
=== CONT  TestAccDMSEndpoint_S3_extraConnectionAttributes
--- PASS: TestAccDMSEndpoint_OpenSearch_basic (44.10s)
=== CONT  TestAccDMSEndpoint_S3_basic
--- PASS: TestAccDMSEndpoint_dynamoDB (54.10s)
=== CONT  TestAccDMSEndpoint_AuroraPostgreSQL_secretID
--- PASS: TestAccDMSEndpoint_S3_extraConnectionAttributes (44.94s)
=== CONT  TestAccDMSEndpoint_AuroraPostgreSQL_basic
--- PASS: TestAccDMSEndpoint_AuroraPostgreSQL_secretID (32.40s)
=== CONT  TestAccDMSEndpoint_PostgreSQL_kmsKey
--- PASS: TestAccDMSEndpoint_S3_basic (66.29s)
=== CONT  TestAccDMSEndpoint_Redshift_update
--- PASS: TestAccDMSEndpoint_AuroraPostgreSQL_basic (31.08s)
=== CONT  TestAccDMSEndpoint_Redshift_secretID
--- PASS: TestAccDMSEndpoint_PostgreSQL_kmsKey (19.56s)
=== CONT  TestAccDMSEndpoint_Redshift_basic
--- PASS: TestAccDMSEndpoint_Redshift_secretID (35.79s)
=== CONT  TestAccDMSEndpoint_db2
--- PASS: TestAccDMSEndpoint_db2 (45.57s)
=== CONT  TestAccDMSEndpoint_docDB
--- PASS: TestAccDMSEndpoint_docDB (42.09s)
=== CONT  TestAccDMSEndpoint_SQLServer_kmsKey
--- PASS: TestAccDMSEndpoint_SQLServer_kmsKey (31.06s)
=== CONT  TestAccDMSEndpoint_SQLServer_update
--- PASS: TestAccDMSEndpoint_SQLServer_update (31.28s)
=== CONT  TestAccDMSEndpoint_SQLServer_secretID
--- PASS: TestAccDMSEndpoint_SQLServer_secretID (36.20s)
=== CONT  TestAccDMSEndpoint_SQLServer_basic
--- PASS: TestAccDMSEndpoint_SQLServer_basic (30.25s)
=== CONT  TestAccDMSEndpoint_Aurora_secretID
--- PASS: TestAccDMSEndpoint_Redshift_update (274.48s)
=== CONT  TestAccDMSEndpoint_Aurora_basic
--- PASS: TestAccDMSEndpoint_Redshift_basic (272.05s)
=== CONT  TestAccDMSEndpoint_Oracle_secretID
--- PASS: TestAccDMSEndpoint_Aurora_secretID (36.77s)
=== CONT  TestAccDMSEndpoint_PostgreSQL_update
--- PASS: TestAccDMSEndpoint_Aurora_basic (30.83s)
=== CONT  TestAccDMSEndpoint_PostgreSQL_secretID
--- PASS: TestAccDMSEndpoint_Oracle_secretID (25.21s)
=== CONT  TestAccDMSEndpoint_PostgreSQL_basic
--- PASS: TestAccDMSEndpoint_PostgreSQL_update (39.45s)
=== CONT  TestAccDMSEndpoint_Oracle_update
--- PASS: TestAccDMSEndpoint_PostgreSQL_basic (22.63s)
=== CONT  TestAccDMSEndpoint_MySQL_update
--- PASS: TestAccDMSEndpoint_PostgreSQL_secretID (36.75s)
=== CONT  TestAccDMSEndpoint_Oracle_basic
--- PASS: TestAccDMSEndpoint_Oracle_update (34.89s)
=== CONT  TestAccDMSEndpoint_Aurora_update
--- PASS: TestAccDMSEndpoint_MySQL_update (34.45s)
=== CONT  TestAccDMSEndpoint_MySQL_basic
--- PASS: TestAccDMSEndpoint_Oracle_basic (31.57s)
=== CONT  TestAccDMSEndpoint_MySQL_secretID
--- PASS: TestAccDMSEndpoint_MySQL_basic (21.05s)
--- PASS: TestAccDMSEndpoint_MySQL_secretID (36.08s)
--- PASS: TestAccDMSEndpoint_Aurora_update (46.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	687.490s

ewbankkit · 2022-06-02T15:12:59Z

@brunomiranda-hotmart Thanks for the contribution 🎉 👏.

ewbankkit · 2022-06-02T15:15:56Z

% make providerlint golangci-lint
==> Checking source code with providerlint...
==> Checking source code with golangci-lint...

github-actions · 2022-06-03T11:56:06Z

This functionality has been released in v4.17.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-07-04T02:41:35Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

feat(mongodb): add secrets_manager_arn

366e53b

github-actions bot added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/databasemigrationservice labels Mar 15, 2022

github-actions bot reviewed Mar 15, 2022

View reviewed changes

justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 15, 2022

brunomiranda-hotmart added 3 commits March 15, 2022 14:10

rollback miss updated comment

2228ff1

Add miss removed request

51d2d35

Add mongo secrets_manager_arn acceptance tests

206de0a

hc-github-team-terraform-aws removed the service/databasemigrationservice label Apr 26, 2022

ewbankkit added 5 commits June 2, 2022 10:06

Revert "Add mongo secrets_manager_arn acceptance tests"

e01fc64

This reverts commit 206de0a.

Revert "Add miss removed request"

52f6b10

This reverts commit 51d2d35.

Revert "rollback miss updated comment"

b729d21

This reverts commit 2228ff1.

Revert "feat(mongodb): add secrets_manager_arn"

687b93d

This reverts commit 366e53b.

Merge branch 'main' into HEAD

6be61c4

ewbankkit added the service/dms Issues and PRs that pertain to the dms service. label Jun 2, 2022

ewbankkit added 2 commits June 2, 2022 10:41

ewbankkit approved these changes Jun 2, 2022

View reviewed changes

ewbankkit merged commit 91a168b into hashicorp:main Jun 2, 2022

github-actions bot added this to the v4.17.0 milestone Jun 2, 2022

brunomiranda-hotmart deleted the f-aws_dms_endpoint-mongo-secret branch June 2, 2022 16:55

github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(mongodb): add secrets_manager_arn #23691

feat(mongodb): add secrets_manager_arn #23691

brunomiranda-hotmart commented Mar 15, 2022 •

edited by ewbankkit

Loading

github-actions bot left a comment

brunomiranda-hotmart commented May 27, 2022

ewbankkit left a comment

ewbankkit commented Jun 2, 2022

ewbankkit commented Jun 2, 2022

github-actions bot commented Jun 3, 2022

github-actions bot commented Jul 4, 2022

feat(mongodb): add secrets_manager_arn #23691

feat(mongodb): add secrets_manager_arn #23691

Conversation

brunomiranda-hotmart commented Mar 15, 2022 • edited by ewbankkit Loading

Community Note

github-actions bot left a comment

Choose a reason for hiding this comment

brunomiranda-hotmart commented May 27, 2022

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Jun 2, 2022

ewbankkit commented Jun 2, 2022

github-actions bot commented Jun 3, 2022

github-actions bot commented Jul 4, 2022

brunomiranda-hotmart commented Mar 15, 2022 •

edited by ewbankkit

Loading