Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/s3_bucket: make cors_rule configurable #23817

Merged
merged 2 commits into from
Mar 31, 2022
Merged

r/s3_bucket: make cors_rule configurable #23817

merged 2 commits into from
Mar 31, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Mar 23, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #23106
Relates #23758

Output from acceptance testing:

--- PASS: TestAccS3Bucket_Security_corsDelete (20.41s)
--- PASS: TestAccS3Bucket_Security_corsSingleMethodAndEmptyOrigin (24.14s)
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (24.44s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (40.72s)

--- PASS: TestAccS3BucketCorsConfiguration_MultipleRules (22.63s)
--- PASS: TestAccS3BucketCorsConfiguration_SingleRule (22.76s)
--- PASS: TestAccS3BucketCorsConfiguration_basic (23.01s)
--- PASS: TestAccS3BucketCorsConfiguration_migrate_corsRuleNoChange (35.51s)
--- PASS: TestAccS3BucketCorsConfiguration_migrate_corsRuleWithChange (35.57s)
--- PASS: TestAccS3BucketCorsConfiguration_update (51.90s)
--- PASS: TestAccS3BucketCorsConfiguration_disappears (139.51s)

@anGie44 anGie44 changed the title r/s3_bucket: make 'cors_rule' configurable r/s3_bucket: make cors_rule configurable Mar 23, 2022
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 23, 2022
anGie44 added a commit that referenced this pull request Mar 23, 2022
@anGie44
Update CHANGELOG for #23817
77c700c
@anGie44 anGie44 added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 23, 2022
@anGie44 anGie44 force-pushed the s3-bucket-acceleration-status branch from 02d8994 to 7b84f21 Compare March 31, 2022 20:39
Base automatically changed from s3-bucket-acceleration-status to release/4.x-s3-bucket-changes March 31, 2022 21:08
@anGie44 anGie44 force-pushed the s3-bucket-cors-rule branch from 77c700c to fd098d2 Compare March 31, 2022 21:09
@anGie44 anGie44 marked this pull request as ready for review March 31, 2022 21:10
@anGie44 anGie44 merged commit 9baa674 into release/4.x-s3-bucket-changes Mar 31, 2022
@anGie44 anGie44 deleted the s3-bucket-cors-rule branch March 31, 2022 21:49
@github-actions github-actions bot added this to the v4.9.0 milestone Mar 31, 2022
github-actions bot pushed a commit that referenced this pull request Mar 31, 2022
Update CHANGELOG.md for #23817
9769fe6
anGie44 added a commit that referenced this pull request Apr 1, 2022
@anGie44
Update CHANGELOG for #23817
5effab0
anGie44 pushed a commit that referenced this pull request Apr 1, 2022
@anGie44
Update CHANGELOG.md for #23817
df7fabe
anGie44 added a commit that referenced this pull request Apr 2, 2022
@anGie44
Update CHANGELOG for #23817
e8c383c
anGie44 pushed a commit that referenced this pull request Apr 2, 2022
@anGie44
Update CHANGELOG.md for #23817
235dc4e
gdavison pushed a commit that referenced this pull request Apr 5, 2022
@anGie44 @gdavison
Update CHANGELOG for #23817
2e17219
gdavison pushed a commit that referenced this pull request Apr 5, 2022
@gdavison
Update CHANGELOG.md for #23817
764b18d
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.9.0
Development

Successfully merging this pull request may close these issues.
1 participant
@anGie44