Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/s3_bucket: make logging configurable #23819

Merged
merged 2 commits into from
Mar 31, 2022
Merged

r/s3_bucket: make logging configurable #23819

merged 2 commits into from
Mar 31, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Mar 23, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #23106
Relates #23758

Output from acceptance testing:

--- PASS: TestAccS3Bucket_Security_logging (25.98s)

--- SKIP: TestAccS3BucketLogging_TargetGrantByEmail (0.00s)
--- PASS: TestAccS3BucketLogging_disappears (24.19s)
--- PASS: TestAccS3BucketLogging_basic (28.36s)
--- PASS: TestAccS3BucketLogging_migrate_loggingNoChange (46.11s)
--- PASS: TestAccS3BucketLogging_migrate_loggingWithChange (46.23s)
--- PASS: TestAccS3BucketLogging_TargetGrantByGroup (63.53s)
--- PASS: TestAccS3BucketLogging_TargetGrantByID (64.80s)
--- PASS: TestAccS3BucketLogging_update (64.95s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Mar 23, 2022
anGie44 added a commit that referenced this pull request Mar 23, 2022
@anGie44
Update CHANGELOG for #23819
0946032
@anGie44 anGie44 added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 23, 2022
@anGie44 anGie44 force-pushed the s3-bucket-lifecycle-rule branch from db106a5 to ce8a305 Compare March 31, 2022 21:53
Base automatically changed from s3-bucket-lifecycle-rule to release/4.x-s3-bucket-changes March 31, 2022 22:59
@anGie44 anGie44 force-pushed the s3-bucket-logging branch from 0946032 to 34243d0 Compare March 31, 2022 23:04
@anGie44 anGie44 force-pushed the s3-bucket-logging branch from 34243d0 to f344e0d Compare March 31, 2022 23:05
@anGie44 anGie44 force-pushed the s3-bucket-logging branch from f344e0d to 66734b6 Compare March 31, 2022 23:07
@anGie44 anGie44 force-pushed the s3-bucket-logging branch from 66734b6 to a3ac4c9 Compare March 31, 2022 23:12
@anGie44 anGie44 marked this pull request as ready for review March 31, 2022 23:14
@anGie44 anGie44 merged commit c9948dd into release/4.x-s3-bucket-changes Mar 31, 2022
@anGie44 anGie44 deleted the s3-bucket-logging branch March 31, 2022 23:29
@github-actions github-actions bot added this to the v4.9.0 milestone Mar 31, 2022
github-actions bot pushed a commit that referenced this pull request Mar 31, 2022
Update CHANGELOG.md for #23819
6d18853
anGie44 added a commit that referenced this pull request Apr 1, 2022
@anGie44
Update CHANGELOG for #23819
d7028f1
anGie44 pushed a commit that referenced this pull request Apr 1, 2022
@anGie44
Update CHANGELOG.md for #23819
5e1a06e
anGie44 added a commit that referenced this pull request Apr 2, 2022
@anGie44
Update CHANGELOG for #23819
a1703a6
anGie44 pushed a commit that referenced this pull request Apr 2, 2022
@anGie44
Update CHANGELOG.md for #23819
c02774b
gdavison pushed a commit that referenced this pull request Apr 5, 2022
@anGie44 @gdavison
Update CHANGELOG for #23819
2cf464c
gdavison pushed a commit that referenced this pull request Apr 5, 2022
@gdavison
Update CHANGELOG.md for #23819
ed0c5f3
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.9.0
Development

Successfully merging this pull request may close these issues.
1 participant
@anGie44