Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/s3_bucket: make website configurable #23821

Merged
merged 2 commits into from
Apr 1, 2022
Merged

r/s3_bucket: make website configurable #23821

merged 2 commits into from
Apr 1, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Mar 23, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #23106
Relates #23758
Output from acceptance testing:

--- PASS: TestAccS3Bucket_Web_routingRules (33.35s)
--- PASS: TestAccS3Bucket_Web_simple (51.95s)
--- PASS: TestAccS3Bucket_Web_redirect (52.25s)

--- PASS: TestAccS3BucketWebsiteConfiguration_disappears (25.81s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_RedirectOnly (30.18s)
--- PASS: TestAccS3BucketWebsiteConfiguration_Redirect (30.25s)
--- PASS: TestAccS3BucketWebsiteConfiguration_basic (30.25s)
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange (43.01s)
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange (43.57s)
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRulesNoChange (43.61s)
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRulesWithChange (43.71s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_MultipleRules (45.91s)
--- PASS: TestAccS3BucketWebsiteConfiguration_update (46.26s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect (72.61s)

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 23, 2022
anGie44 added a commit that referenced this pull request Mar 23, 2022
@anGie44
Update CHANGELOG for #23821
07c3f61
@anGie44 anGie44 force-pushed the s3-bucket-website branch from 07c3f61 to 4583d79 Compare March 23, 2022 05:17
@anGie44 anGie44 force-pushed the s3-bucket-website branch 2 times, most recently from 2a9e58b to 07c3f61 Compare March 23, 2022 05:19
@anGie44 anGie44 added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 23, 2022
@anGie44 anGie44 force-pushed the s3-bucket-versioning branch 4 times, most recently from ec386ed to dbeae56 Compare March 31, 2022 23:37
Base automatically changed from s3-bucket-versioning to release/4.x-s3-bucket-changes March 31, 2022 23:56
@anGie44 anGie44 force-pushed the s3-bucket-website branch from 9ac8665 to d6d9ba9 Compare April 1, 2022 00:03
@anGie44 anGie44 force-pushed the s3-bucket-website branch from d6d9ba9 to e89a556 Compare April 1, 2022 00:04
@anGie44 anGie44 force-pushed the s3-bucket-website branch from e89a556 to 2b8b551 Compare April 1, 2022 00:08
@anGie44 anGie44 marked this pull request as ready for review April 1, 2022 00:09
@anGie44 anGie44 merged commit a40373a into release/4.x-s3-bucket-changes Apr 1, 2022
@anGie44 anGie44 deleted the s3-bucket-website branch April 1, 2022 00:36
@github-actions github-actions bot added this to the v4.9.0 milestone Apr 1, 2022
github-actions bot pushed a commit that referenced this pull request Apr 1, 2022
Update CHANGELOG.md for #23821
a5f8a1b
anGie44 added a commit that referenced this pull request Apr 1, 2022
@anGie44
Update CHANGELOG for #23821
2342045
anGie44 pushed a commit that referenced this pull request Apr 1, 2022
@anGie44
Update CHANGELOG.md for #23821
2bab895
anGie44 added a commit that referenced this pull request Apr 2, 2022
@anGie44
Update CHANGELOG for #23821
12a3925
anGie44 pushed a commit that referenced this pull request Apr 2, 2022
@anGie44
Update CHANGELOG.md for #23821
5396775
gdavison pushed a commit that referenced this pull request Apr 5, 2022
@anGie44 @gdavison
Update CHANGELOG for #23821
0d502fd
gdavison pushed a commit that referenced this pull request Apr 5, 2022
@gdavison
Update CHANGELOG.md for #23821
3638a90
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.9.0
Development

Successfully merging this pull request may close these issues.
1 participant
@anGie44