Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Account ID to Launch Template Configurations in aws_imagebuilder_distribution_configuration #23919

Closed
seantibor opened this issue Mar 29, 2022 · 2 comments · Fixed by #23924
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/imagebuilder Issues and PRs that pertain to the imagebuilder service.
Milestone

Comments

@seantibor
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The launch template configurations block that was added to aws_imagebuilder_distribution in #22842 and release 4.0 does not include Account ID as provided in the API. This would enable launch templates to be updated across accounts when pipelines are completed.

New or Affected Resource(s)

  • aws_imagebuilder_distribution_configuration

Potential Terraform Configuration

resource "aws_imagebuilder_distribution_configuration" "example" {
  name = "example"

  distribution {
    ami_distribution_configuration {
      ami_tags = {
        CostCenter = "IT"
      }

      name = "example-{{ imagebuilder:buildDate }}"

      launch_permission {
        user_ids = ["123456789012"]
      }

    launchTemplateConfiguration {
                    launchTemplateId = "lt-0a1bcde2fgh34567"
                    accountId =  "935302948087"
                    setDefaultVersion =  true
    }
    launchTemplateConfiguration {
                    launchTemplateId = "lt-0aaa1bcde2ff3456" # only this field is required
    }

    region = "us-east-1"
  }
}

References

@seantibor seantibor added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 29, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. labels Mar 29, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Mar 29, 2022
@github-actions github-actions bot added this to the v4.9.0 milestone Mar 29, 2022
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 8, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/imagebuilder Issues and PRs that pertain to the imagebuilder service.
Projects
None yet
2 participants