-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/s3_bucket: make object_lock_configuration.rule
configurable
#23984
r/s3_bucket: make object_lock_configuration.rule
configurable
#23984
Conversation
3ba869b
to
a25feef
Compare
a25feef
to
2245948
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccS3BucketObjectLockConfiguration_\|TestAccS3Bucket_Manage_' PKG=s3 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 3 -run=TestAccS3BucketObjectLockConfiguration_\|TestAccS3Bucket_Manage_ -timeout 180m
=== RUN TestAccS3BucketObjectLockConfiguration_basic
=== PAUSE TestAccS3BucketObjectLockConfiguration_basic
=== RUN TestAccS3BucketObjectLockConfiguration_disappears
=== PAUSE TestAccS3BucketObjectLockConfiguration_disappears
=== RUN TestAccS3BucketObjectLockConfiguration_update
=== PAUSE TestAccS3BucketObjectLockConfiguration_update
=== RUN TestAccS3BucketObjectLockConfiguration_migrate_noChange
=== PAUSE TestAccS3BucketObjectLockConfiguration_migrate_noChange
=== RUN TestAccS3BucketObjectLockConfiguration_migrate_withChange
=== PAUSE TestAccS3BucketObjectLockConfiguration_migrate_withChange
=== RUN TestAccS3Bucket_Manage_lifecycleBasic
=== PAUSE TestAccS3Bucket_Manage_lifecycleBasic
=== RUN TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly
=== PAUSE TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly
=== RUN TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock
=== PAUSE TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock
=== RUN TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration
=== PAUSE TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration
=== RUN TestAccS3Bucket_Manage_lifecycleRemove
=== PAUSE TestAccS3Bucket_Manage_lifecycleRemove
=== RUN TestAccS3Bucket_Manage_objectLock
=== PAUSE TestAccS3Bucket_Manage_objectLock
=== RUN TestAccS3Bucket_Manage_objectLock_deprecatedEnabled
=== PAUSE TestAccS3Bucket_Manage_objectLock_deprecatedEnabled
=== RUN TestAccS3Bucket_Manage_objectLock_migrate
=== PAUSE TestAccS3Bucket_Manage_objectLock_migrate
=== RUN TestAccS3Bucket_Manage_objectLockWithVersioning
=== PAUSE TestAccS3Bucket_Manage_objectLockWithVersioning
=== RUN TestAccS3Bucket_Manage_objectLockWithVersioning_deprecatedEnabled
=== PAUSE TestAccS3Bucket_Manage_objectLockWithVersioning_deprecatedEnabled
=== RUN TestAccS3Bucket_Manage_versioning
=== PAUSE TestAccS3Bucket_Manage_versioning
=== RUN TestAccS3Bucket_Manage_versioningDisabled
=== PAUSE TestAccS3Bucket_Manage_versioningDisabled
=== RUN TestAccS3Bucket_Manage_MfaDeleteDisabled
=== PAUSE TestAccS3Bucket_Manage_MfaDeleteDisabled
=== RUN TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled
=== PAUSE TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled
=== CONT TestAccS3BucketObjectLockConfiguration_basic
=== CONT TestAccS3Bucket_Manage_objectLock
=== CONT TestAccS3Bucket_Manage_versioning
--- PASS: TestAccS3BucketObjectLockConfiguration_basic (22.67s)
=== CONT TestAccS3Bucket_Manage_objectLockWithVersioning
--- PASS: TestAccS3Bucket_Manage_objectLock (40.04s)
=== CONT TestAccS3Bucket_Manage_objectLockWithVersioning_deprecatedEnabled
--- PASS: TestAccS3Bucket_Manage_versioning (43.36s)
=== CONT TestAccS3Bucket_Manage_objectLock_migrate
--- PASS: TestAccS3Bucket_Manage_objectLockWithVersioning (24.57s)
=== CONT TestAccS3Bucket_Manage_lifecycleBasic
--- PASS: TestAccS3Bucket_Manage_objectLockWithVersioning_deprecatedEnabled (25.81s)
=== CONT TestAccS3Bucket_Manage_lifecycleRemove
--- PASS: TestAccS3Bucket_Manage_objectLock_migrate (27.29s)
=== CONT TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (37.46s)
=== CONT TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (26.04s)
=== CONT TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly
--- PASS: TestAccS3Bucket_Manage_lifecycleRemove (36.39s)
=== CONT TestAccS3BucketObjectLockConfiguration_migrate_noChange
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (21.09s)
=== CONT TestAccS3BucketObjectLockConfiguration_migrate_withChange
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (40.80s)
=== CONT TestAccS3Bucket_Manage_objectLock_deprecatedEnabled
--- PASS: TestAccS3BucketObjectLockConfiguration_migrate_noChange (40.62s)
=== CONT TestAccS3BucketObjectLockConfiguration_update
=== CONT TestAccS3Bucket_Manage_MfaDeleteDisabled
--- PASS: TestAccS3BucketObjectLockConfiguration_migrate_withChange (40.93s)
--- PASS: TestAccS3Bucket_Manage_objectLock_deprecatedEnabled (25.28s)
=== CONT TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled
--- PASS: TestAccS3Bucket_Manage_MfaDeleteDisabled (25.70s)
=== CONT TestAccS3Bucket_Manage_versioningDisabled
--- PASS: TestAccS3BucketObjectLockConfiguration_update (43.57s)
=== CONT TestAccS3BucketObjectLockConfiguration_disappears
--- PASS: TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled (27.76s)
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (31.28s)
--- PASS: TestAccS3BucketObjectLockConfiguration_disappears (23.71s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 213.899s
This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #23106
Output from acceptance testing: