F/aws ecs capacity provider #24005
Closed
F/aws ecs capacity provider #24005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r max_instance_lifetime is 86400
…orp#20701) As shown in hashicorp#20493 the documentation does not accurately reflect the current observed behaviour of this provider. The docs say that metadata_options.http_endpoint is optional, but the provider gives an error if http_endpoint is omitted.
# Conflicts: # aws/resource_aws_cloudformation_stack_set.go # aws/resource_aws_ebs_volume.go # aws/resource_aws_ebs_volume_test.go # aws/resource_aws_securityhub_member_test.go # website/docs/r/autoscaling_group.html.markdown
github-actions
bot
added
size/XS
ewbankkit
added
bug
github-actions
bot
added
the
tests
ewbankkit
added
the
breaking-change
% make testacc TESTS=TestAccECSCapacityProvider_ PKG=ecs ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
=== RUN TestAccECSCapacityProvider_basic
=== PAUSE TestAccECSCapacityProvider_basic
=== RUN TestAccECSCapacityProvider_disappears
=== PAUSE TestAccECSCapacityProvider_disappears
=== RUN TestAccECSCapacityProvider_managedScaling
=== PAUSE TestAccECSCapacityProvider_managedScaling
=== RUN TestAccECSCapacityProvider_managedScalingPartial
=== PAUSE TestAccECSCapacityProvider_managedScalingPartial
=== RUN TestAccECSCapacityProvider_tags
=== PAUSE TestAccECSCapacityProvider_tags
=== CONT TestAccECSCapacityProvider_basic
--- PASS: TestAccECSCapacityProvider_basic (88.30s)
=== CONT TestAccECSCapacityProvider_managedScalingPartial
capacity_provider_test.go:132: Step 1/2 error: Check failed: Check 5/9 error: aws_ecs_capacity_provider.test: Attribute 'auto_scaling_group_provider.0.managed_scaling.0.instance_warmup_period' expected "300", got "0"
--- FAIL: TestAccECSCapacityProvider_managedScalingPartial (52.00s)
=== CONT TestAccECSCapacityProvider_tags
--- PASS: TestAccECSCapacityProvider_tags (155.85s)
=== CONT TestAccECSCapacityProvider_managedScaling
--- PASS: TestAccECSCapacityProvider_managedScaling (130.84s)
=== CONT TestAccECSCapacityProvider_disappears
--- PASS: TestAccECSCapacityProvider_disappears (75.06s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/ecs 506.443s
FAIL
make: *** [testacc] Error 1 |
|
Because we cannot currently detect the different between an unspecified nested attribute value and its zero value, this would be a breaking change. |
ewbankkit
removed
the
breaking-change
|
Superseded by #31231. |
|
This functionality has been released in v5.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #24003.
Output from acceptance testing: