Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/config_config_rule - use finder + add custom policy #24057

Merged
merged 9 commits into from
Apr 12, 2022
Merged

r/config_config_rule - use finder + add custom policy #24057

merged 9 commits into from
Apr 12, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Apr 7, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTS=make testacc TESTS=TestAccConfigService_serial/Config/ PKG=configservice

    --- PASS: TestAccConfigService_serial/ConfigurationRecorder (175.38s)
        --- PASS: TestAccConfigService_serial/ConfigurationRecorder/basic (59.40s)
        --- PASS: TestAccConfigService_serial/ConfigurationRecorder/allParams (56.10s)
        --- PASS: TestAccConfigService_serial/ConfigurationRecorder/importBasic (59.89s)
    --- PASS: TestAccConfigService_serial/RemediationConfiguration (557.86s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/updates (118.95s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/basic (107.82s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/basicBackward (99.27s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/disappears (102.20s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/recreates (129.63s)
    --- FAIL: TestAccConfigService_serial/Config (1038.46s)
        --- PASS: TestAccConfigService_serial/Config/basic (99.68s)
        --- PASS: TestAccConfigService_serial/Config/ownerAws (104.67s)
        --- PASS: TestAccConfigService_serial/Config/customlambda (141.72s)
        --- PASS: TestAccConfigService_serial/Config/scopeTagValue (124.44s)
        --- PASS: TestAccConfigService_serial/Config/customPolicy (107.53s)
        --- PASS: TestAccConfigService_serial/Config/tags (155.58s)
        --- PASS: TestAccConfigService_serial/Config/disappears (99.14s)
        --- PASS: TestAccConfigService_serial/Config/scopeTagKey (124.67s)

        --- PASS: TestAccConfigService_serial/Config/scopeTagKeyEmpty (100.30s)
    --- PASS: TestAccConfigService_serial/ConfigurationRecorderStatus (230.88s)
        --- PASS: TestAccConfigService_serial/ConfigurationRecorderStatus/basic (55.21s)
        --- PASS: TestAccConfigService_serial/ConfigurationRecorderStatus/startEnabled (115.19s)
        --- PASS: TestAccConfigService_serial/ConfigurationRecorderStatus/importBasic (60.48s)

@github-actions github-actions bot added service/configservice Issues and PRs that pertain to the configservice service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Apr 7, 2022
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 7, 2022
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. and removed size/L Managed by automation to categorize the size of a PR. labels Apr 8, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review April 8, 2022 15:20
@DrFaust92 DrFaust92 force-pushed the configservice-policy branch from e69b35e to 5204f36 Compare April 9, 2022 05:51
ewbankkit
ewbankkit approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccConfigService_serial/Config PKG=configservice
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/configservice/... -v -count 1 -parallel 20 -run='TestAccConfigService_serial/Config'  -timeout 180m
=== RUN   TestAccConfigService_serial
=== RUN   TestAccConfigService_serial/RemediationConfiguration
=== RUN   TestAccConfigService_serial/RemediationConfiguration/disappears
=== RUN   TestAccConfigService_serial/RemediationConfiguration/recreates
=== RUN   TestAccConfigService_serial/RemediationConfiguration/updates
=== RUN   TestAccConfigService_serial/RemediationConfiguration/basic
=== RUN   TestAccConfigService_serial/RemediationConfiguration/basicBackward
=== RUN   TestAccConfigService_serial/Config
=== RUN   TestAccConfigService_serial/Config/basic
=== RUN   TestAccConfigService_serial/Config/ownerAws
=== RUN   TestAccConfigService_serial/Config/customPolicy
=== RUN   TestAccConfigService_serial/Config/scopeTagKey
=== RUN   TestAccConfigService_serial/Config/scopeTagKeyEmpty
=== RUN   TestAccConfigService_serial/Config/disappears
=== RUN   TestAccConfigService_serial/Config/customlambda
=== RUN   TestAccConfigService_serial/Config/scopeTagValue
=== RUN   TestAccConfigService_serial/Config/tags
=== RUN   TestAccConfigService_serial/ConfigurationRecorderStatus
=== RUN   TestAccConfigService_serial/ConfigurationRecorderStatus/basic
=== RUN   TestAccConfigService_serial/ConfigurationRecorderStatus/startEnabled
=== RUN   TestAccConfigService_serial/ConfigurationRecorderStatus/importBasic
=== RUN   TestAccConfigService_serial/ConfigurationRecorder
=== RUN   TestAccConfigService_serial/ConfigurationRecorder/basic
=== RUN   TestAccConfigService_serial/ConfigurationRecorder/allParams
=== RUN   TestAccConfigService_serial/ConfigurationRecorder/importBasic
--- PASS: TestAccConfigService_serial (1575.29s)
    --- PASS: TestAccConfigService_serial/RemediationConfiguration (475.28s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/disappears (87.52s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/recreates (102.59s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/updates (106.09s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/basic (92.12s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/basicBackward (86.96s)
    --- PASS: TestAccConfigService_serial/Config (871.47s)
        --- PASS: TestAccConfigService_serial/Config/basic (82.20s)
        --- PASS: TestAccConfigService_serial/Config/ownerAws (86.44s)
        --- PASS: TestAccConfigService_serial/Config/customPolicy (85.06s)
        --- PASS: TestAccConfigService_serial/Config/scopeTagKey (104.58s)
        --- PASS: TestAccConfigService_serial/Config/scopeTagKeyEmpty (91.74s)
        --- PASS: TestAccConfigService_serial/Config/disappears (85.95s)
        --- PASS: TestAccConfigService_serial/Config/customlambda (122.69s)
        --- PASS: TestAccConfigService_serial/Config/scopeTagValue (100.11s)
        --- PASS: TestAccConfigService_serial/Config/tags (112.70s)
    --- PASS: TestAccConfigService_serial/ConfigurationRecorderStatus (131.05s)
        --- PASS: TestAccConfigService_serial/ConfigurationRecorderStatus/basic (38.34s)
        --- PASS: TestAccConfigService_serial/ConfigurationRecorderStatus/startEnabled (62.27s)
        --- PASS: TestAccConfigService_serial/ConfigurationRecorderStatus/importBasic (30.44s)
    --- PASS: TestAccConfigService_serial/ConfigurationRecorder (97.50s)
        --- PASS: TestAccConfigService_serial/ConfigurationRecorder/basic (30.01s)
        --- PASS: TestAccConfigService_serial/ConfigurationRecorder/allParams (37.20s)
        --- PASS: TestAccConfigService_serial/ConfigurationRecorder/importBasic (30.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/configservice	1579.463s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ef5034f into hashicorp:main Apr 12, 2022
@github-actions github-actions bot added this to the v4.10.0 milestone Apr 12, 2022
@github-actions
Copy link

This functionality has been released in v4.10.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2022
@DrFaust92 DrFaust92 deleted the configservice-policy branch May 21, 2022 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/configservice Issues and PRs that pertain to the configservice service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DrFaust92 @ewbankkit