Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/s3_bucket_website_configuration: add routing_rules parameter to assist in configuring rules with empty string values #24198

Merged
merged 3 commits into from
May 19, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Apr 12, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #24048

Description

  • Lists/Sets with nested empty string parameters are not interpreted from configurations shown in the linked issue, so this PR adds the routing_rules parameter used in the aws_s3_bucket resource as workaround for practitioners, which perhaps was used for these circumstances.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccS3BucketWebsiteConfiguration_' PKG=s3 ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 5  -run=TestAccS3BucketWebsiteConfiguration_ -timeout 180m
=== RUN   TestAccS3BucketWebsiteConfiguration_basic
=== PAUSE TestAccS3BucketWebsiteConfiguration_basic
=== RUN   TestAccS3BucketWebsiteConfiguration_disappears
=== PAUSE TestAccS3BucketWebsiteConfiguration_disappears
=== RUN   TestAccS3BucketWebsiteConfiguration_update
=== PAUSE TestAccS3BucketWebsiteConfiguration_update
=== RUN   TestAccS3BucketWebsiteConfiguration_Redirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_Redirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange
=== CONT  TestAccS3BucketWebsiteConfiguration_basic
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString (23.34s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
--- PASS: TestAccS3BucketWebsiteConfiguration_basic (23.67s)
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange (37.92s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange (38.03s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange (38.14s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules (33.95s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange (35.17s)
=== CONT  TestAccS3BucketWebsiteConfiguration_update
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect (22.06s)
=== CONT  TestAccS3BucketWebsiteConfiguration_Redirect
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly (22.01s)
=== CONT  TestAccS3BucketWebsiteConfiguration_disappears
--- PASS: TestAccS3BucketWebsiteConfiguration_disappears (18.14s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
--- PASS: TestAccS3BucketWebsiteConfiguration_Redirect (21.64s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules (39.14s)
--- PASS: TestAccS3BucketWebsiteConfiguration_update (38.13s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect (35.34s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect (78.05s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	119.345s

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 12, 2022
@anGie44 anGie44 modified the milestone: v3.75.2 Apr 12, 2022
@anGie44 anGie44 force-pushed the b-s3-bucket-website-config-routing-rules branch from 15e6adb to 4a85b55 Compare April 12, 2022 19:46
@@ -142,6 +147,17 @@ func ResourceBucketWebsiteConfiguration() *schema.Resource {
},
},
},
"routing_rules": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently not entirely sure if we should keep both params or deprecate routing_rule in favor of this one 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm or we can always deprecate one of these later if for example we migrate to the plugin-framework and that better supports empty string values in nested types

@anGie44 anGie44 added bug Addresses a defect in current functionality. enhancement Requests to existing resources that expand the functionality or scope. and removed bug Addresses a defect in current functionality. labels Apr 12, 2022
anGie44 added a commit that referenced this pull request Apr 12, 2022
anGie44 added 2 commits May 19, 2022 11:54
…ssist in configuring rules with empty string values not interpreted when using 'routing_rule' instead
@anGie44 anGie44 force-pushed the b-s3-bucket-website-config-routing-rules branch from 3b9d873 to 7917db3 Compare May 19, 2022 15:54
@anGie44
Copy link
Contributor Author

anGie44 commented May 19, 2022

Output of acceptance tests after rebase:

Commercial:

make testacc TESTARGS='-run=TestAccS3BucketWebsiteConfiguration_' PKG=s3 ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 5  -run=TestAccS3BucketWebsiteConfiguration_ -timeout 180m
go: downloading github.com/aws/aws-sdk-go v1.44.15
=== RUN   TestAccS3BucketWebsiteConfiguration_basic
=== PAUSE TestAccS3BucketWebsiteConfiguration_basic
=== RUN   TestAccS3BucketWebsiteConfiguration_disappears
=== PAUSE TestAccS3BucketWebsiteConfiguration_disappears
=== RUN   TestAccS3BucketWebsiteConfiguration_update
=== PAUSE TestAccS3BucketWebsiteConfiguration_update
=== RUN   TestAccS3BucketWebsiteConfiguration_Redirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_Redirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange
=== CONT  TestAccS3BucketWebsiteConfiguration_basic
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
--- PASS: TestAccS3BucketWebsiteConfiguration_basic (26.92s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString (26.97s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange (40.47s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange (40.84s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange (40.86s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect (26.19s)
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly (25.55s)
=== CONT  TestAccS3BucketWebsiteConfiguration_update
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules (38.75s)
=== CONT  TestAccS3BucketWebsiteConfiguration_Redirect
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules (43.04s)
=== CONT  TestAccS3BucketWebsiteConfiguration_disappears
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange (34.61s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
--- PASS: TestAccS3BucketWebsiteConfiguration_Redirect (22.35s)
--- PASS: TestAccS3BucketWebsiteConfiguration_disappears (18.58s)
--- PASS: TestAccS3BucketWebsiteConfiguration_update (39.09s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect (88.47s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect (35.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	126.859s

GovCloud:

make testacc TESTARGS='-run=TestAccS3BucketWebsiteConfiguration_' PKG=s3 ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 5  -run=TestAccS3BucketWebsiteConfiguration_ -timeout 180m
=== RUN   TestAccS3BucketWebsiteConfiguration_basic
=== PAUSE TestAccS3BucketWebsiteConfiguration_basic
=== RUN   TestAccS3BucketWebsiteConfiguration_disappears
=== PAUSE TestAccS3BucketWebsiteConfiguration_disappears
=== RUN   TestAccS3BucketWebsiteConfiguration_update
=== PAUSE TestAccS3BucketWebsiteConfiguration_update
=== RUN   TestAccS3BucketWebsiteConfiguration_Redirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_Redirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange
=== CONT  TestAccS3BucketWebsiteConfiguration_basic
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
--- PASS: TestAccS3BucketWebsiteConfiguration_basic (33.14s)
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString (33.17s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange (42.38s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange (42.73s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules (46.19s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect (22.70s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly (23.90s)
=== CONT  TestAccS3BucketWebsiteConfiguration_Redirect
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange (37.19s)
=== CONT  TestAccS3BucketWebsiteConfiguration_disappears
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect (36.72s)
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
--- PASS: TestAccS3BucketWebsiteConfiguration_disappears (18.23s)
=== CONT  TestAccS3BucketWebsiteConfiguration_update
--- PASS: TestAccS3BucketWebsiteConfiguration_Redirect (22.18s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules (38.48s)
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange (34.73s)
--- PASS: TestAccS3BucketWebsiteConfiguration_update (37.37s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect (95.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	131.962s

** CI failures look unrelated atm

@anGie44 anGie44 marked this pull request as ready for review May 19, 2022 16:29
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccS3BucketWebsiteConfiguration_' PKG=s3 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 3  -run=TestAccS3BucketWebsiteConfiguration_ -timeout 180m
=== RUN   TestAccS3BucketWebsiteConfiguration_basic
=== PAUSE TestAccS3BucketWebsiteConfiguration_basic
=== RUN   TestAccS3BucketWebsiteConfiguration_disappears
=== PAUSE TestAccS3BucketWebsiteConfiguration_disappears
=== RUN   TestAccS3BucketWebsiteConfiguration_update
=== PAUSE TestAccS3BucketWebsiteConfiguration_update
=== RUN   TestAccS3BucketWebsiteConfiguration_Redirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_Redirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
=== RUN   TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
=== PAUSE TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
=== RUN   TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange
=== PAUSE TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange
=== CONT  TestAccS3BucketWebsiteConfiguration_basic
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange
--- PASS: TestAccS3BucketWebsiteConfiguration_basic (24.86s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString (24.90s)
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange (39.64s)
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules (35.62s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange (37.80s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange (35.21s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect (38.67s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect (24.55s)
=== CONT  TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly (22.14s)
=== CONT  TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules (40.92s)
=== CONT  TestAccS3BucketWebsiteConfiguration_disappears
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect (83.27s)
=== CONT  TestAccS3BucketWebsiteConfiguration_Redirect
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange (36.65s)
=== CONT  TestAccS3BucketWebsiteConfiguration_update
--- PASS: TestAccS3BucketWebsiteConfiguration_disappears (21.71s)
--- PASS: TestAccS3BucketWebsiteConfiguration_Redirect (25.04s)
--- PASS: TestAccS3BucketWebsiteConfiguration_update (39.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	200.774s

.changelog/24198.txt Outdated Show resolved Hide resolved
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
@anGie44 anGie44 added this to the v4.15.0 milestone May 19, 2022
@anGie44 anGie44 merged commit 1f5f56a into main May 19, 2022
@anGie44 anGie44 deleted the b-s3-bucket-website-config-routing-rules branch May 19, 2022 18:32
github-actions bot pushed a commit that referenced this pull request May 19, 2022
@github-actions
Copy link

This functionality has been released in v4.15.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants