Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate elasticache user password is between 16-128 #24273

Closed
scottd018 opened this issue Apr 15, 2022 · 2 comments · Fixed by #24274
Closed

Validate elasticache user password is between 16-128 #24273

scottd018 opened this issue Apr 15, 2022 · 2 comments · Fixed by #24274
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service.
Milestone

Comments

@scottd018
Copy link
Contributor

scottd018 commented Apr 15, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Add validation for password for the aws_elasticache_user resource. The below configuration will get through deployment and fail with an AWS validation error. This is especially problematic for long-running Terraform modules as the input is not validated up front.

image

Without this validation the following error may occur:

│ Error: error creating ElastiCache User: InvalidParameterValue: Passwords length must be between 16-128 characters.
│       status code: 400, request id: <ID>
│ 
│   with module.test.aws_elasticache_user.this,
│   on ../elasticache.tf line 56, in resource "aws_elasticache_user" "this":
│   56: resource "aws_elasticache_user" "this" {

New or Affected Resource(s)

N/A

Potential Terraform Configuration

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.

resource "aws_elasticache_user" "this" {
  user_id       = var.redis_user
  user_name     = var.redis_user
  access_string = "on ~app::* -@all +@read +@hash +@bitmap +@geo -setbit -bitfield -hset -hsetnx -hmset -hincrby -hincrbyfloat -hdel -bitop -geoadd -georadius -georadiusbymember"
  engine        = "REDIS"
  passwords     = ["small"]

  # there will likely be a separate process that handles updates here, so we do not want the changes in this module to
  # overwrite those changes.  we simply want to ensure that all of the possible values exist
  lifecycle {
    ignore_changes = [passwords]
  }
}

References

  • N/A
@scottd018 scottd018 added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 15, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/elasticache Issues and PRs that pertain to the elasticache service. labels Apr 15, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Apr 16, 2022
@github-actions github-actions bot added this to the v4.11.0 milestone Apr 18, 2022
@github-actions
Copy link

This functionality has been released in v4.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service.
Projects
None yet
2 participants