Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/sfn_state_machine: prevent panic when accessing the tracing or logging config of the state machine after update #24302

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Apr 18, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22517

Output from acceptance testing:

--- PASS: TestAccSFNStateMachine_tracing (84.84s)
--- PASS: TestAccSFNStateMachine_createUpdate (89.72s)
--- PASS: TestAccSFNStateMachine_expressUpdate (90.68s)
--- PASS: TestAccSFNStateMachine_tags (90.87s)
--- PASS: TestAccSFNStateMachine_expressLogging (92.57s)
--- PASS: TestAccSFNStateMachine_disappears (94.73s)
--- PASS: TestAccSFNStateMachine_standardUpdate (149.46s)

…ing config of the state machine after update
@github-actions github-actions bot added service/sfn Issues and PRs that pertain to the sfn service. size/XS Managed by automation to categorize the size of a PR. labels Apr 18, 2022
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Apr 18, 2022
@anGie44 anGie44 marked this pull request as ready for review April 18, 2022 21:38
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccSFNStateMachine_ PKG=sfn ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
^[[ATF_ACC=1 go test ./internal/service/sfn/... -v -count 1 -parallel 3 -run='TestAccSFNStateMachine_'  -timeout 180m
=== RUN   TestAccSFNStateMachine_createUpdate
=== PAUSE TestAccSFNStateMachine_createUpdate
=== RUN   TestAccSFNStateMachine_expressUpdate
=== PAUSE TestAccSFNStateMachine_expressUpdate
=== RUN   TestAccSFNStateMachine_standardUpdate
=== PAUSE TestAccSFNStateMachine_standardUpdate
=== RUN   TestAccSFNStateMachine_tags
=== PAUSE TestAccSFNStateMachine_tags
=== RUN   TestAccSFNStateMachine_tracing
=== PAUSE TestAccSFNStateMachine_tracing
=== RUN   TestAccSFNStateMachine_disappears
=== PAUSE TestAccSFNStateMachine_disappears
=== RUN   TestAccSFNStateMachine_expressLogging
=== PAUSE TestAccSFNStateMachine_expressLogging
=== CONT  TestAccSFNStateMachine_createUpdate
=== CONT  TestAccSFNStateMachine_expressLogging
=== CONT  TestAccSFNStateMachine_tags
--- PASS: TestAccSFNStateMachine_createUpdate (91.34s)
=== CONT  TestAccSFNStateMachine_tracing
--- PASS: TestAccSFNStateMachine_tags (92.18s)
=== CONT  TestAccSFNStateMachine_standardUpdate
--- PASS: TestAccSFNStateMachine_expressLogging (94.79s)
=== CONT  TestAccSFNStateMachine_expressUpdate
--- PASS: TestAccSFNStateMachine_tracing (58.29s)
=== CONT  TestAccSFNStateMachine_disappears
--- PASS: TestAccSFNStateMachine_standardUpdate (58.46s)
--- PASS: TestAccSFNStateMachine_expressUpdate (121.11s)
--- PASS: TestAccSFNStateMachine_disappears (71.92s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sfn	225.110s

@anGie44 anGie44 added this to the v4.11.0 milestone Apr 19, 2022
@anGie44 anGie44 merged commit fda6ea2 into main Apr 19, 2022
@anGie44 anGie44 deleted the b-sfn-state-machine-panic branch April 19, 2022 13:19
@github-actions
Copy link

This functionality has been released in v4.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/sfn Issues and PRs that pertain to the sfn service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nil check needed when *updating* aws_sfn_state_machine
2 participants