-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change 5 minute timeout to 60 minute timeout when creating security_group_rules #24340
Change 5 minute timeout to 60 minute timeout when creating security_group_rules #24340
Conversation
The [API docs](https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_CreateSecurityGroup.html) have this to say: > Constraints: Up to 255 characters in length. Cannot start with sg-.
If the security group does not exist output an error with the sg name in message.
They are treated as a set anyway.
With this change, changes it cidr_blocks and ipv6_cidr_blocks will only remove/add the cidr ranges that were removed/added in config, rather than destroying the entire resource and recreating it. It also changes the type of those attributes to sets to make the diffs more readable.
This reverts commit a5f2c9d.
This reverts commit c9544f5.
…s to """ This reverts commit 807d691.
This reverts commit e2fcdf2.
This reverts commit 1a5a1de.
Acceptance test output: % make testacc TESTARGS='-run=TestAccEC2SecurityGroup_name\|TestAccEC2SecurityGroup_basic' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccEC2SecurityGroup_name\|TestAccEC2SecurityGroup_basic -timeout 180m === RUN TestAccEC2SecurityGroup_basic === PAUSE TestAccEC2SecurityGroup_basic === RUN TestAccEC2SecurityGroup_basicEC2Classic === PAUSE TestAccEC2SecurityGroup_basicEC2Classic === RUN TestAccEC2SecurityGroup_nameGenerated === PAUSE TestAccEC2SecurityGroup_nameGenerated === RUN TestAccEC2SecurityGroup_nameTerraformPrefix === PAUSE TestAccEC2SecurityGroup_nameTerraformPrefix === RUN TestAccEC2SecurityGroup_namePrefix === PAUSE TestAccEC2SecurityGroup_namePrefix === RUN TestAccEC2SecurityGroup_namePrefixTerraform === PAUSE TestAccEC2SecurityGroup_namePrefixTerraform === CONT TestAccEC2SecurityGroup_basic === CONT TestAccEC2SecurityGroup_nameTerraformPrefix --- PASS: TestAccEC2SecurityGroup_nameTerraformPrefix (21.73s) === CONT TestAccEC2SecurityGroup_namePrefixTerraform --- PASS: TestAccEC2SecurityGroup_basic (21.90s) === CONT TestAccEC2SecurityGroup_namePrefix --- PASS: TestAccEC2SecurityGroup_namePrefix (20.44s) === CONT TestAccEC2SecurityGroup_nameGenerated --- PASS: TestAccEC2SecurityGroup_namePrefixTerraform (20.92s) === CONT TestAccEC2SecurityGroup_basicEC2Classic --- PASS: TestAccEC2SecurityGroup_basicEC2Classic (12.75s) --- PASS: TestAccEC2SecurityGroup_nameGenerated (20.79s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 66.843s
Acceptance test output: % make testacc TESTS=TestAccEC2SecurityGroup_allowAll PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2SecurityGroup_allowAll' -timeout 180m === RUN TestAccEC2SecurityGroup_allowAll === PAUSE TestAccEC2SecurityGroup_allowAll === CONT TestAccEC2SecurityGroup_allowAll --- PASS: TestAccEC2SecurityGroup_allowAll (24.83s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 28.634s
…Group'. Acceptance test output: % make testacc TESTS=TestAccEC2SecurityGroup_sourceSecurityGroup PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2SecurityGroup_sourceSecurityGroup' -timeout 180m === RUN TestAccEC2SecurityGroup_sourceSecurityGroup === PAUSE TestAccEC2SecurityGroup_sourceSecurityGroup === CONT TestAccEC2SecurityGroup_sourceSecurityGroup --- PASS: TestAccEC2SecurityGroup_sourceSecurityGroup (23.02s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 26.803s
…rityGroupWithSameRules'. Acceptance test output: % make testacc TESTS=TestAccEC2SecurityGroup_ipRangeAndSecurityGroupWithSameRules PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2SecurityGroup_ipRangeAndSecurityGroupWithSameRules' -timeout 180m === RUN TestAccEC2SecurityGroup_ipRangeAndSecurityGroupWithSameRules === PAUSE TestAccEC2SecurityGroup_ipRangeAndSecurityGroupWithSameRules === CONT TestAccEC2SecurityGroup_ipRangeAndSecurityGroupWithSameRules --- PASS: TestAccEC2SecurityGroup_ipRangeAndSecurityGroupWithSameRules (26.71s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 30.458s
…meRules'. Acceptance test output: % make testacc TESTS=TestAccEC2SecurityGroup_ipRangesWithSameRules PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2SecurityGroup_ipRangesWithSameRules' -timeout 180m === RUN TestAccEC2SecurityGroup_ipRangesWithSameRules === PAUSE TestAccEC2SecurityGroup_ipRangesWithSameRules === CONT TestAccEC2SecurityGroup_ipRangesWithSameRules --- PASS: TestAccEC2SecurityGroup_ipRangesWithSameRules (24.28s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 28.137s
…-run=TestAccVPCSecurityGroup_' PKG=ec2 ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3 -run=TestAccVPCSecurityGroup_ -timeout 180m === RUN TestAccVPCSecurityGroup_basic === PAUSE TestAccVPCSecurityGroup_basic === RUN TestAccVPCSecurityGroup_basicEC2Classic === PAUSE TestAccVPCSecurityGroup_basicEC2Classic === RUN TestAccVPCSecurityGroup_disappears === PAUSE TestAccVPCSecurityGroup_disappears === RUN TestAccVPCSecurityGroup_nameGenerated === PAUSE TestAccVPCSecurityGroup_nameGenerated === RUN TestAccVPCSecurityGroup_nameTerraformPrefix === PAUSE TestAccVPCSecurityGroup_nameTerraformPrefix === RUN TestAccVPCSecurityGroup_namePrefix === PAUSE TestAccVPCSecurityGroup_namePrefix === RUN TestAccVPCSecurityGroup_namePrefixTerraform === PAUSE TestAccVPCSecurityGroup_namePrefixTerraform === RUN TestAccVPCSecurityGroup_tags === PAUSE TestAccVPCSecurityGroup_tags === RUN TestAccVPCSecurityGroup_allowAll === PAUSE TestAccVPCSecurityGroup_allowAll === RUN TestAccVPCSecurityGroup_sourceSecurityGroup === PAUSE TestAccVPCSecurityGroup_sourceSecurityGroup === RUN TestAccVPCSecurityGroup_ipRangeAndSecurityGroupWithSameRules === PAUSE TestAccVPCSecurityGroup_ipRangeAndSecurityGroupWithSameRules === RUN TestAccVPCSecurityGroup_ipRangesWithSameRules === PAUSE TestAccVPCSecurityGroup_ipRangesWithSameRules === RUN TestAccVPCSecurityGroup_egressMode === PAUSE TestAccVPCSecurityGroup_egressMode === RUN TestAccVPCSecurityGroup_ingressMode === PAUSE TestAccVPCSecurityGroup_ingressMode === RUN TestAccVPCSecurityGroup_ruleGathering === PAUSE TestAccVPCSecurityGroup_ruleGathering === RUN TestAccVPCSecurityGroup_forceRevokeRulesTrue === PAUSE TestAccVPCSecurityGroup_forceRevokeRulesTrue === RUN TestAccVPCSecurityGroup_forceRevokeRulesFalse === PAUSE TestAccVPCSecurityGroup_forceRevokeRulesFalse === RUN TestAccVPCSecurityGroup_change === PAUSE TestAccVPCSecurityGroup_change === RUN TestAccVPCSecurityGroup_ipv6 === PAUSE TestAccVPCSecurityGroup_ipv6 === RUN TestAccVPCSecurityGroup_self === PAUSE TestAccVPCSecurityGroup_self === RUN TestAccVPCSecurityGroup_vpc === PAUSE TestAccVPCSecurityGroup_vpc === RUN TestAccVPCSecurityGroup_vpcNegOneIngress === PAUSE TestAccVPCSecurityGroup_vpcNegOneIngress === RUN TestAccVPCSecurityGroup_vpcProtoNumIngress === PAUSE TestAccVPCSecurityGroup_vpcProtoNumIngress === RUN TestAccVPCSecurityGroup_multiIngress === PAUSE TestAccVPCSecurityGroup_multiIngress === RUN TestAccVPCSecurityGroup_ruleDescription === PAUSE TestAccVPCSecurityGroup_ruleDescription === RUN TestAccVPCSecurityGroup_defaultEgressVPC === PAUSE TestAccVPCSecurityGroup_defaultEgressVPC === RUN TestAccVPCSecurityGroup_drift === PAUSE TestAccVPCSecurityGroup_drift === RUN TestAccVPCSecurityGroup_driftComplex === PAUSE TestAccVPCSecurityGroup_driftComplex === RUN TestAccVPCSecurityGroup_invalidCIDRBlock === PAUSE TestAccVPCSecurityGroup_invalidCIDRBlock === RUN TestAccVPCSecurityGroup_cidrAndGroups === PAUSE TestAccVPCSecurityGroup_cidrAndGroups === RUN TestAccVPCSecurityGroup_ingressWithCIDRAndSGsVPC === PAUSE TestAccVPCSecurityGroup_ingressWithCIDRAndSGsVPC === RUN TestAccVPCSecurityGroup_ingressWithCIDRAndSGsClassic === PAUSE TestAccVPCSecurityGroup_ingressWithCIDRAndSGsClassic === RUN TestAccVPCSecurityGroup_egressWithPrefixList === PAUSE TestAccVPCSecurityGroup_egressWithPrefixList === RUN TestAccVPCSecurityGroup_ingressWithPrefixList === PAUSE TestAccVPCSecurityGroup_ingressWithPrefixList === RUN TestAccVPCSecurityGroup_ipv4AndIPv6Egress === PAUSE TestAccVPCSecurityGroup_ipv4AndIPv6Egress === RUN TestAccVPCSecurityGroup_failWithDiffMismatch === PAUSE TestAccVPCSecurityGroup_failWithDiffMismatch === RUN TestAccVPCSecurityGroup_ruleLimitExceededAppend === PAUSE TestAccVPCSecurityGroup_ruleLimitExceededAppend === RUN TestAccVPCSecurityGroup_ruleLimitCIDRBlockExceededAppend === PAUSE TestAccVPCSecurityGroup_ruleLimitCIDRBlockExceededAppend === RUN TestAccVPCSecurityGroup_ruleLimitExceededPrepend === PAUSE TestAccVPCSecurityGroup_ruleLimitExceededPrepend === RUN TestAccVPCSecurityGroup_ruleLimitExceededAllNew === PAUSE TestAccVPCSecurityGroup_ruleLimitExceededAllNew === RUN TestAccVPCSecurityGroup_rulesDropOnError === PAUSE TestAccVPCSecurityGroup_rulesDropOnError === CONT TestAccVPCSecurityGroup_basic === CONT TestAccVPCSecurityGroup_ingressWithCIDRAndSGsClassic === CONT TestAccVPCSecurityGroup_vpcNegOneIngress --- PASS: TestAccVPCSecurityGroup_ingressWithCIDRAndSGsClassic (16.85s) === CONT TestAccVPCSecurityGroup_ingressWithCIDRAndSGsVPC --- PASS: TestAccVPCSecurityGroup_vpcNegOneIngress (25.33s) === CONT TestAccVPCSecurityGroup_cidrAndGroups --- PASS: TestAccVPCSecurityGroup_basic (28.81s) === CONT TestAccVPCSecurityGroup_invalidCIDRBlock --- PASS: TestAccVPCSecurityGroup_invalidCIDRBlock (2.46s) === CONT TestAccVPCSecurityGroup_driftComplex --- PASS: TestAccVPCSecurityGroup_ingressWithCIDRAndSGsVPC (28.59s) === CONT TestAccVPCSecurityGroup_drift --- PASS: TestAccVPCSecurityGroup_cidrAndGroups (29.66s) === CONT TestAccVPCSecurityGroup_defaultEgressVPC --- PASS: TestAccVPCSecurityGroup_driftComplex (28.62s) === CONT TestAccVPCSecurityGroup_ruleDescription --- PASS: TestAccVPCSecurityGroup_drift (20.65s) === CONT TestAccVPCSecurityGroup_multiIngress --- PASS: TestAccVPCSecurityGroup_defaultEgressVPC (25.78s) === CONT TestAccVPCSecurityGroup_vpcProtoNumIngress --- PASS: TestAccVPCSecurityGroup_multiIngress (31.34s) === CONT TestAccVPCSecurityGroup_ipv4AndIPv6Egress --- PASS: TestAccVPCSecurityGroup_vpcProtoNumIngress (26.64s) === CONT TestAccVPCSecurityGroup_failWithDiffMismatch --- PASS: TestAccVPCSecurityGroup_ruleDescription (60.02s) === CONT TestAccVPCSecurityGroup_ruleLimitExceededAppend --- PASS: TestAccVPCSecurityGroup_ipv4AndIPv6Egress (36.65s) === CONT TestAccVPCSecurityGroup_ipRangesWithSameRules --- PASS: TestAccVPCSecurityGroup_failWithDiffMismatch (28.51s) === CONT TestAccVPCSecurityGroup_vpc --- PASS: TestAccVPCSecurityGroup_vpc (25.98s) === CONT TestAccVPCSecurityGroup_self --- PASS: TestAccVPCSecurityGroup_ipRangesWithSameRules (29.04s) === CONT TestAccVPCSecurityGroup_ipv6 --- PASS: TestAccVPCSecurityGroup_ruleLimitExceededAppend (55.11s) === CONT TestAccVPCSecurityGroup_change --- PASS: TestAccVPCSecurityGroup_self (24.88s) === CONT TestAccVPCSecurityGroup_forceRevokeRulesFalse --- PASS: TestAccVPCSecurityGroup_ipv6 (25.66s) === CONT TestAccVPCSecurityGroup_forceRevokeRulesTrue --- PASS: TestAccVPCSecurityGroup_change (41.08s) === CONT TestAccVPCSecurityGroup_ruleGathering --- PASS: TestAccVPCSecurityGroup_ruleGathering (37.20s) === CONT TestAccVPCSecurityGroup_ingressMode --- PASS: TestAccVPCSecurityGroup_ingressMode (48.33s) === CONT TestAccVPCSecurityGroup_egressMode --- PASS: TestAccVPCSecurityGroup_egressMode (48.64s) === CONT TestAccVPCSecurityGroup_ruleLimitExceededPrepend --- PASS: TestAccVPCSecurityGroup_ruleLimitExceededPrepend (49.44s) === CONT TestAccVPCSecurityGroup_ruleLimitExceededAllNew --- PASS: TestAccVPCSecurityGroup_ruleLimitExceededAllNew (48.51s) === CONT TestAccVPCSecurityGroup_namePrefixTerraform --- PASS: TestAccVPCSecurityGroup_namePrefixTerraform (22.76s) === CONT TestAccVPCSecurityGroup_ipRangeAndSecurityGroupWithSameRules --- PASS: TestAccVPCSecurityGroup_ipRangeAndSecurityGroupWithSameRules (26.38s) === CONT TestAccVPCSecurityGroup_tags --- PASS: TestAccVPCSecurityGroup_tags (49.67s) === CONT TestAccVPCSecurityGroup_sourceSecurityGroup --- PASS: TestAccVPCSecurityGroup_sourceSecurityGroup (24.44s) === CONT TestAccVPCSecurityGroup_ingressWithPrefixList --- PASS: TestAccVPCSecurityGroup_ingressWithPrefixList (37.17s) === CONT TestAccVPCSecurityGroup_egressWithPrefixList --- PASS: TestAccVPCSecurityGroup_egressWithPrefixList (36.89s) === CONT TestAccVPCSecurityGroup_ruleLimitCIDRBlockExceededAppend --- PASS: TestAccVPCSecurityGroup_ruleLimitCIDRBlockExceededAppend (38.34s) === CONT TestAccVPCSecurityGroup_allowAll --- PASS: TestAccVPCSecurityGroup_allowAll (25.48s) === CONT TestAccVPCSecurityGroup_nameGenerated --- PASS: TestAccVPCSecurityGroup_nameGenerated (21.74s) === CONT TestAccVPCSecurityGroup_namePrefix --- PASS: TestAccVPCSecurityGroup_namePrefix (21.96s) === CONT TestAccVPCSecurityGroup_nameTerraformPrefix --- PASS: TestAccVPCSecurityGroup_nameTerraformPrefix (24.10s) === CONT TestAccVPCSecurityGroup_disappears --- PASS: TestAccVPCSecurityGroup_disappears (19.44s) === CONT TestAccVPCSecurityGroup_basicEC2Classic --- PASS: TestAccVPCSecurityGroup_basicEC2Classic (12.70s) === CONT TestAccVPCSecurityGroup_rulesDropOnError --- PASS: TestAccVPCSecurityGroup_rulesDropOnError (42.90s) --- PASS: TestAccVPCSecurityGroup_forceRevokeRulesFalse (958.56s) --- PASS: TestAccVPCSecurityGroup_forceRevokeRulesTrue (991.82s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 1185.611s
…xed with 'sg-'. Acceptance test output: % EC2_SECURITY_GROUP_RULES_PER_GROUP_LIMIT=60 make testacc TESTARGS='-run=TestAccVPCSecurityGroup_basic\|TestAccVPCSecurityGroup_name' PKG=ec2 ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3 -run=TestAccVPCSecurityGroup_basic\|TestAccVPCSecurityGroup_name -timeout 180m === RUN TestAccVPCSecurityGroup_basic === PAUSE TestAccVPCSecurityGroup_basic === RUN TestAccVPCSecurityGroup_basicEC2Classic === PAUSE TestAccVPCSecurityGroup_basicEC2Classic === RUN TestAccVPCSecurityGroup_nameGenerated === PAUSE TestAccVPCSecurityGroup_nameGenerated === RUN TestAccVPCSecurityGroup_nameTerraformPrefix === PAUSE TestAccVPCSecurityGroup_nameTerraformPrefix === RUN TestAccVPCSecurityGroup_namePrefix === PAUSE TestAccVPCSecurityGroup_namePrefix === RUN TestAccVPCSecurityGroup_namePrefixTerraform === PAUSE TestAccVPCSecurityGroup_namePrefixTerraform === CONT TestAccVPCSecurityGroup_basic === CONT TestAccVPCSecurityGroup_nameTerraformPrefix === CONT TestAccVPCSecurityGroup_nameGenerated --- PASS: TestAccVPCSecurityGroup_basic (37.02s) === CONT TestAccVPCSecurityGroup_basicEC2Classic --- PASS: TestAccVPCSecurityGroup_nameGenerated (37.57s) === CONT TestAccVPCSecurityGroup_namePrefixTerraform --- PASS: TestAccVPCSecurityGroup_nameTerraformPrefix (37.76s) === CONT TestAccVPCSecurityGroup_namePrefix --- PASS: TestAccVPCSecurityGroup_basicEC2Classic (34.82s) --- PASS: TestAccVPCSecurityGroup_namePrefix (39.35s) --- PASS: TestAccVPCSecurityGroup_namePrefixTerraform (40.42s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 93.314s
Acceptance test output: % make testacc TESTARGS='-run=TestAccVPCSecurityGroupRule_Ingress_vpc' PKG=ec2 ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3 -run=TestAccVPCSecurityGroupRule_Ingress_vpc -timeout 180m === RUN TestAccVPCSecurityGroupRule_Ingress_vpc === PAUSE TestAccVPCSecurityGroupRule_Ingress_vpc === CONT TestAccVPCSecurityGroupRule_Ingress_vpc --- PASS: TestAccVPCSecurityGroupRule_Ingress_vpc (21.11s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 25.615s
…curity_group_rules" This reverts commit d484384.
…ecurity_group(_rule)-refactor
This reverts commit 5d5e1ea.
…ecurity_group(_rule)-refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% EC2_SECURITY_GROUP_RULES_PER_GROUP_LIMIT=60 make testacc TESTARGS='-run=TestAccVPCDefaultSecurityGroup_\|TestAccVPCSecurityGroup' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3 -run=TestAccVPCDefaultSecurityGroup_\|TestAccVPCSecurityGroup -timeout 180m
=== RUN TestAccVPCDefaultSecurityGroup_VPC_basic
=== PAUSE TestAccVPCDefaultSecurityGroup_VPC_basic
=== RUN TestAccVPCDefaultSecurityGroup_VPC_empty
=== PAUSE TestAccVPCDefaultSecurityGroup_VPC_empty
=== RUN TestAccVPCDefaultSecurityGroup_Classic_serial
=== RUN TestAccVPCDefaultSecurityGroup_Classic_serial/basic
=== RUN TestAccVPCDefaultSecurityGroup_Classic_serial/empty
--- PASS: TestAccVPCDefaultSecurityGroup_Classic_serial (31.49s)
--- PASS: TestAccVPCDefaultSecurityGroup_Classic_serial/basic (20.76s)
--- PASS: TestAccVPCDefaultSecurityGroup_Classic_serial/empty (10.73s)
=== RUN TestAccVPCSecurityGroupDataSource_basic
=== PAUSE TestAccVPCSecurityGroupDataSource_basic
=== RUN TestAccVPCSecurityGroupRule_Ingress_vpc
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_vpc
=== RUN TestAccVPCSecurityGroupRule_IngressSourceWithAccount_id
=== PAUSE TestAccVPCSecurityGroupRule_IngressSourceWithAccount_id
=== RUN TestAccVPCSecurityGroupRule_Ingress_protocol
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_protocol
=== RUN TestAccVPCSecurityGroupRule_Ingress_icmpv6
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_icmpv6
=== RUN TestAccVPCSecurityGroupRule_Ingress_ipv6
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_ipv6
=== RUN TestAccVPCSecurityGroupRule_Ingress_classic
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_classic
=== RUN TestAccVPCSecurityGroupRule_egress
=== PAUSE TestAccVPCSecurityGroupRule_egress
=== RUN TestAccVPCSecurityGroupRule_selfReference
=== PAUSE TestAccVPCSecurityGroupRule_selfReference
=== RUN TestAccVPCSecurityGroupRule_expectInvalidTypeError
=== PAUSE TestAccVPCSecurityGroupRule_expectInvalidTypeError
=== RUN TestAccVPCSecurityGroupRule_expectInvalidCIDR
=== PAUSE TestAccVPCSecurityGroupRule_expectInvalidCIDR
=== RUN TestAccVPCSecurityGroupRule_PartialMatching_basic
=== PAUSE TestAccVPCSecurityGroupRule_PartialMatching_basic
=== RUN TestAccVPCSecurityGroupRule_PartialMatching_source
=== PAUSE TestAccVPCSecurityGroupRule_PartialMatching_source
=== RUN TestAccVPCSecurityGroupRule_issue5310
=== PAUSE TestAccVPCSecurityGroupRule_issue5310
=== RUN TestAccVPCSecurityGroupRule_race
=== PAUSE TestAccVPCSecurityGroupRule_race
=== RUN TestAccVPCSecurityGroupRule_selfSource
=== PAUSE TestAccVPCSecurityGroupRule_selfSource
=== RUN TestAccVPCSecurityGroupRule_prefixListEgress
=== PAUSE TestAccVPCSecurityGroupRule_prefixListEgress
=== RUN TestAccVPCSecurityGroupRule_ingressDescription
=== PAUSE TestAccVPCSecurityGroupRule_ingressDescription
=== RUN TestAccVPCSecurityGroupRule_egressDescription
=== PAUSE TestAccVPCSecurityGroupRule_egressDescription
=== RUN TestAccVPCSecurityGroupRule_IngressDescription_updates
=== PAUSE TestAccVPCSecurityGroupRule_IngressDescription_updates
=== RUN TestAccVPCSecurityGroupRule_EgressDescription_updates
=== PAUSE TestAccVPCSecurityGroupRule_EgressDescription_updates
=== RUN TestAccVPCSecurityGroupRule_Description_allPorts
=== PAUSE TestAccVPCSecurityGroupRule_Description_allPorts
=== RUN TestAccVPCSecurityGroupRule_DescriptionAllPorts_nonZeroPorts
=== PAUSE TestAccVPCSecurityGroupRule_DescriptionAllPorts_nonZeroPorts
=== RUN TestAccVPCSecurityGroupRule_MultipleRuleSearching_allProtocolCrash
=== PAUSE TestAccVPCSecurityGroupRule_MultipleRuleSearching_allProtocolCrash
=== RUN TestAccVPCSecurityGroupRule_multiDescription
=== PAUSE TestAccVPCSecurityGroupRule_multiDescription
=== RUN TestAccVPCSecurityGroupRule_Ingress_multipleIPv6
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_multipleIPv6
=== RUN TestAccVPCSecurityGroupRule_Ingress_multiplePrefixLists
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_multiplePrefixLists
=== RUN TestAccVPCSecurityGroupRule_Ingress_peeredVPC
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_peeredVPC
=== RUN TestAccVPCSecurityGroupRule_Ingress_ipv4AndIPv6
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_ipv4AndIPv6
=== RUN TestAccVPCSecurityGroupRule_Ingress_prefixListAndSelf
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_prefixListAndSelf
=== RUN TestAccVPCSecurityGroupRule_Ingress_prefixListAndSource
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_prefixListAndSource
=== RUN TestAccVPCSecurityGroup_basic
=== PAUSE TestAccVPCSecurityGroup_basic
=== RUN TestAccVPCSecurityGroup_basicEC2Classic
=== PAUSE TestAccVPCSecurityGroup_basicEC2Classic
=== RUN TestAccVPCSecurityGroup_disappears
=== PAUSE TestAccVPCSecurityGroup_disappears
=== RUN TestAccVPCSecurityGroup_nameGenerated
=== PAUSE TestAccVPCSecurityGroup_nameGenerated
=== RUN TestAccVPCSecurityGroup_nameTerraformPrefix
=== PAUSE TestAccVPCSecurityGroup_nameTerraformPrefix
=== RUN TestAccVPCSecurityGroup_namePrefix
=== PAUSE TestAccVPCSecurityGroup_namePrefix
=== RUN TestAccVPCSecurityGroup_namePrefixTerraform
=== PAUSE TestAccVPCSecurityGroup_namePrefixTerraform
=== RUN TestAccVPCSecurityGroup_tags
=== PAUSE TestAccVPCSecurityGroup_tags
=== RUN TestAccVPCSecurityGroup_allowAll
=== PAUSE TestAccVPCSecurityGroup_allowAll
=== RUN TestAccVPCSecurityGroup_sourceSecurityGroup
=== PAUSE TestAccVPCSecurityGroup_sourceSecurityGroup
=== RUN TestAccVPCSecurityGroup_ipRangeAndSecurityGroupWithSameRules
=== PAUSE TestAccVPCSecurityGroup_ipRangeAndSecurityGroupWithSameRules
=== RUN TestAccVPCSecurityGroup_ipRangesWithSameRules
=== PAUSE TestAccVPCSecurityGroup_ipRangesWithSameRules
=== RUN TestAccVPCSecurityGroup_egressMode
=== PAUSE TestAccVPCSecurityGroup_egressMode
=== RUN TestAccVPCSecurityGroup_ingressMode
=== PAUSE TestAccVPCSecurityGroup_ingressMode
=== RUN TestAccVPCSecurityGroup_ruleGathering
=== PAUSE TestAccVPCSecurityGroup_ruleGathering
=== RUN TestAccVPCSecurityGroup_forceRevokeRulesTrue
=== PAUSE TestAccVPCSecurityGroup_forceRevokeRulesTrue
=== RUN TestAccVPCSecurityGroup_forceRevokeRulesFalse
=== PAUSE TestAccVPCSecurityGroup_forceRevokeRulesFalse
=== RUN TestAccVPCSecurityGroup_change
=== PAUSE TestAccVPCSecurityGroup_change
=== RUN TestAccVPCSecurityGroup_ipv6
=== PAUSE TestAccVPCSecurityGroup_ipv6
=== RUN TestAccVPCSecurityGroup_self
=== PAUSE TestAccVPCSecurityGroup_self
=== RUN TestAccVPCSecurityGroup_vpc
=== PAUSE TestAccVPCSecurityGroup_vpc
=== RUN TestAccVPCSecurityGroup_vpcNegOneIngress
=== PAUSE TestAccVPCSecurityGroup_vpcNegOneIngress
=== RUN TestAccVPCSecurityGroup_vpcProtoNumIngress
=== PAUSE TestAccVPCSecurityGroup_vpcProtoNumIngress
=== RUN TestAccVPCSecurityGroup_multiIngress
=== PAUSE TestAccVPCSecurityGroup_multiIngress
=== RUN TestAccVPCSecurityGroup_ruleDescription
=== PAUSE TestAccVPCSecurityGroup_ruleDescription
=== RUN TestAccVPCSecurityGroup_defaultEgressVPC
=== PAUSE TestAccVPCSecurityGroup_defaultEgressVPC
=== RUN TestAccVPCSecurityGroup_drift
=== PAUSE TestAccVPCSecurityGroup_drift
=== RUN TestAccVPCSecurityGroup_driftComplex
=== PAUSE TestAccVPCSecurityGroup_driftComplex
=== RUN TestAccVPCSecurityGroup_invalidCIDRBlock
=== PAUSE TestAccVPCSecurityGroup_invalidCIDRBlock
=== RUN TestAccVPCSecurityGroup_cidrAndGroups
=== PAUSE TestAccVPCSecurityGroup_cidrAndGroups
=== RUN TestAccVPCSecurityGroup_ingressWithCIDRAndSGsVPC
=== PAUSE TestAccVPCSecurityGroup_ingressWithCIDRAndSGsVPC
=== RUN TestAccVPCSecurityGroup_ingressWithCIDRAndSGsClassic
=== PAUSE TestAccVPCSecurityGroup_ingressWithCIDRAndSGsClassic
=== RUN TestAccVPCSecurityGroup_egressWithPrefixList
=== PAUSE TestAccVPCSecurityGroup_egressWithPrefixList
=== RUN TestAccVPCSecurityGroup_ingressWithPrefixList
=== PAUSE TestAccVPCSecurityGroup_ingressWithPrefixList
=== RUN TestAccVPCSecurityGroup_ipv4AndIPv6Egress
=== PAUSE TestAccVPCSecurityGroup_ipv4AndIPv6Egress
=== RUN TestAccVPCSecurityGroup_failWithDiffMismatch
=== PAUSE TestAccVPCSecurityGroup_failWithDiffMismatch
=== RUN TestAccVPCSecurityGroup_ruleLimitExceededAppend
=== PAUSE TestAccVPCSecurityGroup_ruleLimitExceededAppend
=== RUN TestAccVPCSecurityGroup_ruleLimitCIDRBlockExceededAppend
=== PAUSE TestAccVPCSecurityGroup_ruleLimitCIDRBlockExceededAppend
=== RUN TestAccVPCSecurityGroup_ruleLimitExceededPrepend
=== PAUSE TestAccVPCSecurityGroup_ruleLimitExceededPrepend
=== RUN TestAccVPCSecurityGroup_ruleLimitExceededAllNew
=== PAUSE TestAccVPCSecurityGroup_ruleLimitExceededAllNew
=== RUN TestAccVPCSecurityGroup_rulesDropOnError
=== PAUSE TestAccVPCSecurityGroup_rulesDropOnError
=== RUN TestAccVPCSecurityGroupsDataSource_tag
=== PAUSE TestAccVPCSecurityGroupsDataSource_tag
=== RUN TestAccVPCSecurityGroupsDataSource_filter
=== PAUSE TestAccVPCSecurityGroupsDataSource_filter
=== RUN TestAccVPCSecurityGroupsDataSource_empty
=== PAUSE TestAccVPCSecurityGroupsDataSource_empty
=== CONT TestAccVPCDefaultSecurityGroup_VPC_basic
=== CONT TestAccVPCSecurityGroup_namePrefixTerraform
=== CONT TestAccVPCSecurityGroupsDataSource_empty
--- PASS: TestAccVPCSecurityGroupsDataSource_empty (13.53s)
=== CONT TestAccVPCSecurityGroupsDataSource_filter
--- PASS: TestAccVPCSecurityGroup_namePrefixTerraform (27.38s)
=== CONT TestAccVPCSecurityGroupsDataSource_tag
--- PASS: TestAccVPCDefaultSecurityGroup_VPC_basic (36.05s)
=== CONT TestAccVPCSecurityGroup_rulesDropOnError
--- PASS: TestAccVPCSecurityGroupsDataSource_filter (22.85s)
=== CONT TestAccVPCSecurityGroup_ruleLimitExceededAllNew
--- PASS: TestAccVPCSecurityGroupsDataSource_tag (24.66s)
=== CONT TestAccVPCSecurityGroup_ruleLimitExceededPrepend
--- PASS: TestAccVPCSecurityGroup_rulesDropOnError (51.70s)
=== CONT TestAccVPCSecurityGroup_ruleLimitCIDRBlockExceededAppend
--- PASS: TestAccVPCSecurityGroup_ruleLimitExceededAllNew (64.76s)
=== CONT TestAccVPCSecurityGroup_ruleLimitExceededAppend
--- PASS: TestAccVPCSecurityGroup_ruleLimitExceededPrepend (65.82s)
=== CONT TestAccVPCSecurityGroup_failWithDiffMismatch
--- PASS: TestAccVPCSecurityGroup_ruleLimitCIDRBlockExceededAppend (51.20s)
=== CONT TestAccVPCSecurityGroup_ipv4AndIPv6Egress
--- PASS: TestAccVPCSecurityGroup_failWithDiffMismatch (30.04s)
=== CONT TestAccVPCSecurityGroup_ingressWithPrefixList
--- PASS: TestAccVPCSecurityGroup_ruleLimitExceededAppend (58.39s)
=== CONT TestAccVPCSecurityGroup_egressWithPrefixList
--- PASS: TestAccVPCSecurityGroup_ipv4AndIPv6Egress (34.31s)
=== CONT TestAccVPCSecurityGroup_ingressWithCIDRAndSGsClassic
--- PASS: TestAccVPCSecurityGroup_ingressWithPrefixList (40.52s)
=== CONT TestAccVPCSecurityGroup_ingressWithCIDRAndSGsVPC
--- PASS: TestAccVPCSecurityGroup_ingressWithCIDRAndSGsClassic (20.56s)
=== CONT TestAccVPCSecurityGroup_cidrAndGroups
--- PASS: TestAccVPCSecurityGroup_egressWithPrefixList (42.05s)
=== CONT TestAccVPCSecurityGroup_invalidCIDRBlock
--- PASS: TestAccVPCSecurityGroup_invalidCIDRBlock (2.43s)
=== CONT TestAccVPCSecurityGroup_driftComplex
--- PASS: TestAccVPCSecurityGroup_ingressWithCIDRAndSGsVPC (30.07s)
=== CONT TestAccVPCSecurityGroup_drift
--- PASS: TestAccVPCSecurityGroup_cidrAndGroups (30.63s)
=== CONT TestAccVPCSecurityGroupRule_egressDescription
--- PASS: TestAccVPCSecurityGroup_driftComplex (32.65s)
=== CONT TestAccVPCSecurityGroup_namePrefix
--- PASS: TestAccVPCSecurityGroup_drift (23.18s)
=== CONT TestAccVPCSecurityGroup_nameTerraformPrefix
--- PASS: TestAccVPCSecurityGroupRule_egressDescription (25.90s)
=== CONT TestAccVPCSecurityGroup_defaultEgressVPC
--- PASS: TestAccVPCSecurityGroup_namePrefix (30.37s)
=== CONT TestAccVPCSecurityGroup_nameGenerated
--- PASS: TestAccVPCSecurityGroup_nameTerraformPrefix (28.99s)
=== CONT TestAccVPCSecurityGroup_ruleDescription
--- PASS: TestAccVPCSecurityGroup_defaultEgressVPC (28.23s)
=== CONT TestAccVPCSecurityGroup_disappears
--- PASS: TestAccVPCSecurityGroup_nameGenerated (25.61s)
=== CONT TestAccVPCSecurityGroup_multiIngress
--- PASS: TestAccVPCSecurityGroup_disappears (20.61s)
=== CONT TestAccVPCSecurityGroup_vpcProtoNumIngress
--- PASS: TestAccVPCSecurityGroup_vpcProtoNumIngress (24.80s)
=== CONT TestAccVPCSecurityGroup_basicEC2Classic
--- PASS: TestAccVPCSecurityGroup_multiIngress (33.27s)
=== CONT TestAccVPCSecurityGroup_vpcNegOneIngress
--- PASS: TestAccVPCSecurityGroup_ruleDescription (60.13s)
=== CONT TestAccVPCSecurityGroup_basic
--- PASS: TestAccVPCSecurityGroup_basicEC2Classic (17.85s)
=== CONT TestAccVPCSecurityGroupRule_multiDescription
--- PASS: TestAccVPCSecurityGroup_vpcNegOneIngress (28.25s)
=== CONT TestAccVPCSecurityGroupRule_MultipleRuleSearching_allProtocolCrash
--- PASS: TestAccVPCSecurityGroup_basic (27.37s)
=== CONT TestAccVPCSecurityGroupRule_DescriptionAllPorts_nonZeroPorts
--- PASS: TestAccVPCSecurityGroupRule_MultipleRuleSearching_allProtocolCrash (26.20s)
=== CONT TestAccVPCSecurityGroup_vpc
--- PASS: TestAccVPCSecurityGroupRule_DescriptionAllPorts_nonZeroPorts (37.31s)
=== CONT TestAccVPCSecurityGroup_self
--- PASS: TestAccVPCSecurityGroup_vpc (25.74s)
=== CONT TestAccVPCSecurityGroupRule_Ingress_multipleIPv6
--- PASS: TestAccVPCSecurityGroup_self (26.47s)
=== CONT TestAccVPCSecurityGroup_ipv6
--- PASS: TestAccVPCSecurityGroupRule_multiDescription (81.52s)
=== CONT TestAccVPCSecurityGroup_change
--- PASS: TestAccVPCSecurityGroupRule_Ingress_multipleIPv6 (27.72s)
=== CONT TestAccVPCSecurityGroupRule_Ingress_prefixListAndSource
--- PASS: TestAccVPCSecurityGroup_ipv6 (26.78s)
=== CONT TestAccVPCSecurityGroup_forceRevokeRulesFalse
--- PASS: TestAccVPCSecurityGroup_change (41.67s)
=== CONT TestAccVPCSecurityGroupRule_Ingress_prefixListAndSelf
--- PASS: TestAccVPCSecurityGroupRule_Ingress_prefixListAndSource (33.17s)
=== CONT TestAccVPCSecurityGroupRule_Ingress_ipv4AndIPv6
--- PASS: TestAccVPCSecurityGroupRule_Ingress_ipv4AndIPv6 (30.36s)
=== CONT TestAccVPCSecurityGroupRule_Ingress_peeredVPC
acctest.go:620: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccVPCSecurityGroupRule_Ingress_peeredVPC (0.06s)
=== CONT TestAccVPCSecurityGroup_forceRevokeRulesTrue
--- PASS: TestAccVPCSecurityGroupRule_Ingress_prefixListAndSelf (37.39s)
=== CONT TestAccVPCSecurityGroupRule_Ingress_multiplePrefixLists
--- PASS: TestAccVPCSecurityGroupRule_Ingress_multiplePrefixLists (36.67s)
=== CONT TestAccVPCSecurityGroup_ruleGathering
--- PASS: TestAccVPCSecurityGroup_ruleGathering (45.30s)
=== CONT TestAccVPCSecurityGroup_ingressMode
--- PASS: TestAccVPCSecurityGroup_ingressMode (65.00s)
=== CONT TestAccVPCSecurityGroupRule_EgressDescription_updates
--- PASS: TestAccVPCSecurityGroupRule_EgressDescription_updates (43.59s)
=== CONT TestAccVPCSecurityGroupRule_IngressDescription_updates
--- PASS: TestAccVPCSecurityGroupRule_IngressDescription_updates (45.30s)
=== CONT TestAccVPCSecurityGroup_egressMode
--- PASS: TestAccVPCSecurityGroup_egressMode (68.36s)
=== CONT TestAccVPCSecurityGroup_ipRangesWithSameRules
--- PASS: TestAccVPCSecurityGroup_ipRangesWithSameRules (34.77s)
=== CONT TestAccVPCSecurityGroupRule_Description_allPorts
--- PASS: TestAccVPCSecurityGroupRule_Description_allPorts (50.37s)
=== CONT TestAccVPCSecurityGroupRule_selfReference
--- PASS: TestAccVPCSecurityGroupRule_selfReference (35.87s)
=== CONT TestAccVPCSecurityGroupRule_ingressDescription
--- PASS: TestAccVPCSecurityGroupRule_ingressDescription (29.43s)
=== CONT TestAccVPCSecurityGroup_ipRangeAndSecurityGroupWithSameRules
--- PASS: TestAccVPCSecurityGroup_ipRangeAndSecurityGroupWithSameRules (37.40s)
=== CONT TestAccVPCSecurityGroupRule_prefixListEgress
--- PASS: TestAccVPCSecurityGroupRule_prefixListEgress (41.62s)
=== CONT TestAccVPCSecurityGroupRule_selfSource
--- PASS: TestAccVPCSecurityGroupRule_selfSource (32.11s)
=== CONT TestAccVPCSecurityGroupRule_race
--- PASS: TestAccVPCSecurityGroupRule_race (172.01s)
=== CONT TestAccVPCSecurityGroup_sourceSecurityGroup
--- PASS: TestAccVPCSecurityGroup_sourceSecurityGroup (30.34s)
=== CONT TestAccVPCSecurityGroup_tags
--- PASS: TestAccVPCSecurityGroup_tags (68.56s)
=== CONT TestAccVPCSecurityGroupRule_Ingress_protocol
--- PASS: TestAccVPCSecurityGroupRule_Ingress_protocol (35.06s)
=== CONT TestAccVPCSecurityGroupRule_issue5310
--- PASS: TestAccVPCSecurityGroupRule_issue5310 (25.57s)
=== CONT TestAccVPCSecurityGroupRule_egress
--- PASS: TestAccVPCSecurityGroup_forceRevokeRulesFalse (971.75s)
=== CONT TestAccVPCSecurityGroupRule_PartialMatching_source
--- PASS: TestAccVPCSecurityGroupRule_egress (27.32s)
=== CONT TestAccVPCSecurityGroupRule_Ingress_classic
--- PASS: TestAccVPCSecurityGroupRule_Ingress_classic (22.49s)
=== CONT TestAccVPCSecurityGroupRule_PartialMatching_basic
--- PASS: TestAccVPCSecurityGroupRule_PartialMatching_source (35.38s)
=== CONT TestAccVPCSecurityGroupRule_Ingress_ipv6
--- PASS: TestAccVPCSecurityGroupRule_Ingress_ipv6 (34.12s)
=== CONT TestAccVPCSecurityGroup_allowAll
--- PASS: TestAccVPCSecurityGroupRule_PartialMatching_basic (41.28s)
=== CONT TestAccVPCSecurityGroupRule_Ingress_icmpv6
--- PASS: TestAccVPCSecurityGroup_forceRevokeRulesTrue (1015.06s)
=== CONT TestAccVPCSecurityGroupRule_expectInvalidTypeError
--- PASS: TestAccVPCSecurityGroupRule_expectInvalidTypeError (1.57s)
=== CONT TestAccVPCSecurityGroupRule_expectInvalidCIDR
--- PASS: TestAccVPCSecurityGroupRule_expectInvalidCIDR (2.65s)
=== CONT TestAccVPCSecurityGroupRule_Ingress_vpc
=== CONT TestAccVPCSecurityGroupDataSource_basic
--- PASS: TestAccVPCSecurityGroupRule_Ingress_icmpv6 (33.48s)
--- PASS: TestAccVPCSecurityGroup_allowAll (34.44s)
=== CONT TestAccVPCDefaultSecurityGroup_VPC_empty
--- PASS: TestAccVPCSecurityGroupRule_Ingress_vpc (28.14s)
=== CONT TestAccVPCSecurityGroupRule_IngressSourceWithAccount_id
--- PASS: TestAccVPCDefaultSecurityGroup_VPC_empty (28.30s)
--- PASS: TestAccVPCSecurityGroupDataSource_basic (28.67s)
--- PASS: TestAccVPCSecurityGroupRule_IngressSourceWithAccount_id (26.47s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 1615.318s
% make testacc TESTARGS='-run=TestAccVPCSecurityGroupRule_Ingress_peeredVPC' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccVPCSecurityGroupRule_Ingress_peeredVPC -timeout 180m
=== RUN TestAccVPCSecurityGroupRule_Ingress_peeredVPC
=== PAUSE TestAccVPCSecurityGroupRule_Ingress_peeredVPC
=== CONT TestAccVPCSecurityGroupRule_Ingress_peeredVPC
--- PASS: TestAccVPCSecurityGroupRule_Ingress_peeredVPC (30.63s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 34.801s
% make providerlint golangci-lint
==> Checking source code with providerlint...
==> Checking source code with golangci-lint... |
@ianblenke Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Adds custom timeouts for the
aws_security_group_rule
resource, with a default of 5 minutes.Closes #14631.