Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update validation pattern for aws_ses_receipt_filter.name #24383

Merged
merged 4 commits into from
Apr 25, 2022
Merged

Update validation pattern for aws_ses_receipt_filter.name #24383

merged 4 commits into from
Apr 25, 2022

Conversation

Nnachevvv
Copy link
Contributor

@Nnachevvv Nnachevvv commented Apr 24, 2022 •
edited by ewbankkit
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24378.
Add dot in validation regex for name in aws_ses_receipt_filter resource

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/ses Issues and PRs that pertain to the ses service. needs-triage Waiting for first response or review from a maintainer. labels Apr 24, 2022
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 25, 2022
@ewbankkit
Copy link
Contributor

Although the AWS API documentation says:

The name of the IP address filter. The name must meet the following requirements:

  • Contain only ASCII letters (a-z, A-Z), numbers (0-9), underscores (_), or dashes (-).
  • Start and end with a letter or number.
  • Contain 64 characters or fewer.

the Console allows names containing periods:

Screen Shot 2022-04-25 at 8 15 35 AM

ewbankkit
ewbankkit approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@Nnachevvv Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit c43a304 into hashicorp:main Apr 25, 2022
@github-actions github-actions bot added this to the v4.12.0 milestone Apr 25, 2022
@github-actions
Copy link

This functionality has been released in v4.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/ses Issues and PRs that pertain to the ses service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.12.0
Development

Successfully merging this pull request may close these issues.

Update validation pattern for aws_ses_receipt_filter.name
2 participants
@Nnachevvv @ewbankkit