r/aws_cloudformation_stack_set_instance: Empty OU refactor #24523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code tried to add deployment target support by finding an account in one of the targets, and then using all the same code as account stack set instances. This is deficient: - If none of the targets contain an account the code fails, due to the resource Id not having an accountID value. - It does not expose information like account IDs and stack set IDs for any accounts in the deployment targets, except the arbitrary accoun it used. - It can cause the resource Id to needlessly drift due to the account selection process changing (account moved OU's, or the API decided to return things in a different order, etc). This refactor treats deployment targets as their own branch of the logic, with their own new attributes.
…n_stack_set_instance-empty-ou-refactor
github-actions
bot
added
service/cloudformation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome @sbutler 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
justinretzolk
added
bug
github-actions
bot
added
size/L
|
Any chance to resolve this issue? It has been open almost year ago |
|
Who can merge that fix? |
…yments - persist list of organizational unit ids in the resource identifier, allowing for consistent read operations and better import support - force a new resource when deployment_targets change to ensure changes to stack sets across multiple organizational units are handled correctly - track full list of account IDs and stack IDs deployed when stack set instances are created for an organizational unit - prevent failures when deploying to an empty organizational unit
… deployments - add CheckExists and CheckDestroy handlers tailored to handle resources where organizational unit ids are stored in the ID - add test deploying to an empty organizational unit
…_summaries attribute
github-actions
bot
added
documentation
jar-b
changed the title
…tidy import section
specifically mentioning failures related to OUs with no accounts
jar-b
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
LGTM 🎉
$ make testacc PKG=cloudformation TESTS=TestAccCloudFormationStackSetInstance_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudformation/... -v -count 1 -parallel 20 -run='TestAccCloudFormationStackSetInstance_' -timeout 180m
=== NAME TestAccCloudFormationStackSetInstance_operationPreferences
acctest.go:951: this AWS account must be the management account of an AWS Organization
--- SKIP: TestAccCloudFormationStackSetInstance_operationPreferences (0.58s)
=== NAME TestAccCloudFormationStackSetInstance_DeploymentTargets_emptyOU
acctest.go:951: this AWS account must be the management account of an AWS Organization
--- SKIP: TestAccCloudFormationStackSetInstance_DeploymentTargets_emptyOU (0.58s)
=== NAME TestAccCloudFormationStackSetInstance_deploymentTargets
acctest.go:951: this AWS account must be the management account of an AWS Organization
--- SKIP: TestAccCloudFormationStackSetInstance_deploymentTargets (0.58s)
--- PASS: TestAccCloudFormationStackSetInstance_disappears (66.63s)
--- PASS: TestAccCloudFormationStackSetInstance_Disappears_stackSet (68.75s)
--- PASS: TestAccCloudFormationStackSetInstance_basic (72.35s)
--- PASS: TestAccCloudFormationStackSetInstance_retainStack (132.25s)
--- PASS: TestAccCloudFormationStackSetInstance_parameterOverrides (134.60s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation 137.843sFrom an organizations management account:
$ make testacc PKG=cloudformation TESTS="TestAccCloudFormationStackSetInstance_DeploymentTargets_emptyOU|TestAccCloudFormationStackSetInstance_deploymentTargets|TestAccCloudFormationStackSetInstance_operationPreferences"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudformation/... -v -count 1 -parallel 20 -run='TestAccCloudFormationStackSetInstance_DeploymentTargets_emptyOU|TestAccCloudFormationStackSetInstance_deploymentTargets|TestAccCloudFormationStackSetInstance_operationPreferences' -timeout 180m
--- PASS: TestAccCloudFormationStackSetInstance_operationPreferences (57.70s)
--- PASS: TestAccCloudFormationStackSetInstance_deploymentTargets (68.51s)
--- PASS: TestAccCloudFormationStackSetInstance_DeploymentTargets_emptyOU (74.15s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation 77.362
|
Thanks for your contribution, @sbutler! 👏 |
|
This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
The original code tried to add deployment target support by finding an account in one of the targets, and then using all the same code as account stack set instances. This is deficient:
This refactor treats deployment targets as their own branch of the logic, with their own new attributes.
Relations
Closes #23349
The added
ForceNewdirective for thedeployment_targetsargument relates to (and possibly resolves):Relates #27877
Relates #25253
Output from Acceptance Testing
WIP due to not being familiar enough with Go to add additional tests for this change.
Output from acceptance testing: