Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_ecr_image: Add image URI attribute #24526

Merged

Conversation

weaversam8
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13671.

  • Adds image_uri attribute to aws_ecr_image datasource.
    • The image URI will point to the version of the image specified by the image_tag or image_digest argument.
    • The URI generated will always be of the form {RepositoryUri}@{ImageDigest}, even if a tag is provided, since a URI with the digest is the canonical URI and is functionally equivalent to {RepositoryUri}@{ImageTag} at the time the tag is provided.
  • Updates TestAccECRImageDataSource_ecrImage acceptance test
  • Updates aws_ecr_image documentation

Output from acceptance testing:

$ make testacc TESTS=TestAccECRImageDataSource_ecrImage PKG=ecr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20 -run='TestAccECRImageDataSource_ecrImage'  -timeout 180m
=== RUN   TestAccECRImageDataSource_ecrImage
=== PAUSE TestAccECRImageDataSource_ecrImage
=== CONT  TestAccECRImageDataSource_ecrImage
--- PASS: TestAccECRImageDataSource_ecrImage (16.10s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecr        17.985s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/ecr Issues and PRs that pertain to the ecr service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/S Managed by automation to categorize the size of a PR. labels May 3, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @weaversam8 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 5, 2022
@Lianite
Copy link

Lianite commented Jul 19, 2023

This PR has been open for over a year. Are there any updates on when this could be expected to be merged in and released?

@TxMat
Copy link

TxMat commented Dec 5, 2023

any news ?

@marcaurele
Copy link

It's rather a small PR, could it get some attention to improve the ECR image resource.

@johnsonaj johnsonaj self-assigned this Dec 14, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 14, 2023
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS="-run=TestAccECRImageDataSource_basic" PKG=ecr

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20  -run=TestAccECRImageDataSource_basic -timeout 360m
=== RUN   TestAccECRImageDataSource_basic
=== PAUSE TestAccECRImageDataSource_basic
=== CONT  TestAccECRImageDataSource_basic
--- PASS: TestAccECRImageDataSource_basic (45.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	48.469s

@johnsonaj
Copy link
Contributor

@weaversam8 thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit 023b4b9 into hashicorp:main Dec 15, 2023
43 checks passed
@github-actions github-actions bot added this to the v5.32.0 milestone Dec 15, 2023
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/ecr Issues and PRs that pertain to the ecr service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECR: Add Image URI as an Attribute for the image data source
6 participants