-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d/aws_ecr_image: Add image URI attribute #24526
d/aws_ecr_image: Add image URI attribute #24526
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @weaversam8 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
This PR has been open for over a year. Are there any updates on when this could be expected to be merged in and released? |
any news ? |
It's rather a small PR, could it get some attention to improve the ECR image resource. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
% make testacc TESTARGS="-run=TestAccECRImageDataSource_basic" PKG=ecr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20 -run=TestAccECRImageDataSource_basic -timeout 360m
=== RUN TestAccECRImageDataSource_basic
=== PAUSE TestAccECRImageDataSource_basic
=== CONT TestAccECRImageDataSource_basic
--- PASS: TestAccECRImageDataSource_basic (45.02s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecr 48.469s
@weaversam8 thank you for the contribution! 🎉 |
This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #13671.
image_uri
attribute toaws_ecr_image
datasource.image_tag
orimage_digest
argument.{RepositoryUri}@{ImageDigest}
, even if a tag is provided, since a URI with the digest is the canonical URI and is functionally equivalent to{RepositoryUri}@{ImageTag}
at the time the tag is provided.TestAccECRImageDataSource_ecrImage
acceptance testaws_ecr_image
documentationOutput from acceptance testing: