Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_location_map - new resource #24682

Merged
merged 10 commits into from
May 6, 2022

Conversation

kamilturek
Copy link
Collaborator

@kamilturek kamilturek commented May 6, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #19629.

Output from acceptance testing:

$ make testacc PKG=location TESTS="TestAccLocationMap_"          
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/location/... -v -count 1 -parallel 20 -run='TestAccLocationMap_'  -timeout 180m
=== RUN   TestAccLocationMap_basic
=== PAUSE TestAccLocationMap_basic
=== RUN   TestAccLocationMap_disappears
=== PAUSE TestAccLocationMap_disappears
=== RUN   TestAccLocationMap_description
=== PAUSE TestAccLocationMap_description
=== RUN   TestAccLocationMap_tags
=== PAUSE TestAccLocationMap_tags
=== CONT  TestAccLocationMap_basic
=== CONT  TestAccLocationMap_description
=== CONT  TestAccLocationMap_tags
=== CONT  TestAccLocationMap_disappears
--- PASS: TestAccLocationMap_disappears (21.29s)
--- PASS: TestAccLocationMap_basic (40.00s)
--- PASS: TestAccLocationMap_tags (63.43s)
--- PASS: TestAccLocationMap_description (65.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/location	67.209s

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/location Issues and PRs that pertain to the location service. tags Pertains to resource tagging. needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 6, 2022
@kamilturek kamilturek force-pushed the f-aws-location-map branch from beb14c8 to 59e20a7 Compare May 6, 2022 16:16
@kamilturek kamilturek marked this pull request as ready for review May 6, 2022 17:38
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels May 6, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc PKG=location TESTS="TestAccLocationMap_" ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/location/... -v -count 1 -parallel 3 -run='TestAccLocationMap_'  -timeout 180m
=== RUN   TestAccLocationMap_basic
=== PAUSE TestAccLocationMap_basic
=== RUN   TestAccLocationMap_disappears
=== PAUSE TestAccLocationMap_disappears
=== RUN   TestAccLocationMap_description
=== PAUSE TestAccLocationMap_description
=== RUN   TestAccLocationMap_tags
=== PAUSE TestAccLocationMap_tags
=== CONT  TestAccLocationMap_description
=== CONT  TestAccLocationMap_disappears
=== CONT  TestAccLocationMap_tags
--- PASS: TestAccLocationMap_disappears (22.02s)
=== CONT  TestAccLocationMap_basic
--- PASS: TestAccLocationMap_description (47.12s)
--- PASS: TestAccLocationMap_basic (25.79s)
--- PASS: TestAccLocationMap_tags (67.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/location	79.040s

@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 07ec376 into hashicorp:main May 6, 2022
@github-actions github-actions bot added this to the v4.14.0 milestone May 6, 2022
@kamilturek kamilturek deleted the f-aws-location-map branch May 6, 2022 20:53
@github-actions
Copy link

This functionality has been released in v4.14.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/location Issues and PRs that pertain to the location service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants