Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_location_map - new data source #24693

Merged
merged 8 commits into from
May 9, 2022

Conversation

kamilturek
Copy link
Collaborator

@kamilturek kamilturek commented May 7, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #19629.

Output from acceptance testing:

$ make testacc PKG=location TESTS="TestAccLocationMap_|TestAccLocationMapDataSource_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/location/... -v -count 1 -parallel 20 -run='TestAccLocationMap_|TestAccLocationMapDataSource_'  -timeout 180m
=== RUN   TestAccLocationMapDataSource_mapName
=== PAUSE TestAccLocationMapDataSource_mapName
=== RUN   TestAccLocationMap_basic
=== PAUSE TestAccLocationMap_basic
=== RUN   TestAccLocationMap_disappears
=== PAUSE TestAccLocationMap_disappears
=== RUN   TestAccLocationMap_description
=== PAUSE TestAccLocationMap_description
=== RUN   TestAccLocationMap_tags
=== PAUSE TestAccLocationMap_tags
=== CONT  TestAccLocationMapDataSource_mapName
=== CONT  TestAccLocationMap_description
=== CONT  TestAccLocationMap_disappears
=== CONT  TestAccLocationMap_tags
=== CONT  TestAccLocationMap_basic
--- PASS: TestAccLocationMap_disappears (20.06s)
--- PASS: TestAccLocationMapDataSource_mapName (24.50s)
--- PASS: TestAccLocationMap_basic (26.84s)
--- PASS: TestAccLocationMap_description (43.26s)
--- PASS: TestAccLocationMap_tags (60.76s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/location   62.538s

@kamilturek kamilturek changed the title F data aws location map d/aws_location_map - new data source May 7, 2022
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/location Issues and PRs that pertain to the location service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. service/location Issues and PRs that pertain to the location service. labels May 7, 2022
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/location Issues and PRs that pertain to the location service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. service/location Issues and PRs that pertain to the location service. labels May 7, 2022
@kamilturek kamilturek marked this pull request as ready for review May 7, 2022 10:47
@ewbankkit ewbankkit added documentation Introduces or discusses updates to documentation. and removed needs-triage Waiting for first response or review from a maintainer. labels May 7, 2022
@ewbankkit ewbankkit added new-data-source Introduces a new data source. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/location Issues and PRs that pertain to the location service. labels May 7, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccLocationMap PKG=location ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/location/... -v -count 1 -parallel 2 -run='TestAccLocationMap'  -timeout 180m
=== RUN   TestAccLocationMapDataSource_mapName
=== PAUSE TestAccLocationMapDataSource_mapName
=== RUN   TestAccLocationMap_basic
=== PAUSE TestAccLocationMap_basic
=== RUN   TestAccLocationMap_disappears
=== PAUSE TestAccLocationMap_disappears
=== RUN   TestAccLocationMap_description
=== PAUSE TestAccLocationMap_description
=== RUN   TestAccLocationMap_tags
=== PAUSE TestAccLocationMap_tags
=== CONT  TestAccLocationMapDataSource_mapName
=== CONT  TestAccLocationMap_description
--- PASS: TestAccLocationMapDataSource_mapName (17.65s)
=== CONT  TestAccLocationMap_tags
--- PASS: TestAccLocationMap_description (29.85s)
=== CONT  TestAccLocationMap_disappears
--- PASS: TestAccLocationMap_disappears (11.02s)
=== CONT  TestAccLocationMap_basic
--- PASS: TestAccLocationMap_tags (38.91s)
--- PASS: TestAccLocationMap_basic (16.89s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/location	61.782s

@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 500e507 into hashicorp:main May 9, 2022
@github-actions github-actions bot added this to the v4.14.0 milestone May 9, 2022
@github-actions
Copy link

This functionality has been released in v4.14.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2022
@kamilturek kamilturek deleted the f-data-aws-location-map branch June 18, 2022 15:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. service/location Issues and PRs that pertain to the location service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants