fix: http endpoint not defaulted

[ahaynssen]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16781

Output from acceptance testing:

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2Instance_metadataOptions'  -timeout 180m
=== RUN   TestAccEC2Instance_metadataOptions
=== PAUSE TestAccEC2Instance_metadataOptions
=== CONT  TestAccEC2Instance_metadataOptions
--- PASS: TestAccEC2Instance_metadataOptions (121.27s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        123.428s

[github-actions]

Welcome @ahaynssen 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ahaynssen]

I wasn't sure another test was warranted for this, but wanted to point out it was probably missed because the test has a value set and never checks if it is defaulted to enabled when other metadata_options are set but http_endpoint is not.

https://github.com/hashicorp/terraform-provider-aws/blob/main/internal/service/ec2/ec2_instance_test.go#L7355

[jar-b]

LGTM 🎉

$ make testacc PKG=ec2 TESTS=TestAccEC2Instance_metadataOptions
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2Instance_metadataOptions'  -timeout 180m
=== RUN   TestAccEC2Instance_metadataOptions
=== PAUSE TestAccEC2Instance_metadataOptions
=== CONT  TestAccEC2Instance_metadataOptions
--- PASS: TestAccEC2Instance_metadataOptions (166.96s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        170.354s

$ make testacc PKG=ec2 TESTS=TestAccEC2Instance_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2Instance_'  -timeout 180m

--- PASS: TestAccEC2Instance_ipv6AddressCountAndSingleAddressCausesError (6.00s)
=== CONT  TestAccEC2Instance_CapacityReservationPreference_none
--- PASS: TestAccEC2Instance_basicWithSpot (71.04s)
=== CONT  TestAccEC2Instance_CapacityReservationPreference_open
--- PASS: TestAccEC2Instance_basic (80.27s)
=== CONT  TestAccEC2Instance_CapacityReservation_unspecifiedDefaultsToOpen
--- PASS: TestAccEC2Instance_placementGroup (84.85s)
=== CONT  TestAccEC2Instance_enclaveOptions
--- PASS: TestAccEC2Instance_placementPartitionNumber (84.89s)
=== CONT  TestAccEC2Instance_metadataOptions
--- PASS: TestAccEC2Instance_CapacityReservationPreference_none (100.04s)
=== CONT  TestAccEC2Instance_hibernation
--- PASS: TestAccEC2Instance_primaryNetworkInterface (115.08s)
=== CONT  TestAccEC2Instance_UserDataReplaceOnChange_Off_Base64
--- PASS: TestAccEC2Instance_networkCardIndex (116.05s)
=== CONT  TestAccEC2Instance_UserDataReplaceOnChange_Off
--- PASS: TestAccEC2Instance_blockDevices (118.66s)
=== CONT  TestAccEC2Instance_UserDataReplaceOnChange_On_Base64
--- PASS: TestAccEC2Instance_networkInstanceVPCSecurityGroupIDs (119.49s)
=== CONT  TestAccEC2Instance_UserDataReplaceOnChange_On
--- PASS: TestAccEC2Instance_networkInstanceSecurityGroups (119.50s)
=== CONT  TestAccEC2Instance_UserData_unspecifiedToEmptyString
--- PASS: TestAccEC2Instance_IPv6_supportAddressCount (122.77s)
=== CONT  TestAccEC2Instance_disableAPIStop
=== CONT  TestAccEC2Instance_dedicatedInstance
--- PASS: TestAccEC2Instance_primaryNetworkInterfaceSourceDestCheck (125.06s)
--- PASS: TestAccEC2Instance_CapacityReservation_targetID (127.48s)
=== CONT  TestAccEC2Instance_disableAPITerminationFinalTrue
--- PASS: TestAccEC2Instance_UserData_emptyStringToUnspecified (135.30s)
=== CONT  TestAccEC2Instance_disableAPITerminationFinalFalse
--- PASS: TestAccEC2Instance_CreditSpecification_standardCPUCredits (139.39s)
=== CONT  TestAccEC2Instance_CreditSpecificationT3_standardCPUCredits
--- PASS: TestAccEC2Instance_IPv6_supportAddressCountWithIPv4 (139.64s)
=== CONT  TestAccEC2Instance_UserData_stringToEncodedString
--- PASS: TestAccEC2Instance_networkInstanceRemovingAllSecurityGroups (139.67s)
=== CONT  TestAccEC2Instance_UserData_update
--- PASS: TestAccEC2Instance_CapacityReservation_modifyTarget (158.08s)
=== CONT  TestAccEC2Instance_UserData
    ec2_instance_test.go:4650: Step 1/2 error: Error running apply: exit status 1

        Error: reading EC2 VPC (vpc-02eceb1f7e1270b69) Attribute (enableDnsHostnames): couldn't find resource

          with aws_vpc.test,
          on terraform_plugin_test.tf line 27, in resource "aws_vpc" "test":
          27: resource "aws_vpc" "test" {

--- FAIL: TestAccEC2Instance_UserData (10.91s)
=== CONT  TestAccEC2Instance_CreditSpecificationUnlimitedCPUCredits_t2Tot3Taint
--- PASS: TestAccEC2Instance_CapacityReservation_modifyPreference (171.46s)
=== CONT  TestAccEC2Instance_CreditSpecificationStandardCPUCredits_t2Tot3Taint
--- PASS: TestAccEC2Instance_CapacityReservationPreference_open (103.31s)
=== CONT  TestAccEC2Instance_CreditSpecificationT3_updateCPUCredits
--- PASS: TestAccEC2Instance_CapacityReservation_unspecifiedDefaultsToOpen (122.55s)
=== CONT  TestAccEC2Instance_CreditSpecificationT3_unlimitedCPUCredits
--- PASS: TestAccEC2Instance_dedicatedInstance (93.05s)
=== CONT  TestAccEC2Instance_changeInstanceType
--- PASS: TestAccEC2Instance_UserData_unspecifiedToEmptyString (121.60s)
=== CONT  TestAccEC2Instance_gp3RootBlockDevice
--- PASS: TestAccEC2Instance_hibernation (135.89s)
=== CONT  TestAccEC2Instance_EBSRootDevice_multipleDynamicEBSBlockDevices
--- PASS: TestAccEC2Instance_disableAPITerminationFinalTrue (115.49s)
=== CONT  TestAccEC2Instance_EBSRootDeviceMultipleBlockDevices_modifyDeleteOnTermination
--- PASS: TestAccEC2Instance_CreditSpecificationT3_standardCPUCredits (104.92s)
=== CONT  TestAccEC2Instance_EBSRootDeviceMultipleBlockDevices_modifySize
--- PASS: TestAccEC2Instance_disableAPIStop (128.20s)
=== CONT  TestAccEC2Instance_EBSRootDevice_modifyAll
--- PASS: TestAccEC2Instance_metadataOptions (172.76s)
=== CONT  TestAccEC2Instance_EBSRootDevice_modifyDeleteOnTermination
--- PASS: TestAccEC2Instance_disableAPITerminationFinalFalse (125.04s)
=== CONT  TestAccEC2Instance_EBSRootDeviceModifyThroughput_gp3
--- PASS: TestAccEC2Instance_enclaveOptions (180.37s)
=== CONT  TestAccEC2Instance_EBSRootDeviceModifyIOPS_io2
--- PASS: TestAccEC2Instance_CreditSpecificationT3_updateCPUCredits (125.51s)
=== CONT  TestAccEC2Instance_EBSRootDeviceModifyIOPS_io1
--- PASS: TestAccEC2Instance_UserDataReplaceOnChange_Off_Base64 (186.42s)
=== CONT  TestAccEC2Instance_EBSRootDevice_modifyType
--- PASS: TestAccEC2Instance_UserData_stringToEncodedString (175.57s)
=== CONT  TestAccEC2Instance_EBSRootDevice_modifySize
--- PASS: TestAccEC2Instance_UserDataReplaceOnChange_On_Base64 (197.81s)
=== CONT  TestAccEC2Instance_EBSRootDevice_basic
--- PASS: TestAccEC2Instance_CreditSpecificationT3_unlimitedCPUCredits (120.56s)
=== CONT  TestAccEC2Instance_changeInstanceTypeAndUserDataBase64
--- PASS: TestAccEC2Instance_UserDataReplaceOnChange_Off (207.58s)
=== CONT  TestAccEC2Instance_changeInstanceTypeAndUserData
--- PASS: TestAccEC2Instance_CreditSpecificationUnlimitedCPUCredits_t2Tot3Taint (154.77s)
=== CONT  TestAccEC2Instance_sourceDestCheck
--- PASS: TestAccEC2Instance_UserDataReplaceOnChange_On (207.21s)
=== CONT  TestAccEC2Instance_autoRecovery
--- PASS: TestAccEC2Instance_UserData_update (195.91s)
=== CONT  TestAccEC2Instance_CreditSpecificationUnknownCPUCredits_t4g
--- PASS: TestAccEC2Instance_gp3RootBlockDevice (97.58s)
=== CONT  TestAccEC2Instance_CreditSpecificationT3_unspecifiedDefaultsToUnlimited
=== NAME  TestAccEC2Instance_CreditSpecificationUnknownCPUCredits_t4g
    ec2_instance_test.go:4316: Step 1/2 error: Error running apply: exit status 1

        Error: reading EC2 VPC (vpc-0d1ab56ac246acaf3) Attribute (enableDnsHostnames): couldn't find resource

          with aws_vpc.test,
          on terraform_plugin_test.tf line 32, in resource "aws_vpc" "test":
          32: resource "aws_vpc" "test" {

--- FAIL: TestAccEC2Instance_CreditSpecificationUnknownCPUCredits_t4g (10.57s)
=== CONT  TestAccEC2Instance_CreditSpecification_isNotAppliedToNonBurstable
--- PASS: TestAccEC2Instance_EBSRootDeviceMultipleBlockDevices_modifyDeleteOnTermination (123.30s)
=== CONT  TestAccEC2Instance_CreditSpecification_updateCPUCredits
--- PASS: TestAccEC2Instance_CreditSpecificationStandardCPUCredits_t2Tot3Taint (196.97s)
=== CONT  TestAccEC2Instance_EBSBlockDevice_RootBlockDevice_removed
--- PASS: TestAccEC2Instance_EBSRootDevice_modifyDeleteOnTermination (113.09s)
=== CONT  TestAccEC2Instance_gp2WithIopsValue
--- PASS: TestAccEC2Instance_gp2WithIopsValue (10.96s)
=== CONT  TestAccEC2Instance_gp2IopsDevice
--- PASS: TestAccEC2Instance_changeInstanceType (171.77s)
=== CONT  TestAccEC2Instance_userDataBase64_update
--- PASS: TestAccEC2Instance_EBSRootDeviceModifyThroughput_gp3 (132.43s)
=== CONT  TestAccEC2Instance_userDataBase64_updateWithZipFile
--- PASS: TestAccEC2Instance_addSecondaryInterface (394.03s)
=== CONT  TestAccEC2Instance_userDataBase64_updateWithBashFile
--- PASS: TestAccEC2Instance_EBSRootDeviceModifyIOPS_io2 (133.67s)
=== CONT  TestAccEC2Instance_userDataBase64
--- PASS: TestAccEC2Instance_EBSRootDevice_modifyAll (165.70s)
=== CONT  TestAccEC2Instance_RootBlockDevice_kmsKeyARN
--- PASS: TestAccEC2Instance_CreditSpecification_isNotAppliedToNonBurstable (84.07s)
=== CONT  TestAccEC2Instance_associatePublicIPAndPrivateIP
--- PASS: TestAccEC2Instance_EBSRootDevice_basic (114.78s)
=== CONT  TestAccEC2Instance_forceNewAndTagsDrift
--- PASS: TestAccEC2Instance_EBSRootDeviceMultipleBlockDevices_modifySize (195.58s)
=== CONT  TestAccEC2Instance_rootBlockDeviceMismatch
--- PASS: TestAccEC2Instance_CreditSpecificationT3_unspecifiedDefaultsToUnlimited (103.87s)
=== CONT  TestAccEC2Instance_keyPairCheck
--- PASS: TestAccEC2Instance_autoRecovery (118.98s)
=== CONT  TestAccEC2Instance_PrivateDNSNameOptions_configured
--- PASS: TestAccEC2Instance_EBSRootDeviceModifyIOPS_io1 (146.02s)
=== CONT  TestAccEC2Instance_PrivateDNSNameOptions_computed
--- PASS: TestAccEC2Instance_gp2IopsDevice (76.61s)
=== CONT  TestAccEC2Instance_Empty_privateIP
--- PASS: TestAccEC2Instance_sourceDestCheck (145.87s)
=== CONT  TestAccEC2Instance_LaunchTemplate_updateTemplateVersion
--- PASS: TestAccEC2Instance_EBSRootDevice_modifySize (157.10s)
=== CONT  TestAccEC2Instance_CreditSpecification_unspecifiedDefaultsToStandard
--- PASS: TestAccEC2Instance_EBSBlockDevice_RootBlockDevice_removed (116.34s)
=== CONT  TestAccEC2Instance_CreditSpecificationUnspecifiedToEmpty_nonBurstable
--- PASS: TestAccEC2Instance_EBSRootDevice_modifyType (196.26s)
=== CONT  TestAccEC2Instance_CreditSpecificationEmpty_nonBurstable
=== CONT  TestAccEC2Instance_cpuOptionsCoreThreadsUnspecifiedToSpecified
--- PASS: TestAccEC2Instance_RootBlockDevice_kmsKeyARN (84.00s)
--- PASS: TestAccEC2Instance_userDataBase64 (102.51s)
=== CONT  TestAccEC2Instance_cpuOptionsCoreThreadsMigration
--- PASS: TestAccEC2Instance_CreditSpecification_updateCPUCredits (150.95s)
=== CONT  TestAccEC2Instance_cpuOptionsCoreThreads
--- PASS: TestAccEC2Instance_rootBlockDeviceMismatch (86.20s)
=== CONT  TestAccEC2Instance_cpuOptionsAmdSevSnpCoreThreads
    acctest.go:848: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-2]
--- SKIP: TestAccEC2Instance_cpuOptionsAmdSevSnpCoreThreads (0.01s)
=== CONT  TestAccEC2Instance_cpuOptionsAmdSevSnpDisabledToEnabled
    acctest.go:848: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-2]
--- SKIP: TestAccEC2Instance_cpuOptionsAmdSevSnpDisabledToEnabled (0.00s)
=== CONT  TestAccEC2Instance_cpuOptionsAmdSevSnpEnabledToDisabled
    acctest.go:848: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-2]
--- SKIP: TestAccEC2Instance_cpuOptionsAmdSevSnpEnabledToDisabled (0.00s)
=== CONT  TestAccEC2Instance_cpuOptionsAmdSevSnpUnspecifiedToEnabledToDisabledToUnspecified
    acctest.go:848: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-2]
--- SKIP: TestAccEC2Instance_cpuOptionsAmdSevSnpUnspecifiedToEnabledToDisabledToUnspecified (0.00s)
=== CONT  TestAccEC2Instance_cpuOptionsAmdSevSnpUnspecifiedToDisabledToEnabledToUnspecified
    acctest.go:848: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-2]
--- SKIP: TestAccEC2Instance_cpuOptionsAmdSevSnpUnspecifiedToDisabledToEnabledToUnspecified (0.00s)
=== CONT  TestAccEC2Instance_GetPasswordData_trueToFalse
=== CONT  TestAccEC2Instance_GetPasswordData_falseToTrue
--- PASS: TestAccEC2Instance_keyPairCheck (90.74s)
--- PASS: TestAccEC2Instance_associatePublicIPAndPrivateIP (122.31s)
=== CONT  TestAccEC2Instance_LaunchTemplate_spotAndStop
--- PASS: TestAccEC2Instance_changeInstanceTypeAndUserData (229.94s)
=== CONT  TestAccEC2Instance_LaunchTemplate_withIAMInstanceProfile
=== CONT  TestAccEC2Instance_LaunchTemplate_swapIDAndName
--- PASS: TestAccEC2Instance_EBSRootDevice_multipleDynamicEBSBlockDevices (321.18s)
--- PASS: TestAccEC2Instance_changeInstanceTypeAndUserDataBase64 (257.08s)
=== CONT  TestAccEC2Instance_AssociatePublic_explicitPublic
--- PASS: TestAccEC2Instance_Empty_privateIP (133.52s)
=== CONT  TestAccEC2Instance_LaunchTemplateModifyTemplate_defaultVersion
--- PASS: TestAccEC2Instance_CreditSpecification_unspecifiedDefaultsToStandard (123.58s)
=== CONT  TestAccEC2Instance_LaunchTemplate_setSpecificVersion
--- PASS: TestAccEC2Instance_userDataBase64_update (222.33s)
=== CONT  TestAccEC2Instance_LaunchTemplate_overrideTemplate
--- PASS: TestAccEC2Instance_userDataBase64_updateWithZipFile (227.93s)
=== CONT  TestAccEC2Instance_LaunchTemplate_basic
--- PASS: TestAccEC2Instance_PrivateDNSNameOptions_computed (178.12s)
=== CONT  TestAccEC2Instance_AssociatePublic_overridePrivate
--- PASS: TestAccEC2Instance_userDataBase64_updateWithBashFile (236.41s)
=== CONT  TestAccEC2Instance_AssociatePublic_overridePublic
--- PASS: TestAccEC2Instance_CreditSpecificationEmpty_nonBurstable (145.18s)
=== CONT  TestAccEC2Instance_AssociatePublic_explicitPrivate
--- PASS: TestAccEC2Instance_LaunchTemplate_withIAMInstanceProfile (91.27s)
=== CONT  TestAccEC2Instance_CreditSpecificationUnknownCPUCredits_t3
--- PASS: TestAccEC2Instance_CreditSpecificationUnspecifiedToEmpty_nonBurstable (160.77s)
=== CONT  TestAccEC2Instance_CreditSpecificationUnknownCPUCredits_t3a
--- PASS: TestAccEC2Instance_LaunchTemplate_spotAndStop (96.80s)
=== CONT  TestAccEC2Instance_NewNetworkInterface_privateIPAndSecondaryPrivateIPs
--- PASS: TestAccEC2Instance_cpuOptionsCoreThreadsUnspecifiedToSpecified (152.29s)
=== CONT  TestAccEC2Instance_AssociatePublic_defaultPublic
--- PASS: TestAccEC2Instance_cpuOptionsCoreThreadsMigration (163.39s)
=== CONT  TestAccEC2Instance_AssociatePublic_defaultPrivate
--- PASS: TestAccEC2Instance_LaunchTemplate_basic (65.16s)
=== CONT  TestAccEC2Instance_NewNetworkInterface_privateIPAndSecondaryPrivateIPsUpdate
--- PASS: TestAccEC2Instance_PrivateDNSNameOptions_configured (248.01s)
=== CONT  TestAccEC2Instance_noAMIEphemeralDevices
--- PASS: TestAccEC2Instance_AssociatePublic_explicitPublic (115.13s)
=== CONT  TestAccEC2Instance_rootInstanceStore
--- PASS: TestAccEC2Instance_LaunchTemplateModifyTemplate_defaultVersion (103.97s)
=== CONT  TestAccEC2Instance_NewNetworkInterface_emptyPrivateIPAndSecondaryPrivateIPs
--- PASS: TestAccEC2Instance_LaunchTemplate_overrideTemplate (94.95s)
=== CONT  TestAccEC2Instance_NewNetworkInterface_emptyPrivateIPAndSecondaryPrivateIPsUpdate
--- PASS: TestAccEC2Instance_LaunchTemplate_swapIDAndName (145.20s)
=== CONT  TestAccEC2Instance_instanceProfileChange
--- PASS: TestAccEC2Instance_CreditSpecificationUnknownCPUCredits_t3a (74.16s)
=== CONT  TestAccEC2Instance_privateIP
--- PASS: TestAccEC2Instance_LaunchTemplate_setSpecificVersion (138.11s)
=== CONT  TestAccEC2Instance_withIAMInstanceProfilePath
--- PASS: TestAccEC2Instance_AssociatePublic_overridePrivate (111.34s)
=== CONT  TestAccEC2Instance_withIAMInstanceProfile
--- PASS: TestAccEC2Instance_cpuOptionsCoreThreads (218.40s)
=== CONT  TestAccEC2Instance_NewNetworkInterface_publicIPAndSecondaryPrivateIPs
--- PASS: TestAccEC2Instance_GetPasswordData_falseToTrue (207.09s)
=== CONT  TestAccEC2Instance_atLeastOneOtherEBSVolume
--- PASS: TestAccEC2Instance_AssociatePublic_overridePublic (111.17s)
=== CONT  TestAccEC2Instance_EBSBlockDevice_invalidThroughputForVolumeType
--- PASS: TestAccEC2Instance_NewNetworkInterface_privateIPAndSecondaryPrivateIPs (94.08s)
=== CONT  TestAccEC2Instance_EBSBlockDevice_invalidIopsForVolumeType
--- PASS: TestAccEC2Instance_AssociatePublic_explicitPrivate (104.75s)
=== CONT  TestAccEC2Instance_EBSBlockDevice_kmsKeyARN
=== CONT  TestAccEC2Instance_BlockDeviceTags_withAttachedVolume
--- PASS: TestAccEC2Instance_CreditSpecificationUnknownCPUCredits_t3 (102.96s)
--- PASS: TestAccEC2Instance_EBSBlockDevice_invalidThroughputForVolumeType (25.77s)
=== CONT  TestAccEC2Instance_BlockDeviceTags_ebsAndRoot
--- PASS: TestAccEC2Instance_EBSBlockDevice_invalidIopsForVolumeType (24.11s)
=== CONT  TestAccEC2Instance_BlockDeviceTags_volumeTags
--- PASS: TestAccEC2Instance_AssociatePublic_defaultPublic (134.40s)
=== CONT  TestAccEC2Instance_addSecurityGroupNetworkInterface
--- PASS: TestAccEC2Instance_NewNetworkInterface_emptyPrivateIPAndSecondaryPrivateIPs (96.63s)
=== CONT  TestAccEC2Instance_CreditSpecificationUnknownCPUCredits_t2
--- PASS: TestAccEC2Instance_noAMIEphemeralDevices (100.84s)
=== CONT  TestAccEC2Instance_CreditSpecification_unlimitedCPUCredits
--- PASS: TestAccEC2Instance_GetPasswordData_trueToFalse (268.57s)
=== CONT  TestAccEC2Instance_inDefaultVPCBySgName
--- PASS: TestAccEC2Instance_AssociatePublic_defaultPrivate (133.38s)
=== CONT  TestAccEC2Instance_inDefaultVPCBySgID
--- PASS: TestAccEC2Instance_forceNewAndTagsDrift (380.01s)
=== CONT  TestAccEC2Instance_tags
--- PASS: TestAccEC2Instance_privateIP (107.02s)
=== CONT  TestAccEC2Instance_disappears
--- PASS: TestAccEC2Instance_EBSBlockDevice_kmsKeyARN (99.69s)
--- PASS: TestAccEC2Instance_NewNetworkInterface_emptyPrivateIPAndSecondaryPrivateIPsUpdate (166.01s)
--- PASS: TestAccEC2Instance_withIAMInstanceProfile (140.60s)
--- PASS: TestAccEC2Instance_withIAMInstanceProfilePath (147.15s)
--- PASS: TestAccEC2Instance_NewNetworkInterface_privateIPAndSecondaryPrivateIPsUpdate (205.32s)
--- PASS: TestAccEC2Instance_LaunchTemplate_updateTemplateVersion (427.09s)
--- PASS: TestAccEC2Instance_inDefaultVPCBySgID (111.83s)
--- PASS: TestAccEC2Instance_inDefaultVPCBySgName (119.84s)
--- PASS: TestAccEC2Instance_CreditSpecificationUnknownCPUCredits_t2 (123.51s)
--- PASS: TestAccEC2Instance_rootInstanceStore (237.77s)
--- PASS: TestAccEC2Instance_CreditSpecification_unlimitedCPUCredits (158.01s)
--- PASS: TestAccEC2Instance_NewNetworkInterface_publicIPAndSecondaryPrivateIPs (216.91s)
--- PASS: TestAccEC2Instance_instanceProfileChange (248.60s)
--- PASS: TestAccEC2Instance_BlockDeviceTags_ebsAndRoot (190.00s)
--- PASS: TestAccEC2Instance_tags (155.42s)
--- PASS: TestAccEC2Instance_atLeastOneOtherEBSVolume (233.13s)
--- PASS: TestAccEC2Instance_BlockDeviceTags_withAttachedVolume (228.77s)
--- PASS: TestAccEC2Instance_BlockDeviceTags_volumeTags (239.04s)
--- PASS: TestAccEC2Instance_disappears (334.35s)
--- PASS: TestAccEC2Instance_addSecurityGroupNetworkInterface (398.60s)

Test failures are intermittent and unrelated to this change.

[jar-b]

Thanks for your contribution, @ahaynssen !

[github-actions]

This functionality has been released in v5.3.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.