d/aws_athena_named_query

[LukeHendrick]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAthenaNamedQueryDataSource' PKG=athena ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/athena/... -v -count 1 -parallel 1  -run=TestAccAthenaNamedQueryDataSource -timeout 180m
=== RUN   TestAccAthenaNamedQueryDataSource_basic
=== PAUSE TestAccAthenaNamedQueryDataSource_basic
=== CONT  TestAccAthenaNamedQueryDataSource_basic
--- PASS: TestAccAthenaNamedQueryDataSource_basic (35.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/athena	38.346s
...

AWS API does not provide a way to natively retrieve aws_athena_named_query by name (id only). This data source allows you to do that (and filter by workspace)

[LukeHendrick]

Hi @justinretzolk! Was able to update the docs and fix some formatting issues so now all checks are passing!

[justinretzolk]

Hey @LukeHendrick 👋 Thank you very much for your contribution! I'm the community manager for the provider, so I'm mostly taking a quick glance over this until one of our maintainers can take a look at the PR itself (in case you're unfamiliar with how we prioritize, we have a document that details that).

One thing I did notice on a quick check that we'll need a changelog entry as well. Other than that, this looks to be in good shape for review!

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAthenaNamedQuery' PKG=athena ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/athena/... -v -count 1 -parallel 2  -run=TestAccAthenaNamedQuery -timeout 360m
=== RUN   TestAccAthenaNamedQueryDataSource_basic
=== PAUSE TestAccAthenaNamedQueryDataSource_basic
=== RUN   TestAccAthenaNamedQuery_basic
=== PAUSE TestAccAthenaNamedQuery_basic
=== RUN   TestAccAthenaNamedQuery_withWorkGroup
=== PAUSE TestAccAthenaNamedQuery_withWorkGroup
=== CONT  TestAccAthenaNamedQueryDataSource_basic
=== CONT  TestAccAthenaNamedQuery_withWorkGroup
--- PASS: TestAccAthenaNamedQueryDataSource_basic (54.79s)
=== CONT  TestAccAthenaNamedQuery_basic
--- PASS: TestAccAthenaNamedQuery_withWorkGroup (57.49s)
--- PASS: TestAccAthenaNamedQuery_basic (39.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/athena	99.976s

[ewbankkit]

@LukeHendrick Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.