Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

td/aws_connect #24861

Merged
merged 9 commits into from
Jun 24, 2022
Merged

td/aws_connect #24861

merged 9 commits into from
Jun 24, 2022

Conversation

GlennChia
Copy link
Collaborator

@GlennChia GlennChia commented May 18, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccConnectHoursOfOperation_serial' PKG=connect ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 1  -run=TestAccConnectHoursOfOperation_serial -timeout 180m
=== RUN   TestAccConnectHoursOfOperation_serial
=== RUN   TestAccConnectHoursOfOperation_serial/basic
=== RUN   TestAccConnectHoursOfOperation_serial/disappears
=== RUN   TestAccConnectHoursOfOperation_serial/update_config
--- PASS: TestAccConnectHoursOfOperation_serial (303.87s)
    --- PASS: TestAccConnectHoursOfOperation_serial/basic (102.40s)
    --- PASS: TestAccConnectHoursOfOperation_serial/disappears (80.00s)
    --- PASS: TestAccConnectHoursOfOperation_serial/update_config (121.48s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    303.932s

$ make testacc TESTARGS='-run=TestAccConnectQuickConnectDataSource' PKG=connect ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 1  -run=TestAccConnectQuickConnectDataSource -timeout 180m
=== RUN   TestAccConnectQuickConnectDataSource_id
--- PASS: TestAccConnectQuickConnectDataSource_id (125.88s)
=== RUN   TestAccConnectQuickConnectDataSource_name
--- PASS: TestAccConnectQuickConnectDataSource_name (80.35s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    206.286s
...

$ make testacc TESTARGS='-run=TestAccConnectQueueDataSource' PKG=connect ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 1  -run=TestAccConnectQueueDataSource -timeout 180m
=== RUN   TestAccConnectQueueDataSource_queueID
--- PASS: TestAccConnectQueueDataSource_queueID (93.22s)
=== RUN   TestAccConnectQueueDataSource_name
--- PASS: TestAccConnectQueueDataSource_name (82.86s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    176.137s

$ make testacc TESTARGS='-run=TestAccConnectInstance_serial' PKG=connect ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 1  -run=TestAccConnectInstance_serial -timeout 180m
=== RUN   TestAccConnectInstance_serial
=== RUN   TestAccConnectInstance_serial/directory
=== RUN   TestAccConnectInstance_serial/saml
=== RUN   TestAccConnectInstance_serial/basic
--- PASS: TestAccConnectInstance_serial (1098.08s)
    --- PASS: TestAccConnectInstance_serial/directory (906.46s)
    --- PASS: TestAccConnectInstance_serial/saml (91.48s)
    --- PASS: TestAccConnectInstance_serial/basic (100.14s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    1098.138s

Changes

  • Removed timeouts from Contact Flows
  • Support customised timeouts for Instances
  • Improve Hours of Operation rsrc, Queue data src, Quick Connect data src Tests

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/connect Issues and PRs that pertain to the connect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed needs-triage Waiting for first response or review from a maintainer. labels May 18, 2022
@gdavison gdavison self-assigned this Jun 8, 2022
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

--- PASS: TestAccConnectHoursOfOperation_serial (286.98s)
--- PASS: TestAccConnectHoursOfOperation_serial/disappears (79.32s)
--- PASS: TestAccConnectHoursOfOperation_serial/update_config (99.03s)
--- PASS: TestAccConnectHoursOfOperation_serial/basic (108.62s)
--- PASS: TestAccConnectInstance_serial (1140.50s)
--- PASS: TestAccConnectInstance_serial/basic (131.56s)
--- PASS: TestAccConnectInstance_serial/directory (925.34s)
--- PASS: TestAccConnectInstance_serial/saml (83.60s)
--- PASS: TestAccConnectQueueDataSource_queueID (89.00s)
--- PASS: TestAccConnectQueueDataSource_name (89.94s)
--- PASS: TestAccConnectQuickConnectDataSource_id (90.48s)
--- PASS: TestAccConnectQuickConnectDataSource_name (89.36s)

@gdavison gdavison merged commit e624f5e into hashicorp:main Jun 24, 2022
@github-actions github-actions bot added this to the v4.21.0 milestone Jun 24, 2022
@GlennChia GlennChia deleted the td-aws_connect branch June 25, 2022 06:00
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

This functionality has been released in v4.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. service/connect Issues and PRs that pertain to the connect service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants