Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Commit #25097

Conversation

meetreks
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/autoscaling Issues and PRs that pertain to the autoscaling service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 28, 2022
@meetreks
Copy link
Contributor Author

:~/terraform-provider-aws (b-aws_launch_configuration_data_source) $ make testacc PKG=autoscaling TESTS=TestAccAutoScalingLaunchConfigurationDataSource_basic ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 20 -run='TestAccAutoScalingLaunchConfigurationDataSource_basic' -timeout 180m === RUN TestAccAutoScalingLaunchConfigurationDataSource_basic === PAUSE TestAccAutoScalingLaunchConfigurationDataSource_basic === CONT TestAccAutoScalingLaunchConfigurationDataSource_basic --- PASS: TestAccAutoScalingLaunchConfigurationDataSource_basic (41.94s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling 42.045s

@ewbankkit ewbankkit removed needs-triage Waiting for first response or review from a maintainer. labels May 31, 2022
@ewbankkit
Copy link
Contributor

@meetreks Thanks for the contribution 🎉 👏.
I have rolled this into #17695.

@ewbankkit ewbankkit closed this May 31, 2022
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
partner Contribution from a partner. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants