-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/ram_resource_share - add permission_arns
argument
#25113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRAMResourceShare_' PKG=ram ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ram/... -v -count 1 -parallel 2 -run=TestAccRAMResourceShare_ -timeout 180m
=== RUN TestAccRAMResourceShare_basic
=== PAUSE TestAccRAMResourceShare_basic
=== RUN TestAccRAMResourceShare_permission
=== PAUSE TestAccRAMResourceShare_permission
=== RUN TestAccRAMResourceShare_allowExternalPrincipals
=== PAUSE TestAccRAMResourceShare_allowExternalPrincipals
=== RUN TestAccRAMResourceShare_name
=== PAUSE TestAccRAMResourceShare_name
=== RUN TestAccRAMResourceShare_tags
=== PAUSE TestAccRAMResourceShare_tags
=== RUN TestAccRAMResourceShare_disappears
=== PAUSE TestAccRAMResourceShare_disappears
=== CONT TestAccRAMResourceShare_basic
=== CONT TestAccRAMResourceShare_name
--- PASS: TestAccRAMResourceShare_basic (21.52s)
=== CONT TestAccRAMResourceShare_disappears
--- PASS: TestAccRAMResourceShare_disappears (14.44s)
=== CONT TestAccRAMResourceShare_tags
--- PASS: TestAccRAMResourceShare_name (36.94s)
=== CONT TestAccRAMResourceShare_allowExternalPrincipals
--- PASS: TestAccRAMResourceShare_allowExternalPrincipals (32.00s)
=== CONT TestAccRAMResourceShare_permission
--- PASS: TestAccRAMResourceShare_tags (45.28s)
--- PASS: TestAccRAMResourceShare_permission (20.19s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ram 93.203s
@DrFaust92 Thanks for the contribution 🎉 👏. |
% make providerlint golangci-lint
==> Checking source code with providerlint...
==> Checking source code with golangci-lint... |
This functionality has been released in v4.17.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #20499
Output from acceptance testing: