Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/servicecatalog_provisioned_product: fix error when in the TAINTED state #25130

Merged
merged 3 commits into from
Jun 2, 2022
Merged

r/servicecatalog_provisioned_product: fix error when in the TAINTED state #25130

merged 3 commits into from
Jun 2, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jun 1, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24574

Output from acceptance testing:

make testacc TESTARGS='-run=TestAccServiceCatalogProvisionedProduct_' PKG=servicecatalog
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicecatalog/... -v -count 1 -parallel 20  -run=TestAccServiceCatalogProvisionedProduct_ -timeout 180m
=== RUN   TestAccServiceCatalogProvisionedProduct_basic
=== PAUSE TestAccServiceCatalogProvisionedProduct_basic
=== RUN   TestAccServiceCatalogProvisionedProduct_update
=== PAUSE TestAccServiceCatalogProvisionedProduct_update
=== RUN   TestAccServiceCatalogProvisionedProduct_disappears
=== PAUSE TestAccServiceCatalogProvisionedProduct_disappears
=== RUN   TestAccServiceCatalogProvisionedProduct_tags
=== PAUSE TestAccServiceCatalogProvisionedProduct_tags
=== RUN   TestAccServiceCatalogProvisionedProduct_tainted
=== PAUSE TestAccServiceCatalogProvisionedProduct_tainted
=== CONT  TestAccServiceCatalogProvisionedProduct_basic
=== CONT  TestAccServiceCatalogProvisionedProduct_tags
=== CONT  TestAccServiceCatalogProvisionedProduct_tainted
=== CONT  TestAccServiceCatalogProvisionedProduct_disappears
=== CONT  TestAccServiceCatalogProvisionedProduct_update
--- PASS: TestAccServiceCatalogProvisionedProduct_disappears (134.41s)
--- PASS: TestAccServiceCatalogProvisionedProduct_basic (139.38s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tainted (213.92s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags (228.76s)
--- PASS: TestAccServiceCatalogProvisionedProduct_update (229.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog	232.687s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. labels Jun 1, 2022
@anGie44 anGie44 changed the title r/servicecatalog_provisioned_product: return error when in the 'TAINT… r/servicecatalog_provisioned_product: fix error when in the TAINTED state Jun 1, 2022
@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Jun 1, 2022
@anGie44 anGie44 force-pushed the b-servicecatalog-provisioned-product-record-return-error-on-tainted branch from 353d8e1 to 5a87cd3 Compare June 1, 2022 15:38
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jun 2, 2022
@anGie44 anGie44 force-pushed the b-servicecatalog-provisioned-product-record-return-error-on-tainted branch from cb271a3 to bd1774f Compare June 2, 2022 18:35
@anGie44 anGie44 marked this pull request as ready for review June 2, 2022 18:43
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Jun 2, 2022
ewbankkit
ewbankkit approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccServiceCatalogProvisionedProduct_' PKG=servicecatalog ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicecatalog/... -v -count 1 -parallel 3  -run=TestAccServiceCatalogProvisionedProduct_ -timeout 180m
=== RUN   TestAccServiceCatalogProvisionedProduct_basic
=== PAUSE TestAccServiceCatalogProvisionedProduct_basic
=== RUN   TestAccServiceCatalogProvisionedProduct_update
=== PAUSE TestAccServiceCatalogProvisionedProduct_update
=== RUN   TestAccServiceCatalogProvisionedProduct_disappears
=== PAUSE TestAccServiceCatalogProvisionedProduct_disappears
=== RUN   TestAccServiceCatalogProvisionedProduct_tags
=== PAUSE TestAccServiceCatalogProvisionedProduct_tags
=== RUN   TestAccServiceCatalogProvisionedProduct_tainted
=== PAUSE TestAccServiceCatalogProvisionedProduct_tainted
=== CONT  TestAccServiceCatalogProvisionedProduct_basic
=== CONT  TestAccServiceCatalogProvisionedProduct_tags
=== CONT  TestAccServiceCatalogProvisionedProduct_disappears
--- PASS: TestAccServiceCatalogProvisionedProduct_disappears (138.92s)
=== CONT  TestAccServiceCatalogProvisionedProduct_tainted
--- PASS: TestAccServiceCatalogProvisionedProduct_basic (140.70s)
=== CONT  TestAccServiceCatalogProvisionedProduct_update
--- PASS: TestAccServiceCatalogProvisionedProduct_tags (231.58s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tainted (211.71s)
--- PASS: TestAccServiceCatalogProvisionedProduct_update (229.81s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog	376.472s

@anGie44 anGie44 added this to the v4.17.0 milestone Jun 2, 2022
@anGie44 anGie44 merged commit 6860422 into main Jun 2, 2022
@anGie44 anGie44 deleted the b-servicecatalog-provisioned-product-record-return-error-on-tainted branch June 2, 2022 21:55
github-actions bot pushed a commit that referenced this pull request Jun 2, 2022
Update CHANGELOG.md for #25130
c7f398d
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

This functionality has been released in v4.17.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jul 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.17.0
2 participants
@anGie44 @ewbankkit