Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/kendra_thesaurus: new resource #25199

Merged
merged 2 commits into from
Jun 20, 2022
Merged

r/kendra_thesaurus: new resource #25199

merged 2 commits into from
Jun 20, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jun 7, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13367

Output from acceptance testing:

$  make testacc TESTARGS='-run=TestAccKendra_serial/Thesaurus' PKG=kendra
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kendra/... -v -count 1 -parallel 20  -run=TestAccKendra_serial/Thesaurus -timeout 180m
--- PASS: TestAccKendra_serial (6560.35s)
    --- PASS: TestAccKendra_serial/Thesaurus (4817.69s)
        --- PASS: TestAccKendra_serial/Thesaurus/Description (645.58s)
        --- PASS: TestAccKendra_serial/Thesaurus/Name (2252.80s)
        --- PASS: TestAccKendra_serial/Thesaurus/RoleARN (1004.33s)
        --- PASS: TestAccKendra_serial/Thesaurus/SourceS3Path (914.98s)
        --- PASS: TestAccKendra_serial/Thesaurus/tags (1187.25s)
        --- PASS: TestAccKendra_serial/Thesaurus/disappears (1734.60s)
        --- PASS: TestAccKendra_serial/Thesaurus/basic (1742.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kendra	6563.565s

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/kendra Issues and PRs that pertain to the kendra service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 7, 2022
anGie44 added a commit that referenced this pull request Jun 7, 2022
@anGie44
Update CHANGELOG for #25199
6be3ba7
@anGie44 anGie44 mentioned this pull request Jun 7, 2022
Closed
@anGie44 anGie44 added the new-resource Introduces a new resource. label Jun 7, 2022
anGie44 added a commit that referenced this pull request Jun 14, 2022
@anGie44
Update CHANGELOG for #25199
c553cb1
@anGie44 anGie44 force-pushed the f-kendra-thesaurus branch 6 times, most recently from 436a6cd to 63d165a Compare June 15, 2022 01:28
@anGie44 anGie44 force-pushed the f-kendra-thesaurus branch from 63d165a to 29a5681 Compare June 19, 2022 00:31
@anGie44 anGie44 force-pushed the f-kendra-thesaurus branch from 29a5681 to 84bc12c Compare June 19, 2022 00:54
@anGie44 anGie44 force-pushed the f-kendra-thesaurus branch from 84bc12c to ea8326a Compare June 19, 2022 01:03
@anGie44 anGie44 force-pushed the f-kendra-thesaurus branch from ea8326a to 695e607 Compare June 19, 2022 01:05
@anGie44 anGie44 force-pushed the f-kendra-thesaurus branch from 695e607 to 4099821 Compare June 19, 2022 01:17
anGie44 added a commit that referenced this pull request Jun 19, 2022
@anGie44
Update CHANGELOG for #25199
93b4cd1
@anGie44 anGie44 force-pushed the f-kendra-thesaurus branch from 4099821 to 93b4cd1 Compare June 19, 2022 01:27
@anGie44 anGie44 force-pushed the f-kendra-thesaurus branch from 70ba034 to c8513b0 Compare June 19, 2022 03:41
@anGie44 anGie44 marked this pull request as ready for review June 20, 2022 17:27
@ewbankkit ewbankkit self-assigned this Jun 20, 2022
ewbankkit
ewbankkit approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccKendra_serial/Thesaurus' PKG=kendra
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kendra/... -v -count 1 -parallel 20  -run=TestAccKendra_serial/Thesaurus -timeout 360m
=== RUN   TestAccKendra_serial
=== RUN   TestAccKendra_serial/Thesaurus
=== RUN   TestAccKendra_serial/Thesaurus/Name
=== RUN   TestAccKendra_serial/Thesaurus/RoleARN
=== RUN   TestAccKendra_serial/Thesaurus/SourceS3Path
=== RUN   TestAccKendra_serial/Thesaurus/basic
=== PAUSE TestAccKendra_serial/Thesaurus/basic
=== RUN   TestAccKendra_serial/Thesaurus/disappears
=== PAUSE TestAccKendra_serial/Thesaurus/disappears
=== RUN   TestAccKendra_serial/Thesaurus/tags
=== PAUSE TestAccKendra_serial/Thesaurus/tags
=== RUN   TestAccKendra_serial/Thesaurus/Description
=== CONT  TestAccKendra_serial/Thesaurus/basic
=== CONT  TestAccKendra_serial/Thesaurus/tags
=== CONT  TestAccKendra_serial/Thesaurus/disappears
--- PASS: TestAccKendra_serial (7507.54s)
    --- PASS: TestAccKendra_serial/Thesaurus (5429.74s)
        --- PASS: TestAccKendra_serial/Thesaurus/Name (1020.54s)
        --- PASS: TestAccKendra_serial/Thesaurus/RoleARN (994.11s)
        --- PASS: TestAccKendra_serial/Thesaurus/SourceS3Path (2024.86s)
        --- PASS: TestAccKendra_serial/Thesaurus/Description (1390.23s)
        --- PASS: TestAccKendra_serial/Thesaurus/disappears (1002.21s)
        --- PASS: TestAccKendra_serial/Thesaurus/basic (1005.83s)
        --- PASS: TestAccKendra_serial/Thesaurus/tags (2077.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kendra	7511.865s

@ewbankkit ewbankkit removed their assignment Jun 20, 2022
@anGie44 anGie44 added this to the v4.20.0 milestone Jun 20, 2022
@anGie44 anGie44 merged commit 4d33f57 into main Jun 20, 2022
@anGie44 anGie44 deleted the f-kendra-thesaurus branch June 20, 2022 23:38
github-actions bot pushed a commit that referenced this pull request Jun 20, 2022
Update CHANGELOG.md for #25199
268b2a1
@GlennChia GlennChia mentioned this pull request Jun 22, 2022
Merged
@github-actions
Copy link

This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/kendra Issues and PRs that pertain to the kendra service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anGie44 @ewbankkit