Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PITR restoration on aws_dynamodb_table not currently useful #25214

Closed
Phil-Pinkowski opened this issue Jun 7, 2022 · 2 comments · Fixed by #25659
Closed

PITR restoration on aws_dynamodb_table not currently useful #25214

Phil-Pinkowski opened this issue Jun 7, 2022 · 2 comments · Fixed by #25659
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/dynamodb Issues and PRs that pertain to the dynamodb service.
Milestone

Comments

@Phil-Pinkowski
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently there are a few attributes that allow us to create a new DynamoDB table, restored from a PITR backup of an existing table. This is done by using the restore_source_name and restore_to_latest_time or restore_date_time attributes.

This works initially, and the data is restored into the new table, however there is effectively no where to go after this point, and therefore the restore is useless. Any change to either of these attributes forces a replace on the table, which means we are unable to remove the attributes and therefore remove the old table that the data was restored from. It's also not possible to restore the original table from this restored table, as this causes a cyclical dependency. The only way forward currently would be to accept the original unused table hanging around, which isn't practical.

New or Affected Resource(s)

  • aws_dynamodb_table

Potential Terraform Configuration

The way this could work is to force replace on the resource only when restore_source_name is changed to another value (for example, changed from null to a table name, or from one table name to another), but not when it is removed - this should not force a resource replacement.

@Phil-Pinkowski Phil-Pinkowski added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 7, 2022
@Phil-Pinkowski Phil-Pinkowski changed the title PITR restoration on aws_dynamodb_table not currently useful PITR restoration on aws_dynamodb_table not currently useful Jun 7, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/dynamodb Issues and PRs that pertain to the dynamodb service. labels Jun 7, 2022
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jun 7, 2022
@github-actions github-actions bot added this to the v4.22.0 milestone Jul 6, 2022
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This functionality has been released in v4.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/dynamodb Issues and PRs that pertain to the dynamodb service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants