4.17.0 broke public subnets in eks

[MatthewFagan]

You incorporated a change 6 days ago. It breaks public subnet handling. We have spent the last week tearing our hair out trying to understand why our eks nodes no longer join the eks cluster. Despite the nodes being created in a public subnet, the new change stops them from getting a public ip. This will affect anyone using the terraform-aws-modules/eks/aws, at a minimum.

[justinretzolk]

Hey @MatthewFagan 👋 Thank you for taking the time to raise this! So that we have all of the necessary information in order to look into this, can you update the issue description to include all of the information requested in the bug report template?

[dghubble]

This is the same as #25244

[MatthewFagan]

We fixed by pinning all of our versions to 4.16.0

The problem is this change: #17695

I can see the reason for the change, but it is a breaking change

[github-actions]

This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.