Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/synthetics_canary - add delete_lambda argument #25284

Merged
merged 3 commits into from
Jun 23, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jun 11, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19288

Output from acceptance testing:

$ make testacc TESTS=TestAccSyntheticsCanary_ PKG=synthetics
--- PASS: TestAccSyntheticsCanary_disappears (84.28s)
--- PASS: TestAccSyntheticsCanary_s3 (93.01s)
--- PASS: TestAccSyntheticsCanary_artifactEncryption (106.73s)
--- PASS: TestAccSyntheticsCanary_runtimeVersion (130.89s)
--- PASS: TestAccSyntheticsCanary_basic (133.96s)
--- PASS: TestAccSyntheticsCanary_runTracing (137.44s)
--- PASS: TestAccSyntheticsCanary_tags (150.96s)
--- PASS: TestAccSyntheticsCanary_startCanary (158.98s)
--- PASS: TestAccSyntheticsCanary_run (178.02s)
--- PASS: TestAccSyntheticsCanary_vpc (1441.25s)

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/synthetics Issues and PRs that pertain to the synthetics service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Jun 11, 2022
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 11, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review June 11, 2022 19:18
@DrFaust92 DrFaust92 force-pushed the sythetics-canary-delete-lambda branch from 109e008 to 9a65162 Compare June 22, 2022 20:52
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSyntheticsCanary_' PKG=synthetics ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/synthetics/... -v -count 1 -parallel 2  -run=TestAccSyntheticsCanary_ -timeout 180m
=== RUN   TestAccSyntheticsCanary_basic
=== PAUSE TestAccSyntheticsCanary_basic
=== RUN   TestAccSyntheticsCanary_artifactEncryption
=== PAUSE TestAccSyntheticsCanary_artifactEncryption
=== RUN   TestAccSyntheticsCanary_runtimeVersion
=== PAUSE TestAccSyntheticsCanary_runtimeVersion
=== RUN   TestAccSyntheticsCanary_startCanary
=== PAUSE TestAccSyntheticsCanary_startCanary
=== RUN   TestAccSyntheticsCanary_StartCanary_codeChanges
=== PAUSE TestAccSyntheticsCanary_StartCanary_codeChanges
=== RUN   TestAccSyntheticsCanary_s3
=== PAUSE TestAccSyntheticsCanary_s3
=== RUN   TestAccSyntheticsCanary_run
=== PAUSE TestAccSyntheticsCanary_run
=== RUN   TestAccSyntheticsCanary_runTracing
=== PAUSE TestAccSyntheticsCanary_runTracing
=== RUN   TestAccSyntheticsCanary_runEnvironmentVariables
=== PAUSE TestAccSyntheticsCanary_runEnvironmentVariables
=== RUN   TestAccSyntheticsCanary_vpc
=== PAUSE TestAccSyntheticsCanary_vpc
=== RUN   TestAccSyntheticsCanary_tags
=== PAUSE TestAccSyntheticsCanary_tags
=== RUN   TestAccSyntheticsCanary_disappears
=== PAUSE TestAccSyntheticsCanary_disappears
=== CONT  TestAccSyntheticsCanary_basic
=== CONT  TestAccSyntheticsCanary_run
--- PASS: TestAccSyntheticsCanary_basic (99.75s)
=== CONT  TestAccSyntheticsCanary_startCanary
--- PASS: TestAccSyntheticsCanary_run (120.54s)
=== CONT  TestAccSyntheticsCanary_s3
--- PASS: TestAccSyntheticsCanary_s3 (52.09s)
=== CONT  TestAccSyntheticsCanary_StartCanary_codeChanges
--- PASS: TestAccSyntheticsCanary_startCanary (107.71s)
=== CONT  TestAccSyntheticsCanary_vpc
--- PASS: TestAccSyntheticsCanary_StartCanary_codeChanges (114.10s)
=== CONT  TestAccSyntheticsCanary_disappears
--- PASS: TestAccSyntheticsCanary_disappears (71.29s)
=== CONT  TestAccSyntheticsCanary_tags
--- PASS: TestAccSyntheticsCanary_tags (89.25s)
-- PASS: TestAccSyntheticsCanary_runEnvironmentVariables (109.03s)
=== CONT  TestAccSyntheticsCanary_runtimeVersion
--- PASS: TestAccSyntheticsCanary_runtimeVersion (98.15s)
=== CONT  TestAccSyntheticsCanary_artifactEncryption
--- PASS: TestAccSyntheticsCanary_artifactEncryption (84.09s)
=== CONT  TestAccSyntheticsCanary_runTracing
--- PASS: TestAccSyntheticsCanary_runTracing (97.33s)
--- PASS: TestAccSyntheticsCanary_vpc (2153.05s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/synthetics	2366.448s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 2cae196 into hashicorp:main Jun 23, 2022
@github-actions github-actions bot added this to the v4.20.0 milestone Jun 23, 2022
@github-actions
Copy link

This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/synthetics Issues and PRs that pertain to the synthetics service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Synthetics Canary clean up implicitly created resources
2 participants