Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_location_tracker - new resource #25466

Merged
merged 8 commits into from
Jun 22, 2022

Conversation

kamilturek
Copy link
Collaborator

@kamilturek kamilturek commented Jun 18, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #19629.

Output from acceptance testing:

$ make testacc PKG=location TESTS="TestAccLocationTracker_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/location/... -v -count 1 -parallel 20 -run='TestAccLocationTracker_'  -timeout 180m
=== RUN   TestAccLocationTracker_basic
=== PAUSE TestAccLocationTracker_basic
=== RUN   TestAccLocationTracker_disappears
=== PAUSE TestAccLocationTracker_disappears
=== RUN   TestAccLocationTracker_description
=== PAUSE TestAccLocationTracker_description
=== RUN   TestAccLocationTracker_kmsKeyID
=== PAUSE TestAccLocationTracker_kmsKeyID
=== RUN   TestAccLocationTracker_positionFiltering
=== PAUSE TestAccLocationTracker_positionFiltering
=== RUN   TestAccLocationTracker_tags
=== PAUSE TestAccLocationTracker_tags
=== CONT  TestAccLocationTracker_basic
=== CONT  TestAccLocationTracker_kmsKeyID
=== CONT  TestAccLocationTracker_tags
=== CONT  TestAccLocationTracker_description
=== CONT  TestAccLocationTracker_disappears
=== CONT  TestAccLocationTracker_positionFiltering
--- PASS: TestAccLocationTracker_disappears (21.11s)
--- PASS: TestAccLocationTracker_basic (28.40s)
--- PASS: TestAccLocationTracker_kmsKeyID (30.09s)
--- PASS: TestAccLocationTracker_description (45.55s)
--- PASS: TestAccLocationTracker_positionFiltering (45.91s)
--- PASS: TestAccLocationTracker_tags (63.62s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/location   65.480s

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. service/location Issues and PRs that pertain to the location service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 18, 2022
@DrFaust92 DrFaust92 added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 18, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jun 19, 2022
@kamilturek kamilturek force-pushed the f-aws-location-tracker branch from a0da15b to 7330694 Compare June 19, 2022 12:32
@kamilturek kamilturek marked this pull request as ready for review June 19, 2022 13:25
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLocationTracker_' PKG=location ACCTEST_PARALLELISM=2   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/location/... -v -count 1 -parallel 2  -run=TestAccLocationTracker_ -timeout 180m
=== RUN   TestAccLocationTracker_basic
=== PAUSE TestAccLocationTracker_basic
=== RUN   TestAccLocationTracker_disappears
=== PAUSE TestAccLocationTracker_disappears
=== RUN   TestAccLocationTracker_description
=== PAUSE TestAccLocationTracker_description
=== RUN   TestAccLocationTracker_kmsKeyID
=== PAUSE TestAccLocationTracker_kmsKeyID
=== RUN   TestAccLocationTracker_positionFiltering
=== PAUSE TestAccLocationTracker_positionFiltering
=== RUN   TestAccLocationTracker_tags
=== PAUSE TestAccLocationTracker_tags
=== CONT  TestAccLocationTracker_basic
=== CONT  TestAccLocationTracker_kmsKeyID
--- PASS: TestAccLocationTracker_basic (17.77s)
=== CONT  TestAccLocationTracker_description
--- PASS: TestAccLocationTracker_kmsKeyID (19.38s)
=== CONT  TestAccLocationTracker_tags
--- PASS: TestAccLocationTracker_description (27.37s)
=== CONT  TestAccLocationTracker_positionFiltering
--- PASS: TestAccLocationTracker_tags (41.74s)
=== CONT  TestAccLocationTracker_disappears
--- PASS: TestAccLocationTracker_disappears (11.63s)
--- PASS: TestAccLocationTracker_positionFiltering (28.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/location	77.525s

@ewbankkit ewbankkit merged commit 95a8c7a into hashicorp:main Jun 22, 2022
@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@github-actions github-actions bot added this to the v4.20.0 milestone Jun 22, 2022
@kamilturek kamilturek deleted the f-aws-location-tracker branch June 22, 2022 18:25
@github-actions
Copy link

This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/location Issues and PRs that pertain to the location service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants