Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add data source for aws_route53_resolver_firewall_rules #25536

Merged
merged 23 commits into from
Nov 10, 2022
Merged

add data source for aws_route53_resolver_firewall_rules #25536

merged 23 commits into from
Nov 10, 2022

Conversation

silvaalbert
Copy link
Contributor

@silvaalbert silvaalbert commented Jun 23, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25513

Output from acceptance testing:

$ make testacc TESTS='TestAccRoute53ResolverFirewallRulesDataSource_basic' PKG=route53resolver TESTARGS=-short
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 20 -run='TestAccRoute53ResolverFirewallRulesDataSource_basic' -short -timeout 180m
=== RUN   TestAccRoute53ResolverFirewallRulesDataSource_basic
=== PAUSE TestAccRoute53ResolverFirewallRulesDataSource_basic
=== CONT  TestAccRoute53ResolverFirewallRulesDataSource_basic
--- PASS: TestAccRoute53ResolverFirewallRulesDataSource_basic (115.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver	117.673s

...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. service/route53resolver Issues and PRs that pertain to the route53resolver service. size/L Managed by automation to categorize the size of a PR. labels Jun 23, 2022
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Jun 23, 2022
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Jun 27, 2022
@github-actions github-actions bot added generators Relates to code generators. github_actions Pull requests that update Github_actions code linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. service/applicationinsights Issues and PRs that pertain to the applicationinsights service. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. labels Jun 27, 2022
@github-actions github-actions bot removed service/kendra Issues and PRs that pertain to the kendra service. service/kafka Issues and PRs that pertain to the kafka service. service/vpc Issues and PRs that pertain to the vpc service. generators Relates to code generators. service/ecr Issues and PRs that pertain to the ecr service. service/sqs Issues and PRs that pertain to the sqs service. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/ecs Issues and PRs that pertain to the ecs service. service/connect Issues and PRs that pertain to the connect service. labels Jun 27, 2022
@silvaalbert silvaalbert changed the title wip: add data source for aws_route53_resolver_firewall_rules add data source for aws_route53_resolver_firewall_rules Jun 27, 2022
@silvaalbert silvaalbert marked this pull request as ready for review June 27, 2022 17:44
@silvaalbert silvaalbert requested a review from ewbankkit as a code owner June 27, 2022 17:44
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 20, 2022
@ewbankkit
Merge branch 'main' into HEAD
2ee4522
@ewbankkit
d/aws_route53_resolver_firewall_rules: 'id' -> 'firewall_rule_group_id'.
0e73078 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccRoute53ResolverFirewallRulesDataSource_' PKG=route53resolver ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 2  -run=TestAccRoute53ResolverFirewallRulesDataSource_ -timeout 180m
=== RUN   TestAccRoute53ResolverFirewallRulesDataSource_basic
=== PAUSE TestAccRoute53ResolverFirewallRulesDataSource_basic
=== CONT  TestAccRoute53ResolverFirewallRulesDataSource_basic
--- PASS: TestAccRoute53ResolverFirewallRulesDataSource_basic (165.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver	170.142s
@ewbankkit
d/aws_route53_resolver_firewall_rules: Switch to 'WithoutTimeout' CRU…
095cec4 
…D handlers (hashicorp#15090).

Acceptance test output:

% make testacc TESTARGS='-run=TestAccRoute53ResolverFirewallRulesDataSource_\|TestAccRoute53ResolverFirewallRule_' PKG=route53resolver ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 2  -run=TestAccRoute53ResolverFirewallRulesDataSource_\|TestAccRoute53ResolverFirewallRule_ -timeout 180m
=== RUN   TestAccRoute53ResolverFirewallRule_basic
=== PAUSE TestAccRoute53ResolverFirewallRule_basic
=== RUN   TestAccRoute53ResolverFirewallRule_block
=== PAUSE TestAccRoute53ResolverFirewallRule_block
=== RUN   TestAccRoute53ResolverFirewallRule_blockOverride
=== PAUSE TestAccRoute53ResolverFirewallRule_blockOverride
=== RUN   TestAccRoute53ResolverFirewallRule_disappears
=== PAUSE TestAccRoute53ResolverFirewallRule_disappears
=== RUN   TestAccRoute53ResolverFirewallRulesDataSource_basic
=== PAUSE TestAccRoute53ResolverFirewallRulesDataSource_basic
=== CONT  TestAccRoute53ResolverFirewallRule_basic
=== CONT  TestAccRoute53ResolverFirewallRule_disappears
--- PASS: TestAccRoute53ResolverFirewallRule_disappears (56.64s)
=== CONT  TestAccRoute53ResolverFirewallRule_blockOverride
--- PASS: TestAccRoute53ResolverFirewallRule_basic (71.70s)
=== CONT  TestAccRoute53ResolverFirewallRule_block
--- PASS: TestAccRoute53ResolverFirewallRule_blockOverride (64.65s)
=== CONT  TestAccRoute53ResolverFirewallRulesDataSource_basic
--- PASS: TestAccRoute53ResolverFirewallRule_block (63.53s)
--- PASS: TestAccRoute53ResolverFirewallRulesDataSource_basic (157.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver	283.811s
ewbankkit
ewbankkit approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRoute53ResolverFirewallRulesDataSource_\|TestAccRoute53ResolverFirewallRule_' PKG=route53resolver ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 2  -run=TestAccRoute53ResolverFirewallRulesDataSource_\|TestAccRoute53ResolverFirewallRule_ -timeout 180m
=== RUN   TestAccRoute53ResolverFirewallRule_basic
=== PAUSE TestAccRoute53ResolverFirewallRule_basic
=== RUN   TestAccRoute53ResolverFirewallRule_block
=== PAUSE TestAccRoute53ResolverFirewallRule_block
=== RUN   TestAccRoute53ResolverFirewallRule_blockOverride
=== PAUSE TestAccRoute53ResolverFirewallRule_blockOverride
=== RUN   TestAccRoute53ResolverFirewallRule_disappears
=== PAUSE TestAccRoute53ResolverFirewallRule_disappears
=== RUN   TestAccRoute53ResolverFirewallRulesDataSource_basic
=== PAUSE TestAccRoute53ResolverFirewallRulesDataSource_basic
=== CONT  TestAccRoute53ResolverFirewallRule_basic
=== CONT  TestAccRoute53ResolverFirewallRule_disappears
--- PASS: TestAccRoute53ResolverFirewallRule_disappears (56.64s)
=== CONT  TestAccRoute53ResolverFirewallRule_blockOverride
--- PASS: TestAccRoute53ResolverFirewallRule_basic (71.70s)
=== CONT  TestAccRoute53ResolverFirewallRule_block
--- PASS: TestAccRoute53ResolverFirewallRule_blockOverride (64.65s)
=== CONT  TestAccRoute53ResolverFirewallRulesDataSource_basic
--- PASS: TestAccRoute53ResolverFirewallRule_block (63.53s)
--- PASS: TestAccRoute53ResolverFirewallRulesDataSource_basic (157.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver	283.811s

@ewbankkit
Copy link
Contributor

@silvaalbert Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e22ef42 into hashicorp:main Nov 10, 2022
@github-actions github-actions bot added this to the v4.39.0 milestone Nov 10, 2022
@github-actions
Copy link

This functionality has been released in v4.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/route53resolver Issues and PRs that pertain to the route53resolver service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.39.0
Development

Successfully merging this pull request may close these issues.

add data resource for aws_route53_resolver_firewall_rules
4 participants
@silvaalbert @ewbankkit @justinretzolk @albsilv-aws