-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s/sagemaker Add support repository_auth_config in image_config #25557
s/sagemaker Add support repository_auth_config in image_config #25557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @neitomic 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@DrFaust92 thanks for reviewing. Could you please help approve the workflows as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccSageMakerModel_' PKG=sagemaker ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 2 -run=TestAccSageMakerModel_ -timeout 180m
=== RUN TestAccSageMakerModel_basic
=== PAUSE TestAccSageMakerModel_basic
=== RUN TestAccSageMakerModel_inferenceExecution
=== PAUSE TestAccSageMakerModel_inferenceExecution
=== RUN TestAccSageMakerModel_tags
=== PAUSE TestAccSageMakerModel_tags
=== RUN TestAccSageMakerModel_primaryContainerModelDataURL
=== PAUSE TestAccSageMakerModel_primaryContainerModelDataURL
=== RUN TestAccSageMakerModel_primaryContainerHostname
=== PAUSE TestAccSageMakerModel_primaryContainerHostname
=== RUN TestAccSageMakerModel_primaryContainerImage
=== PAUSE TestAccSageMakerModel_primaryContainerImage
=== RUN TestAccSageMakerModel_primaryContainerEnvironment
=== PAUSE TestAccSageMakerModel_primaryContainerEnvironment
=== RUN TestAccSageMakerModel_primaryContainerModeSingle
=== PAUSE TestAccSageMakerModel_primaryContainerModeSingle
=== RUN TestAccSageMakerModel_containers
=== PAUSE TestAccSageMakerModel_containers
=== RUN TestAccSageMakerModel_vpc
=== PAUSE TestAccSageMakerModel_vpc
=== RUN TestAccSageMakerModel_primaryContainerPrivateDockerRegistry
=== PAUSE TestAccSageMakerModel_primaryContainerPrivateDockerRegistry
=== RUN TestAccSageMakerModel_networkIsolation
=== PAUSE TestAccSageMakerModel_networkIsolation
=== RUN TestAccSageMakerModel_disappears
=== PAUSE TestAccSageMakerModel_disappears
=== CONT TestAccSageMakerModel_basic
=== CONT TestAccSageMakerModel_primaryContainerModeSingle
--- PASS: TestAccSageMakerModel_primaryContainerModeSingle (36.40s)
=== CONT TestAccSageMakerModel_primaryContainerHostname
--- PASS: TestAccSageMakerModel_basic (41.92s)
=== CONT TestAccSageMakerModel_primaryContainerEnvironment
--- PASS: TestAccSageMakerModel_primaryContainerHostname (39.73s)
=== CONT TestAccSageMakerModel_primaryContainerPrivateDockerRegistry
--- PASS: TestAccSageMakerModel_primaryContainerEnvironment (40.90s)
=== CONT TestAccSageMakerModel_disappears
--- PASS: TestAccSageMakerModel_disappears (30.28s)
=== CONT TestAccSageMakerModel_networkIsolation
--- PASS: TestAccSageMakerModel_primaryContainerPrivateDockerRegistry (39.26s)
=== CONT TestAccSageMakerModel_primaryContainerImage
--- PASS: TestAccSageMakerModel_networkIsolation (36.99s)
=== CONT TestAccSageMakerModel_tags
--- PASS: TestAccSageMakerModel_primaryContainerImage (39.50s)
=== CONT TestAccSageMakerModel_primaryContainerModelDataURL
--- PASS: TestAccSageMakerModel_primaryContainerModelDataURL (40.71s)
=== CONT TestAccSageMakerModel_vpc
--- PASS: TestAccSageMakerModel_tags (74.95s)
=== CONT TestAccSageMakerModel_inferenceExecution
--- PASS: TestAccSageMakerModel_vpc (37.30s)
=== CONT TestAccSageMakerModel_containers
--- PASS: TestAccSageMakerModel_inferenceExecution (34.05s)
--- PASS: TestAccSageMakerModel_containers (38.91s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker 279.562s
@neitomic Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates OR Closes #0000
Output from acceptance testing: