Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_kendra_data_source #25686

Merged
merged 62 commits into from
Aug 2, 2022
Merged

r/aws_kendra_data_source #25686

merged 62 commits into from
Aug 2, 2022

Conversation

GlennChia
Copy link
Collaborator

@GlennChia GlennChia commented Jul 5, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13367

Note that each acceptance test can potentially take up to 1.5 hours since a Kendra Index must be created first and the Data Source also requires some time to delete. Hence, to speed up the test cases, one way is to create an Index outside of Terraform and hard-code it's ID into the test cases (not committed to GitHub). This also requires tweaks to the test cases to substitute the Kendra Index ARN and ID where it is used.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccKendraDataSource' PKG=kendra ACCTEST_PARALLELISM=20  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kendra/... -v -count 1 -parallel 20  -run=TestAccKendraDataSource -timeout 180m
=== RUN   TestAccKendraDataSource_basic
=== PAUSE TestAccKendraDataSource_basic
=== RUN   TestAccKendraDataSource_disappears
=== PAUSE TestAccKendraDataSource_disappears
=== RUN   TestAccKendraDataSource_name
=== PAUSE TestAccKendraDataSource_name
=== RUN   TestAccKendraDataSource_description
=== PAUSE TestAccKendraDataSource_description
=== RUN   TestAccKendraDataSource_languageCode
=== PAUSE TestAccKendraDataSource_languageCode
=== RUN   TestAccKendraDataSource_roleARN
=== PAUSE TestAccKendraDataSource_roleARN
=== RUN   TestAccKendraDataSource_schedule
=== PAUSE TestAccKendraDataSource_schedule
=== RUN   TestAccKendraDataSource_tags
=== PAUSE TestAccKendraDataSource_tags
=== RUN   TestAccKendraDataSource_typeCustomCustomizeDiff
=== PAUSE TestAccKendraDataSource_typeCustomCustomizeDiff
=== RUN   TestAccKendraDataSource_Configuration_S3_Bucket
=== PAUSE TestAccKendraDataSource_Configuration_S3_Bucket
=== RUN   TestAccKendraDataSource_Configuration_S3_AccessControlList
=== PAUSE TestAccKendraDataSource_Configuration_S3_AccessControlList
=== RUN   TestAccKendraDataSource_Configuration_S3_DocumentsMetadataConfiguration
=== PAUSE TestAccKendraDataSource_Configuration_S3_DocumentsMetadataConfiguration
=== RUN   TestAccKendraDataSource_Configuration_S3_ExclusionInclusionPatternsPrefixes
=== PAUSE TestAccKendraDataSource_Configuration_S3_ExclusionInclusionPatternsPrefixes
=== RUN   TestAccKendraDataSource_Configuration_WebCrawler_URLsSeedURLs
=== PAUSE TestAccKendraDataSource_Configuration_WebCrawler_URLsSeedURLs
=== RUN   TestAccKendraDataSource_Configuration_WebCrawler_URLsWebCrawlerMode
=== PAUSE TestAccKendraDataSource_Configuration_WebCrawler_URLsWebCrawlerMode
=== RUN   TestAccKendraDataSource_Configuration_WebCrawler_AuthenticationConfigurationBasicHostPort
=== PAUSE TestAccKendraDataSource_Configuration_WebCrawler_AuthenticationConfigurationBasicHostPort
=== RUN   TestAccKendraDataSource_Configuration_WebCrawler_AuthenticationConfigurationBasicCredentials
=== PAUSE TestAccKendraDataSource_Configuration_WebCrawler_AuthenticationConfigurationBasicCredentials
=== RUN   TestAccKendraDataSource_Configuration_WebCrawler_CrawlDepth
=== PAUSE TestAccKendraDataSource_Configuration_WebCrawler_CrawlDepth
=== RUN   TestAccKendraDataSource_Configuration_WebCrawler_MaxLinksPerPage
=== PAUSE TestAccKendraDataSource_Configuration_WebCrawler_MaxLinksPerPage
=== RUN   TestAccKendraDataSource_Configuration_WebCrawler_MaxURLsPerMinuteCrawlRate
=== PAUSE TestAccKendraDataSource_Configuration_WebCrawler_MaxURLsPerMinuteCrawlRate
=== RUN   TestAccKendraDataSource_Configuration_WebCrawler_ProxyConfigurationCredentials
=== PAUSE TestAccKendraDataSource_Configuration_WebCrawler_ProxyConfigurationCredentials
=== RUN   TestAccKendraDataSource_Configuration_WebCrawler_ProxyConfigurationHostPort
=== PAUSE TestAccKendraDataSource_Configuration_WebCrawler_ProxyConfigurationHostPort
=== RUN   TestAccKendraDataSource_Configuration_WebCrawler_URLExclusionInclusionPatterns
=== PAUSE TestAccKendraDataSource_Configuration_WebCrawler_URLExclusionInclusionPatterns
=== RUN   TestAccKendraDataSource_Configuration_WebCrawler_URLsSiteMaps
=== PAUSE TestAccKendraDataSource_Configuration_WebCrawler_URLsSiteMaps
=== RUN   TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_InlineConfigurations
=== PAUSE TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_InlineConfigurations
=== RUN   TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_InvocationCondition
=== PAUSE TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_InvocationCondition
=== RUN   TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_RoleARN
=== PAUSE TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_RoleARN
=== RUN   TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_S3Bucket
=== PAUSE TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_S3Bucket
=== RUN   TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_LambdaARN
=== PAUSE TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_LambdaARN
=== CONT  TestAccKendraDataSource_basic
=== CONT  TestAccKendraDataSource_Configuration_WebCrawler_AuthenticationConfigurationBasicHostPort
=== CONT  TestAccKendraDataSource_Configuration_WebCrawler_URLExclusionInclusionPatterns
=== CONT  TestAccKendraDataSource_Configuration_WebCrawler_ProxyConfigurationHostPort
=== CONT  TestAccKendraDataSource_Configuration_WebCrawler_ProxyConfigurationCredentials
=== CONT  TestAccKendraDataSource_Configuration_S3_Bucket
=== CONT  TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_RoleARN
=== CONT  TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_LambdaARN
=== CONT  TestAccKendraDataSource_typeCustomCustomizeDiff
=== CONT  TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_S3Bucket
=== CONT  TestAccKendraDataSource_Configuration_WebCrawler_MaxLinksPerPage
=== CONT  TestAccKendraDataSource_Configuration_WebCrawler_URLsSeedURLs
=== CONT  TestAccKendraDataSource_Configuration_S3_ExclusionInclusionPatternsPrefixes
=== CONT  TestAccKendraDataSource_Configuration_S3_DocumentsMetadataConfiguration
=== CONT  TestAccKendraDataSource_Configuration_S3_AccessControlList
=== CONT  TestAccKendraDataSource_Configuration_WebCrawler_CrawlDepth
=== CONT  TestAccKendraDataSource_Configuration_WebCrawler_MaxURLsPerMinuteCrawlRate
=== CONT  TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_InlineConfigurations
=== CONT  TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_InvocationCondition
=== CONT  TestAccKendraDataSource_Configuration_WebCrawler_URLsWebCrawlerMode
--- PASS: TestAccKendraDataSource_typeCustomCustomizeDiff (22.78s)
=== CONT  TestAccKendraDataSource_languageCode
--- PASS: TestAccKendraDataSource_basic (1050.67s)
=== CONT  TestAccKendraDataSource_tags
--- PASS: TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_LambdaARN (1093.23s)
=== CONT  TestAccKendraDataSource_schedule
--- PASS: TestAccKendraDataSource_Configuration_WebCrawler_MaxLinksPerPage (1094.91s)
=== CONT  TestAccKendraDataSource_roleARN
--- PASS: TestAccKendraDataSource_languageCode (1078.92s)
=== CONT  TestAccKendraDataSource_Configuration_WebCrawler_AuthenticationConfigurationBasicCredentials
--- PASS: TestAccKendraDataSource_Configuration_WebCrawler_ProxyConfigurationCredentials (1104.62s)
=== CONT  TestAccKendraDataSource_name
--- PASS: TestAccKendraDataSource_Configuration_S3_ExclusionInclusionPatternsPrefixes (1107.71s)
=== CONT  TestAccKendraDataSource_description
--- PASS: TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_RoleARN (1150.66s)
=== CONT  TestAccKendraDataSource_Configuration_WebCrawler_URLsSiteMaps
--- PASS: TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_InlineConfigurations (1165.52s)
=== CONT  TestAccKendraDataSource_disappears
--- PASS: TestAccKendraDataSource_Configuration_WebCrawler_URLExclusionInclusionPatterns (1170.37s)
--- PASS: TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_InvocationCondition (1181.17s)
--- PASS: TestAccKendraDataSource_Configuration_WebCrawler_URLsSeedURLs (1182.57s)
--- PASS: TestAccKendraDataSource_Configuration_S3_Bucket (1188.87s)
--- PASS: TestAccKendraDataSource_Configuration_S3_AccessControlList (1193.19s)
--- PASS: TestAccKendraDataSource_Configuration_WebCrawler_CrawlDepth (1196.61s)
--- PASS: TestAccKendraDataSource_Configuration_WebCrawler_AuthenticationConfigurationBasicHostPort (1204.48s)
--- PASS: TestAccKendraDataSource_Configuration_WebCrawler_URLsWebCrawlerMode (1219.31s)
--- PASS: TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_S3Bucket (1220.16s)
--- PASS: TestAccKendraDataSource_Configuration_S3_DocumentsMetadataConfiguration (1224.88s)
--- PASS: TestAccKendraDataSource_Configuration_WebCrawler_ProxyConfigurationHostPort (1449.18s)
--- PASS: TestAccKendraDataSource_Configuration_WebCrawler_MaxURLsPerMinuteCrawlRate (1450.15s)
--- PASS: TestAccKendraDataSource_tags (1096.49s)
--- PASS: TestAccKendraDataSource_description (1049.40s)
--- PASS: TestAccKendraDataSource_name (1056.36s)
--- PASS: TestAccKendraDataSource_Configuration_WebCrawler_AuthenticationConfigurationBasicCredentials (1137.03s)
--- PASS: TestAccKendraDataSource_roleARN (1191.26s)
--- PASS: TestAccKendraDataSource_disappears (1126.34s)
--- PASS: TestAccKendraDataSource_schedule (1203.52s)
--- PASS: TestAccKendraDataSource_Configuration_WebCrawler_URLsSiteMaps (1388.75s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kendra     2539.486s

Some notes

  • date_value in the documentation supports multiple timezones in ISO 8601 date-time format. However, since this value is within a TypeSet, I am unable to suppress the diffs. Hence, the provider can only support UTC at the moment and this is called out in the README

GlennChia added 23 commits June 29, 2022 23:08
@GlennChia
feat(kendra): datasource basic schema
00e011f
@GlennChia
feat(kendra): datasource basic read
01b03d5
@GlennChia
feat(kendra): datasource basic create
b6cf527
@GlennChia
feat(kendra): datasource basic update
eaf335e
@GlennChia
feat(kendra): datasource basic delete
33ef9ba
@GlennChia
feat(kendra): aws_kendra_data_source provider
e99b0ea
@GlennChia
test(kendra): datasource basic test
69dfc2c
@GlennChia
test(kendra): datasource disappears test
4dc39ce
@GlennChia
test(kendra): datasource update description
ca61a1b
@GlennChia
test(kendra): datasource update language_code
de9e98d
@GlennChia
test(kendra): datasource update tags
6b27104
@GlennChia
feat(kendra): role_arn conflicts with type CUSTOM
6e75013
@GlennChia
feat(kendra): add s3_configuration arg
539e92a
@GlennChia
test(kendra): custom diff with configuration
0a32357
@GlennChia
test(kendra): datasource s3 config update bucket
2ae4ee8
@GlennChia
test(kendra): datasource s3 config update acl
e2355f9
@GlennChia
test(kendra): datasource update role_arn
bf103fe
@GlennChia
feat(kendra): schedule conflicts with type CUSTOM
ad85f69
@GlennChia
test(kendra): datasource update schedule
2ec69f0
@GlennChia
test(kendra): datasource update doc metadata conf
9bfc06d
@GlennChia
test(kendra): datasource update exc inc pat pref
70e1ea1
@GlennChia
feat(kendra): datasource custom_doc_enrich_config
768c324
@GlennChia
test(kendra): custom doc enrich inline config
a50a108 
Step 3/3 error: After applying this test step and
performing a `terraform refresh`, the plan was not empty.
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. flex Pertains to FLatteners and EXpanders. provider Pertains to the provider itself, rather than any interaction with AWS. service/kendra Issues and PRs that pertain to the kendra service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 5, 2022
@GlennChia GlennChia force-pushed the f-aws_kendra_data_source branch from f15b391 to dea7719 Compare July 29, 2022 03:09
@GlennChia GlennChia force-pushed the f-aws_kendra_data_source branch from dea7719 to f4f7e30 Compare July 29, 2022 03:56
@GlennChia GlennChia marked this pull request as ready for review July 29, 2022 16:39
@GlennChia GlennChia changed the title [WIP] r/aws_kendra_data_source r/aws_kendra_data_source Jul 29, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jul 29, 2022
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jul 29, 2022
@GlennChia
refactor(kendra): unserialize acc tests
0ed37f7
@GlennChia
fix(kendra): datasource retry if iam perm not prop
9fd362e 
ValidationException: Secrets Manager throws the exception: User
is not authorized to perform: secretsmanager:GetSecretValue on resource:
because no identity-based policy allows the
secretsmanager:GetSecretValue action
ewbankkit
ewbankkit approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=1800m make testacc TESTARGS='-run=TestAccKendraDataSource_' PKG=kendra ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kendra/... -v -count 1 -parallel 3  -run=TestAccKendraDataSource_ -timeout 1800m
=== RUN   TestAccKendraDataSource_basic
=== PAUSE TestAccKendraDataSource_basic
=== RUN   TestAccKendraDataSource_disappears
=== PAUSE TestAccKendraDataSource_disappears
=== RUN   TestAccKendraDataSource_name
=== PAUSE TestAccKendraDataSource_name
=== RUN   TestAccKendraDataSource_description
=== PAUSE TestAccKendraDataSource_description
=== RUN   TestAccKendraDataSource_languageCode
=== PAUSE TestAccKendraDataSource_languageCode
=== RUN   TestAccKendraDataSource_roleARN
=== PAUSE TestAccKendraDataSource_roleARN
=== RUN   TestAccKendraDataSource_schedule
=== PAUSE TestAccKendraDataSource_schedule
=== RUN   TestAccKendraDataSource_tags
=== PAUSE TestAccKendraDataSource_tags
=== RUN   TestAccKendraDataSource_typeCustomCustomizeDiff
=== PAUSE TestAccKendraDataSource_typeCustomCustomizeDiff
=== RUN   TestAccKendraDataSource_Configuration_S3_Bucket
=== PAUSE TestAccKendraDataSource_Configuration_S3_Bucket
=== RUN   TestAccKendraDataSource_Configuration_S3_AccessControlList
=== PAUSE TestAccKendraDataSource_Configuration_S3_AccessControlList
=== RUN   TestAccKendraDataSource_Configuration_S3_DocumentsMetadataConfiguration
=== PAUSE TestAccKendraDataSource_Configuration_S3_DocumentsMetadataConfiguration
=== RUN   TestAccKendraDataSource_Configuration_S3_ExclusionInclusionPatternsPrefixes
=== PAUSE TestAccKendraDataSource_Configuration_S3_ExclusionInclusionPatternsPrefixes
=== RUN   TestAccKendraDataSource_Configuration_WebCrawler_URLsSeedURLs
=== PAUSE TestAccKendraDataSource_Configuration_WebCrawler_URLsSeedURLs
=== RUN   TestAccKendraDataSource_Configuration_WebCrawler_URLsWebCrawlerMode
=== PAUSE TestAccKendraDataSource_Configuration_WebCrawler_URLsWebCrawlerMode
=== RUN   TestAccKendraDataSource_Configuration_WebCrawler_AuthenticationConfigurationBasicHostPort
=== PAUSE TestAccKendraDataSource_Configuration_WebCrawler_AuthenticationConfigurationBasicHostPort
=== RUN   TestAccKendraDataSource_Configuration_WebCrawler_AuthenticationConfigurationBasicCredentials
=== PAUSE TestAccKendraDataSource_Configuration_WebCrawler_AuthenticationConfigurationBasicCredentials
=== RUN   TestAccKendraDataSource_Configuration_WebCrawler_CrawlDepth
=== PAUSE TestAccKendraDataSource_Configuration_WebCrawler_CrawlDepth
=== RUN   TestAccKendraDataSource_Configuration_WebCrawler_MaxLinksPerPage
=== PAUSE TestAccKendraDataSource_Configuration_WebCrawler_MaxLinksPerPage
=== RUN   TestAccKendraDataSource_Configuration_WebCrawler_MaxURLsPerMinuteCrawlRate
=== PAUSE TestAccKendraDataSource_Configuration_WebCrawler_MaxURLsPerMinuteCrawlRate
=== RUN   TestAccKendraDataSource_Configuration_WebCrawler_ProxyConfigurationCredentials
=== PAUSE TestAccKendraDataSource_Configuration_WebCrawler_ProxyConfigurationCredentials
=== RUN   TestAccKendraDataSource_Configuration_WebCrawler_ProxyConfigurationHostPort
=== PAUSE TestAccKendraDataSource_Configuration_WebCrawler_ProxyConfigurationHostPort
=== RUN   TestAccKendraDataSource_Configuration_WebCrawler_URLExclusionInclusionPatterns
=== PAUSE TestAccKendraDataSource_Configuration_WebCrawler_URLExclusionInclusionPatterns
=== RUN   TestAccKendraDataSource_Configuration_WebCrawler_URLsSiteMaps
=== PAUSE TestAccKendraDataSource_Configuration_WebCrawler_URLsSiteMaps
=== RUN   TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_InlineConfigurations
=== PAUSE TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_InlineConfigurations
=== RUN   TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_InvocationCondition
=== PAUSE TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_InvocationCondition
=== RUN   TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_RoleARN
=== PAUSE TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_RoleARN
=== RUN   TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_S3Bucket
=== PAUSE TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_S3Bucket
=== RUN   TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_LambdaARN
=== PAUSE TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_LambdaARN
=== CONT  TestAccKendraDataSource_basic
=== CONT  TestAccKendraDataSource_Configuration_WebCrawler_AuthenticationConfigurationBasicHostPort
=== CONT  TestAccKendraDataSource_typeCustomCustomizeDiff
--- PASS: TestAccKendraDataSource_typeCustomCustomizeDiff (1124.29s)
=== CONT  TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_LambdaARN
--- PASS: TestAccKendraDataSource_basic (2711.16s)
=== CONT  TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_S3Bucket
--- PASS: TestAccKendraDataSource_Configuration_WebCrawler_AuthenticationConfigurationBasicHostPort (3044.67s)
=== CONT  TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_RoleARN
--- PASS: TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_LambdaARN (1983.24s)
=== CONT  TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_InvocationCondition
--- PASS: TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_RoleARN (1682.75s)
=== CONT  TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_InlineConfigurations
--- PASS: TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_S3Bucket (2077.58s)
=== CONT  TestAccKendraDataSource_Configuration_WebCrawler_URLsSiteMaps
--- PASS: TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_ExtractionHookConfiguration_InvocationCondition (3200.47s)
=== CONT  TestAccKendraDataSource_Configuration_WebCrawler_URLExclusionInclusionPatterns
--- PASS: TestAccKendraDataSource_CustomDocumentEnrichmentConfiguration_InlineConfigurations (1808.07s)
=== CONT  TestAccKendraDataSource_Configuration_WebCrawler_ProxyConfigurationHostPort
--- PASS: TestAccKendraDataSource_Configuration_WebCrawler_URLsSiteMaps (1749.39s)
=== CONT  TestAccKendraDataSource_Configuration_WebCrawler_ProxyConfigurationCredentials
--- PASS: TestAccKendraDataSource_Configuration_WebCrawler_ProxyConfigurationHostPort (233.39s)
=== CONT  TestAccKendraDataSource_Configuration_WebCrawler_MaxURLsPerMinuteCrawlRate
--- PASS: TestAccKendraDataSource_Configuration_WebCrawler_ProxyConfigurationCredentials (234.03s)
=== CONT  TestAccKendraDataSource_Configuration_WebCrawler_MaxLinksPerPage
--- PASS: TestAccKendraDataSource_Configuration_WebCrawler_URLExclusionInclusionPatterns (504.84s)
=== CONT  TestAccKendraDataSource_Configuration_WebCrawler_CrawlDepth
^CFAIL	github.com/hashicorp/terraform-provider-aws/internal/service/kendra	6926.217s

Testing cut short by network connectivity problems 😄.
We'll check status in nightly CI.

@ewbankkit ewbankkit merged commit a53007c into hashicorp:main Aug 2, 2022
@github-actions github-actions bot added this to the v4.25.0 milestone Aug 2, 2022
@GlennChia GlennChia mentioned this pull request Aug 2, 2022
Merged
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

This functionality has been released in v4.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@GlennChia GlennChia deleted the f-aws_kendra_data_source branch August 6, 2022 02:55
@github-actions
Copy link

github-actions bot commented Sep 6, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. flex Pertains to FLatteners and EXpanders. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/kendra Issues and PRs that pertain to the kendra service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@GlennChia @ewbankkit @justinretzolk